Skip to content
Snippets Groups Projects
  1. Jul 06, 2023
  2. Oct 17, 2022
    • Cole Faust's avatar
      Fix errorprone warnings that should be errors · 91cb9a6a
      Cole Faust authored
      This commit is part of a large scale change to fix errorprone
      errors that have been downgraded to warnings in the android
      source tree, so that they can be promoted to errors again.
      The full list of changes include the following, but not all
      will be present in any one individual commit:
      
      BadAnnotationImplementation
      BadShiftAmount
      BanJNDI
      BoxedPrimitiveEquality
      ComparableType
      ComplexBooleanConstant
      CollectionToArraySafeParameter
      ConditionalExpressionNumericPromotion
      DangerousLiteralNull
      DoubleBraceInitialization
      DurationFrom
      DurationTemporalUnit
      EmptyTopLevelDeclaration
      EqualsNull
      EqualsReference
      FormatString
      FromTemporalAccessor
      GetClassOnAnnotation
      GetClassOnClass
      HashtableContains
      IdentityBinaryExpression
      IdentityHashMapBoxing
      InstantTemporalUnit
      InvalidTimeZoneID
      InvalidZoneId
      IsInstanceIncompatibleType
      JUnitParameterMethodNotFound
      LockOnBoxedPrimitive
      MathRoundIntLong
      MislabeledAndroidString
      MisusedDayOfYear
      MissingSuperCall
      MisusedWeekYear
      ModifyingCollectionWithItself
      NoCanIgnoreReturnValueOnClasses
      NonRuntimeAnnotation
      NullableOnContainingClass
      NullTernary
      OverridesJavaxInjectableMethod
      ParcelableCreator
      PeriodFrom
      PreconditionsInvalidPlaceholder
      ProtoBuilderReturnValueIgnored
      ProtoFieldNullComparison
      RandomModInteger
      RectIntersectReturnValueIgnored
      ReturnValueIgnored
      SelfAssignment
      SelfComparison
      SelfEquals
      SizeGreaterThanOrEqualsZero
      StringBuilderInitWithChar
      TreeToString
      TryFailThrowable
      UnnecessaryCheckNotNull
      UnusedCollectionModifiedInPlace
      XorPower
      
      See https://errorprone.info/bugpatterns for more
      information on the checks.
      
      Bug: 253827323
      Test: m RUN_ERROR_PRONE=true javac-check
      Change-Id: I454a105ae82484a2d19aff1808e8d9dd55ba64f4
      91cb9a6a
  3. Aug 16, 2022
    • Cole Faust's avatar
      Fix array-related errorprone warnings · 7ad99e34
      Cole Faust authored
      The ArrayEquals, ArrayHashCode, ArrayToString, and
      ArraysAsListPrimitiveArray errorprone findings were
      demoted from errors to warnings. Fix existing
      occurrences of them so they can be made errors again.
      
      Bug: 242630963
      Test: RUN_ERROR_PRONE=true m javac-check
      Change-Id: I689397a7196277de3fd301836e72f7555e2036cb
      7ad99e34
  4. Feb 23, 2022
    • Wilson Wu's avatar
      Remove unused method for dictionarypack · 0d93961d
      Wilson Wu authored
      Remove the showDictionaryAvailableNotification
      method since there is no module use it.
      
      Bug: 209479751
      Test: presubmit
      Change-Id: I4c88b4a2d0cb36761d9102ce35260f93303625d9
      0d93961d
  5. Jan 17, 2022
  6. Jan 12, 2022
    • Ming-Shin Lu's avatar
      Using IME context to inflate layout from S_V2 · 6c752d8e
      Ming-Shin Lu authored
      With CL[1],[2] to migrate InputMethodService as the subclass of the new
      introduced class WindowProviderService in S_V2, IME context resources
      can be managed by associating the window container of IME window when
      its display/window configuration changed.
      
      So we can get rid of createDisplayContext logic from S_V2 with gated
      by SDK version and refining the method of get IME context with
      documentation to make it clear.
      
      [1]: Ie565e30ed5dd3f2cfe27355a6dded76dc3adc14b
      [2]: I64a1614f32d097785915f6105b1813a929e0fe32
      
      Bug: 213118079
      Bug: 133825283
      Test: manual with below steps
       1) adb install -r EditTextVariations.apk
       2) tapas LatinIME
       3) make
       4) adb install -r out/target/product/generic/system/app/LatinIME/\
              LatinIME.apk
       5) adb shell ime enable com.android.inputmethod.latin/.LatinIME
       6) adb shell ime set com.android.inputmethod.latin/.LatinIME
       5) Enable screen auto-rotation
       7) Launch EditTextVariations from launcher's shortcut
       8) Tap the first EditText field to show IME
       9) Rotate the device to the landscape mode
       10) Expect the IME should not be shrunk
      
      Change-Id: If2cc1c5bdb257a9c0af653fa7157cf781a90bf1d
      6c752d8e
  7. Jun 18, 2021
    • Ming-Shin Lu's avatar
      Fix Keyboard Theme update when device orientation changed · 6ae09365
      Ming-Shin Lu authored
      As CL[1] introduces diplayContext to address
      IME service context's Resources / DisplayMetrics update when
      switching IME window to another display after onConfigurationChange.
      
      In LatinIME#onInitializeInterface, we only update keyboard theme context
      and displayContent when the displayId is changed, but overlooked even
      the displayId is the same, the display context's resource configuration
      might changed like the device orientation changd.
      
      It leads getDefaultKeyboardHeight will get wrong config_max_keyboard_height
      fraction value when rotating to landcape because the context resources
      didn't get updated.
      
      Add a check to update keyboard theme context when the current display
      configuation is changed accordingly.
      
      [1]: I0ed6a079af1ed90c75fee1d36d5ce3ef3c41f8ed
      
      Fix: 186507147
      Test: manual as issue steps
          1) Turn on auto-rotate
          2) Open Settings
          3) Rotating the device to landscape mode
          4) Tap “Search settings", verify if the soft-keyboard shown and the
             size is expected.
      Change-Id: I288a31baf04fa2e63d6b4a14ad81b401cb36ece5
      Merged-In: I288a31baf04fa2e63d6b4a14ad81b401cb36ece5
      6ae09365
  8. Jun 15, 2021
    • Yohei Yukawa's avatar
      Bump targetSdkVersion to "30" · 07ce283a
      Yohei Yukawa authored
      With this CL, versionCode, targetSdkVersion and minSdkVersion will be
      bumped/set as follows:
      
             versionCode: 28 -> 30
        targetSdkVersion: 28 -> 30
           minSdkVersion: 21
      
      As far as we know, there should be no user-visible behavior change on
      supported OS versions.
      
      Fix: 189558760
      Test: manually verified that LatinIME still is functional
      Change-Id: I3a7deb452960b370f5290f3d1bac9c79fe935303
      Merged-In: I4bf7588c62fb77bf78d4afcb665e9bfbbef53966
      (cherry picked from commit 360052f3)
      07ce283a
    • Yohei Yukawa's avatar
      Bump targetSdkVersion to "30" · 360052f3
      Yohei Yukawa authored
      With this CL, versionCode, targetSdkVersion and minSdkVersion will be
      bumped/set as follows:
      
             versionCode: 28 -> 30
        targetSdkVersion: 28 -> 30
           minSdkVersion: 21
      
      As far as we know, there should be no user-visible behavior change on
      supported OS versions.
      
      Fix: 189558760
      Test: manually verified that LatinIME still is functional
      Change-Id: I4bf7588c62fb77bf78d4afcb665e9bfbbef53966
      360052f3
  9. May 28, 2021
    • Ming-Shin Lu's avatar
      Fix Keyboard Theme update when device orientation changed · 407f8a32
      Ming-Shin Lu authored
      As CL[1] introduces diplayContext to address
      IME service context's Resources / DisplayMetrics update when
      switching IME window to another display after onConfigurationChange.
      
      In LatinIME#onInitializeInterface, we only update keyboard theme context
      and displayContent when the displayId is changed, but overlooked even
      the displayId is the same, the display context's resource configuration
      might changed like the device orientation changd.
      
      It leads getDefaultKeyboardHeight will get wrong config_max_keyboard_height
      fraction value when rotating to landcape because the context resources
      didn't get updated.
      
      Add a check to update keyboard theme context when the current display
      configuation is changed accordingly.
      
      [1]: I0ed6a079af1ed90c75fee1d36d5ce3ef3c41f8ed
      
      Fix: 186507147
      Test: manual as issue steps
          1) Turn on auto-rotate
          2) Open Settings
          3) Rotating the device to landscape mode
          4) Tap “Search settings", verify if the soft-keyboard shown and the
             size is expected.
      Change-Id: I288a31baf04fa2e63d6b4a14ad81b401cb36ece5
      407f8a32
  10. Apr 13, 2021
    • Pedro Loureiro's avatar
      Add lint baseline to address NewApi errors · 57d4aef2
      Pedro Loureiro authored
      We are enabling a new lint check where the min sdk != compile sdk.
      It has produced a lot of errors and adding the baseline file(s)
      allows us to continue work without introducing more problems.
      
      Bug: 150847901
      
      Test: m lint-check
      Change-Id: Ic37bd8c531af7e68c939ce9c05614c37e6699b03
      Merged-In: Ic37bd8c531af7e68c939ce9c05614c37e6699b03
      57d4aef2
  11. Apr 12, 2021
    • Pedro Loureiro's avatar
      Add lint baseline to address NewApi errors · b47de75a
      Pedro Loureiro authored
      We are enabling a new lint check where the min sdk != compile sdk.
      It has produced a lot of errors and adding the baseline file(s)
      allows us to continue work without introducing more problems.
      
      Bug: 150847901
      
      Test: m lint-check
      Change-Id: Ic37bd8c531af7e68c939ce9c05614c37e6699b03
      b47de75a
  12. Feb 17, 2021
    • Bob Badour's avatar
      [LSC] Add LOCAL_LICENSE_KINDS to packages/inputmethods/LatinIME · f3d9532a
      Bob Badour authored
      Added SPDX-license-identifier-Apache-2.0 to:
        Android.bp
        common/Android.bp
        java/Android.bp
        native/dicttoolkit/Android.bp
        native/jni/Android.bp
        tests/Android.bp
        tools/EditTextVariations/Android.bp
        tools/dicttool/Android.bp
        tools/make-keyboard-text/Android.bp
      
      Bug: 68860345
      Bug: 151177513
      Bug: 151953481
      
      Test: m all
      
      Exempt-From-Owner-Approval: janitorial work
      Change-Id: I440008bffac5c97a2497970af377a9d03262b6d8
      f3d9532a
  13. Aug 12, 2020
  14. Jul 31, 2020
  15. Jul 22, 2020
  16. Mar 23, 2020
    • Ashwini Oruganti's avatar
      Add an exported flag in manifest · 7c1b5497
      Ashwini Oruganti authored
      With b/150232615, we will need an explicit value set for the exported
      flag when intent filters are present, as the default behavior is
      changing for S+. This change adds the value reflecting the previous
      default to the manifest.
      
      These changes were made using an automated tool, the xml file may be
      reformatted slightly creating a larger diff. The only "real" change is
      the addition of "android:exported" to activities, services, and
      receivers that have one or more intent-filters.
      
      Bug: 150232615
      Test: TH
      Exempt-From-Owner-Approval: mechanical refactoring
      Change-Id: Idc43e262fd2911e19f0bcd20add29e4c3392d3da
      7c1b5497
  17. Nov 10, 2019
  18. Nov 09, 2019
  19. Oct 31, 2019
  20. Oct 27, 2019
  21. Oct 19, 2019
  22. Oct 13, 2019
    • Alex Henrie's avatar
      Support polytonic Greek diacritics in the Greek keyboard · 0cf43768
      Alex Henrie authored
      Although modern Greek is typically written with only acute accent marks,
      polytonic diacritics are still used by the Greek orthodox church, the
      Greek newspaper Estia, and students of classical Greek texts. Supporting
      these special characters is helpful to all of those groups.
      
      Note that for the short vowels (epsilon, upsilon, iota, and omicron) all
      of the diacritics permitted on lowercase letters are also permitted on
      their uppercase forms. However, for the long vowels (alpha, eta, and
      omega) the diacritics permitted on uppercase letters are a subset of the
      diacritics permitted on lowercase letters. That's just how Greek is.
      
      Test: Manually turned on the Greek (Greece) keyboard in the aosp_x86-eng
      emulator and tried out all the new characters with Shift, with Shift
      Lock, and without any modifiers.
      
      Bug: 142007431
      Change-Id: Iec4a82cab02aea5176721e8447f7dfdba46bacb3
      0cf43768
  23. Oct 12, 2019
Loading