- Jul 06, 2023
-
-
abb128 authored
-
- Oct 17, 2022
-
-
Cole Faust authored
This commit is part of a large scale change to fix errorprone errors that have been downgraded to warnings in the android source tree, so that they can be promoted to errors again. The full list of changes include the following, but not all will be present in any one individual commit: BadAnnotationImplementation BadShiftAmount BanJNDI BoxedPrimitiveEquality ComparableType ComplexBooleanConstant CollectionToArraySafeParameter ConditionalExpressionNumericPromotion DangerousLiteralNull DoubleBraceInitialization DurationFrom DurationTemporalUnit EmptyTopLevelDeclaration EqualsNull EqualsReference FormatString FromTemporalAccessor GetClassOnAnnotation GetClassOnClass HashtableContains IdentityBinaryExpression IdentityHashMapBoxing InstantTemporalUnit InvalidTimeZoneID InvalidZoneId IsInstanceIncompatibleType JUnitParameterMethodNotFound LockOnBoxedPrimitive MathRoundIntLong MislabeledAndroidString MisusedDayOfYear MissingSuperCall MisusedWeekYear ModifyingCollectionWithItself NoCanIgnoreReturnValueOnClasses NonRuntimeAnnotation NullableOnContainingClass NullTernary OverridesJavaxInjectableMethod ParcelableCreator PeriodFrom PreconditionsInvalidPlaceholder ProtoBuilderReturnValueIgnored ProtoFieldNullComparison RandomModInteger RectIntersectReturnValueIgnored ReturnValueIgnored SelfAssignment SelfComparison SelfEquals SizeGreaterThanOrEqualsZero StringBuilderInitWithChar TreeToString TryFailThrowable UnnecessaryCheckNotNull UnusedCollectionModifiedInPlace XorPower See https://errorprone.info/bugpatterns for more information on the checks. Bug: 253827323 Test: m RUN_ERROR_PRONE=true javac-check Change-Id: I454a105ae82484a2d19aff1808e8d9dd55ba64f4
-
- Aug 16, 2022
-
-
Cole Faust authored
The ArrayEquals, ArrayHashCode, ArrayToString, and ArraysAsListPrimitiveArray errorprone findings were demoted from errors to warnings. Fix existing occurrences of them so they can be made errors again. Bug: 242630963 Test: RUN_ERROR_PRONE=true m javac-check Change-Id: I689397a7196277de3fd301836e72f7555e2036cb
-
- Feb 23, 2022
-
-
Wilson Wu authored
Remove the showDictionaryAvailableNotification method since there is no module use it. Bug: 209479751 Test: presubmit Change-Id: I4c88b4a2d0cb36761d9102ce35260f93303625d9
-
- Jan 17, 2022
-
-
Lais Andrade authored
The keyboard key-press haptic feedback should follow the user settings for "Touch feedback". Bug: 185351540 Test: manual Change-Id: I718d3bf15b1ef841a869a898038d0eca1eca78f0
-
- Jan 12, 2022
-
-
Ming-Shin Lu authored
With CL[1],[2] to migrate InputMethodService as the subclass of the new introduced class WindowProviderService in S_V2, IME context resources can be managed by associating the window container of IME window when its display/window configuration changed. So we can get rid of createDisplayContext logic from S_V2 with gated by SDK version and refining the method of get IME context with documentation to make it clear. [1]: Ie565e30ed5dd3f2cfe27355a6dded76dc3adc14b [2]: I64a1614f32d097785915f6105b1813a929e0fe32 Bug: 213118079 Bug: 133825283 Test: manual with below steps 1) adb install -r EditTextVariations.apk 2) tapas LatinIME 3) make 4) adb install -r out/target/product/generic/system/app/LatinIME/\ LatinIME.apk 5) adb shell ime enable com.android.inputmethod.latin/.LatinIME 6) adb shell ime set com.android.inputmethod.latin/.LatinIME 5) Enable screen auto-rotation 7) Launch EditTextVariations from launcher's shortcut 8) Tap the first EditText field to show IME 9) Rotate the device to the landscape mode 10) Expect the IME should not be shrunk Change-Id: If2cc1c5bdb257a9c0af653fa7157cf781a90bf1d
-
- Jun 18, 2021
-
-
Ming-Shin Lu authored
As CL[1] introduces diplayContext to address IME service context's Resources / DisplayMetrics update when switching IME window to another display after onConfigurationChange. In LatinIME#onInitializeInterface, we only update keyboard theme context and displayContent when the displayId is changed, but overlooked even the displayId is the same, the display context's resource configuration might changed like the device orientation changd. It leads getDefaultKeyboardHeight will get wrong config_max_keyboard_height fraction value when rotating to landcape because the context resources didn't get updated. Add a check to update keyboard theme context when the current display configuation is changed accordingly. [1]: I0ed6a079af1ed90c75fee1d36d5ce3ef3c41f8ed Fix: 186507147 Test: manual as issue steps 1) Turn on auto-rotate 2) Open Settings 3) Rotating the device to landscape mode 4) Tap “Search settings", verify if the soft-keyboard shown and the size is expected. Change-Id: I288a31baf04fa2e63d6b4a14ad81b401cb36ece5 Merged-In: I288a31baf04fa2e63d6b4a14ad81b401cb36ece5
-
- Jun 15, 2021
-
-
Yohei Yukawa authored
With this CL, versionCode, targetSdkVersion and minSdkVersion will be bumped/set as follows: versionCode: 28 -> 30 targetSdkVersion: 28 -> 30 minSdkVersion: 21 As far as we know, there should be no user-visible behavior change on supported OS versions. Fix: 189558760 Test: manually verified that LatinIME still is functional Change-Id: I3a7deb452960b370f5290f3d1bac9c79fe935303 Merged-In: I4bf7588c62fb77bf78d4afcb665e9bfbbef53966 (cherry picked from commit 360052f3)
-
Yohei Yukawa authored
With this CL, versionCode, targetSdkVersion and minSdkVersion will be bumped/set as follows: versionCode: 28 -> 30 targetSdkVersion: 28 -> 30 minSdkVersion: 21 As far as we know, there should be no user-visible behavior change on supported OS versions. Fix: 189558760 Test: manually verified that LatinIME still is functional Change-Id: I4bf7588c62fb77bf78d4afcb665e9bfbbef53966
-
- May 28, 2021
-
-
Ming-Shin Lu authored
As CL[1] introduces diplayContext to address IME service context's Resources / DisplayMetrics update when switching IME window to another display after onConfigurationChange. In LatinIME#onInitializeInterface, we only update keyboard theme context and displayContent when the displayId is changed, but overlooked even the displayId is the same, the display context's resource configuration might changed like the device orientation changd. It leads getDefaultKeyboardHeight will get wrong config_max_keyboard_height fraction value when rotating to landcape because the context resources didn't get updated. Add a check to update keyboard theme context when the current display configuation is changed accordingly. [1]: I0ed6a079af1ed90c75fee1d36d5ce3ef3c41f8ed Fix: 186507147 Test: manual as issue steps 1) Turn on auto-rotate 2) Open Settings 3) Rotating the device to landscape mode 4) Tap “Search settings", verify if the soft-keyboard shown and the size is expected. Change-Id: I288a31baf04fa2e63d6b4a14ad81b401cb36ece5
-
- Apr 13, 2021
-
-
Pedro Loureiro authored
We are enabling a new lint check where the min sdk != compile sdk. It has produced a lot of errors and adding the baseline file(s) allows us to continue work without introducing more problems. Bug: 150847901 Test: m lint-check Change-Id: Ic37bd8c531af7e68c939ce9c05614c37e6699b03 Merged-In: Ic37bd8c531af7e68c939ce9c05614c37e6699b03
-
- Apr 12, 2021
-
-
Pedro Loureiro authored
We are enabling a new lint check where the min sdk != compile sdk. It has produced a lot of errors and adding the baseline file(s) allows us to continue work without introducing more problems. Bug: 150847901 Test: m lint-check Change-Id: Ic37bd8c531af7e68c939ce9c05614c37e6699b03
-
- Feb 17, 2021
-
-
Bob Badour authored
Added SPDX-license-identifier-Apache-2.0 to: Android.bp common/Android.bp java/Android.bp native/dicttoolkit/Android.bp native/jni/Android.bp tests/Android.bp tools/EditTextVariations/Android.bp tools/dicttool/Android.bp tools/make-keyboard-text/Android.bp Bug: 68860345 Bug: 151177513 Bug: 151953481 Test: m all Exempt-From-Owner-Approval: janitorial work Change-Id: I440008bffac5c97a2497970af377a9d03262b6d8
-
- Aug 12, 2020
-
-
Adrian Roos authored
See https://source.android.com/setup/contribute/respectful-code for reference Bug: 162536543 Change-Id: I5df9e60ec6caa2e1e3253532c2b59b74adfc1749
-
- Jul 31, 2020
-
-
Jeff Sharkey authored
See https://source.android.com/setup/contribute/respectful-code for reference Bug: 161896447 Change-Id: I171bc299e660f96f20041a67a3052bd8a2ed781c
-
- Jul 22, 2020
-
-
Seigo Nonaka authored
See https://source.android.com/setup/contribute/respectful-code for reference Bug: 161896447 Test: tapas LatinIME && m Change-Id: I2ffb39ff70f61e579b62761d3da526a545dead1f
-
- Mar 23, 2020
-
-
Ashwini Oruganti authored
With b/150232615, we will need an explicit value set for the exported flag when intent filters are present, as the default behavior is changing for S+. This change adds the value reflecting the previous default to the manifest. These changes were made using an automated tool, the xml file may be reformatted slightly creating a larger diff. The only "real" change is the addition of "android:exported" to activities, services, and receivers that have one or more intent-filters. Bug: 150232615 Test: TH Exempt-From-Owner-Approval: mechanical refactoring Change-Id: Idc43e262fd2911e19f0bcd20add29e4c3392d3da
-
- Nov 10, 2019
-
-
Bill Yi authored
Change-Id: I2688babc5d396ae65481a97b186e52c7c3dafbc9 Auto-generated-cl: translation import
-
Bill Yi authored
Change-Id: I237d2997fb1314302be85530c6b6bc710426b36b Auto-generated-cl: translation import
-
Bill Yi authored
Change-Id: Iee2e651ebfd028b235b428939964b1b532427e78 Auto-generated-cl: translation import
-
Bill Yi authored
Change-Id: I5f46ed0024412fbf2b1e5d549ac4f5747ba10ead Auto-generated-cl: translation import
-
- Nov 09, 2019
-
-
Bill Yi authored
Change-Id: I81bb93f802d6207d6a635ef20d3cf14b8fe63736 Auto-generated-cl: translation import
-
Bill Yi authored
Change-Id: I5b95f6ad5e3e70baa6ac48af90d371436cbdc4db Auto-generated-cl: translation import
-
Bill Yi authored
Change-Id: I05c0b930c3ad4874427948f3c7edced4c8d0a838 Auto-generated-cl: translation import
-
Bill Yi authored
Change-Id: Ie07900be31c3c8d19e858a8abbb1193bc431da0f Auto-generated-cl: translation import
-
- Oct 31, 2019
-
-
Bill Yi authored
Change-Id: I096635ffb38bb645e04c4ed143cece7ce68b6ddc Auto-generated-cl: translation import
-
- Oct 27, 2019
-
-
Bill Yi authored
Change-Id: Ia7e18aa418d665e934f39dfbebb4696a10fd129a Auto-generated-cl: translation import
-
- Oct 19, 2019
-
-
Bill Yi authored
Change-Id: I82449a197920db5447cdf46cc3f7f4f2549d949d Auto-generated-cl: translation import
-
- Oct 13, 2019
-
-
Alex Henrie authored
Although modern Greek is typically written with only acute accent marks, polytonic diacritics are still used by the Greek orthodox church, the Greek newspaper Estia, and students of classical Greek texts. Supporting these special characters is helpful to all of those groups. Note that for the short vowels (epsilon, upsilon, iota, and omicron) all of the diacritics permitted on lowercase letters are also permitted on their uppercase forms. However, for the long vowels (alpha, eta, and omega) the diacritics permitted on uppercase letters are a subset of the diacritics permitted on lowercase letters. That's just how Greek is. Test: Manually turned on the Greek (Greece) keyboard in the aosp_x86-eng emulator and tried out all the new characters with Shift, with Shift Lock, and without any modifiers. Bug: 142007431 Change-Id: Iec4a82cab02aea5176721e8447f7dfdba46bacb3
-
- Oct 12, 2019
-
-
Bill Yi authored
Change-Id: Ic205e05525cdc7d270221307fe412de6034f113c Auto-generated-cl: translation import
-
Bill Yi authored
Change-Id: Ib628adda1816a2f5a326b5af8d62b62eb5ca220b Auto-generated-cl: translation import
-
Bill Yi authored
Change-Id: Ie021836a7928ad9781e17c50b3686f8c3849f74d Auto-generated-cl: translation import
-
Bill Yi authored
Change-Id: Ic64f5bdff1583cc41c1ce0d34195503671708c9b Auto-generated-cl: translation import
-
Bill Yi authored
Change-Id: I0e355f93e60c93c90ddaa09066c498e40359be2d Auto-generated-cl: translation import
-
Bill Yi authored
Change-Id: Ic2f680a72dc473a3ea9e63ba2781519c0bb0d189 Auto-generated-cl: translation import
-
Bill Yi authored
Change-Id: I4da730ecd128512ddd2abaf5ece66c70d781f186 Auto-generated-cl: translation import
-
Bill Yi authored
Change-Id: I1658ecf392971a2a9ddc388b5cf3bcc741e524b3 Auto-generated-cl: translation import
-
Bill Yi authored
Change-Id: Iba616f0749d1c51716c4626d409183459f47aa27 Auto-generated-cl: translation import
-
Bill Yi authored
Change-Id: I52324e9458f9b928e2827ea70097b0eb93054467 Auto-generated-cl: translation import
-
Bill Yi authored
Change-Id: I7c4d06039b54997e53849f3bb0d895b6cdf590e9 Auto-generated-cl: translation import
-