Original change: https://android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/2445925



Change-Id: I2bae39a9a7e659300a47203f1b4c99a94c386513
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>

Original change: https://android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/2445925



Change-Id: I996fc354112500e41977b93521e9050bdccce81b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>

Since some variables with module LatinIME are defined but not used,
when compiled with build combination "sdk_pc_x86_64-userdebug" and
build command "mmm packages/inputmethods/LatinIME", the following
code lines will be reported that "variable 'XXX' set but not used".
(should be similar for all the other build combinations)

Repeated 10 times for each:
terminal_position_lookup_table.cpp:74:9 removedEntryCount
terminal_position_lookup_table.cpp:85:9 removedEntryCount
proximity_info_state_utils.cpp:493:9 tempTime
trie_map.cpp:56:9 unusedRegionSize
suggestion_results.cpp:100:9 index

Repeated 80+ times:
proximity_info_utils.h:75:25 proximityChar

With this patch we are removing some of the unused variables and
putting the C++ 17 attribute [[maybe_unused]] to the others which
are used for logging. Then all the related build warnings have been
eliminated.

Test: mmm packages/inputmethods/LatinIME, presubmit check.

Change-Id: Ia66766322d6ae8a010b1cb55cc22993fbc6d012c
Signed-off-by: Jing Mike <jingyangliu@eswincomputing.com>

Original change: https://android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/2256807



Change-Id: Ie8d7a908adb83e2556d7b2d27beecc0e29978173
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>

Original change: https://android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/2256807



Change-Id: I7d8662bdc880e331cf2d912dae7cc18b70743975
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>

This commit is part of a large scale change to fix errorprone
errors that have been downgraded to warnings in the android
source tree, so that they can be promoted to errors again.
The full list of changes include the following, but not all
will be present in any one individual commit:

BadAnnotationImplementation
BadShiftAmount
BanJNDI
BoxedPrimitiveEquality
ComparableType
ComplexBooleanConstant
CollectionToArraySafeParameter
ConditionalExpressionNumericPromotion
DangerousLiteralNull
DoubleBraceInitialization
DurationFrom
DurationTemporalUnit
EmptyTopLevelDeclaration
EqualsNull
EqualsReference
FormatString
FromTemporalAccessor
GetClassOnAnnotation
GetClassOnClass
HashtableContains
IdentityBinaryExpression
IdentityHashMapBoxing
InstantTemporalUnit
InvalidTimeZoneID
InvalidZoneId
IsInstanceIncompatibleType
JUnitParameterMethodNotFound
LockOnBoxedPrimitive
MathRoundIntLong
MislabeledAndroidString
MisusedDayOfYear
MissingSuperCall
MisusedWeekYear
ModifyingCollectionWithItself
NoCanIgnoreReturnValueOnClasses
NonRuntimeAnnotation
NullableOnContainingClass
NullTernary
OverridesJavaxInjectableMethod
ParcelableCreator
PeriodFrom
PreconditionsInvalidPlaceholder
ProtoBuilderReturnValueIgnored
ProtoFieldNullComparison
RandomModInteger
RectIntersectReturnValueIgnored
ReturnValueIgnored
SelfAssignment
SelfComparison
SelfEquals
SizeGreaterThanOrEqualsZero
StringBuilderInitWithChar
TreeToString
TryFailThrowable
UnnecessaryCheckNotNull
UnusedCollectionModifiedInPlace
XorPower

See https://errorprone.info/bugpatterns for more
information on the checks.

Bug: 253827323
Test: m RUN_ERROR_PRONE=true javac-check
Change-Id: I454a105ae82484a2d19aff1808e8d9dd55ba64f4

Merge "Fix array-related errorprone warnings" am: 370d41de am: 3a06d618 am: e546038c am: 51466cff

Original change: https://android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/2186538



Change-Id: Ib3878ed212ae13dddd9761aefda2960cb7defbb4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>

Original change: https://android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/2186538



Change-Id: I609ca003a48f3eb2a323ed456fc54d5754bd694f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>

Original change: https://android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/2186538



Change-Id: Ic25b4e765f6612409aa840c7e4dc392d99fb254a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>

Original change: https://android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/2186538



Change-Id: I8c9cc9d63affa572ca6bf79ff156f69f7ee96db1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>

[automerger skipped] Merge "DO NOT MERGE - Merge Android 13" am: 7005e0c1 -s ours am: b34de510 -s ours am: a8004dc4 -s ours

am skip reason: Merged-In Ib4b72e0a277d8b2fb78837bed5d2e9cccd819a07 with SHA-1 f134ea38 is already in history

Original change: https://android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/2186832



Change-Id: Ifc14b063977916d54bec38aa1d4f7f09bbe9d401
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>

[automerger skipped] DO NOT MERGE - Merge Android 13 am: 2012c03a -s ours am: 9238ba58 -s ours am: c1790946 -s ours

am skip reason: Merged-In Ib4b72e0a277d8b2fb78837bed5d2e9cccd819a07 with SHA-1 f134ea38 is already in history

Original change: https://android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/2186832



Change-Id: I35d476cbc57a934f0ba08a3ef203a1ec42ad7cd5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>

[automerger skipped] Merge "DO NOT MERGE - Merge Android 13" am: 7005e0c1 -s ours am: b34de510 -s ours

am skip reason: Merged-In Ib4b72e0a277d8b2fb78837bed5d2e9cccd819a07 with SHA-1 f134ea38 is already in history

Original change: https://android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/2186832



Change-Id: I0aa5940a87d0a9cf5eb40d8d3841f0d0e6a7c310
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>

am skip reason: Merged-In Ib4b72e0a277d8b2fb78837bed5d2e9cccd819a07 with SHA-1 f134ea38 is already in history

Original change: https://android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/2186832



Change-Id: I210262f2fe9ad726ae1c4c9a832ec6db5fd76a80
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>

am skip reason: Merged-In Ib4b72e0a277d8b2fb78837bed5d2e9cccd819a07 with SHA-1 f134ea38 is already in history

Original change: https://android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/2186832



Change-Id: I2c79acfa20a9200db266fd982b142905ec8cf0b0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>

am skip reason: Merged-In Ib4b72e0a277d8b2fb78837bed5d2e9cccd819a07 with SHA-1 f134ea38 is already in history

Original change: https://android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/2186832



Change-Id: Ifa4bae36305d050c1a6b5a569ad471f85a9d51d5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>

Bug: 242648940
Merged-In: Ib4b72e0a277d8b2fb78837bed5d2e9cccd819a07
Change-Id: Id6eef7910c3955e9dd6c49749406520d86e73dad

The ArrayEquals, ArrayHashCode, ArrayToString, and
ArraysAsListPrimitiveArray errorprone findings were
demoted from errors to warnings. Fix existing
occurrences of them so they can be made errors again.

Bug: 242630963
Test: RUN_ERROR_PRONE=true m javac-check
Change-Id: I689397a7196277de3fd301836e72f7555e2036cb

[automerger skipped] Merge tm-dev-plus-aosp-without-vendor@8763363 am: 0f20a651 -s ours am: 612860d4 -s ours am: 3b9989cf -s ours

am skip reason: Merged-In Ib4b72e0a277d8b2fb78837bed5d2e9cccd819a07 with SHA-1 f134ea38 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/19094630



Change-Id: Ic73fb15f7f2918bd2a5bb5f318abad607240209b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>

[automerger skipped] Merge tm-dev-plus-aosp-without-vendor@8763363 am: 0f20a651 -s ours am: 612860d4 -s ours

am skip reason: Merged-In Ib4b72e0a277d8b2fb78837bed5d2e9cccd819a07 with SHA-1 f134ea38 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/19094630



Change-Id: I8e3947377fc021574b7d21f76873f4c119e355ce
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>

am skip reason: Merged-In Ib4b72e0a277d8b2fb78837bed5d2e9cccd819a07 with SHA-1 f134ea38 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/19094630



Change-Id: I096e09860be31172ba86e1770c15b59013b8af2d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>

Bug: 236760014
Merged-In: Ib4b72e0a277d8b2fb78837bed5d2e9cccd819a07
Change-Id: I9d0e133b64c2d6afb795eb049c58bc2ff5ab79b5

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/17759925



Change-Id: I82dd9d78d3e802f7c65113d2a126ab82d3de9663
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/17759925



Change-Id: I42513112e3cdc14629874ab2cd424b62d37a694d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>

Bug: 228766370
Test: manual by using EditorTextVariations tool
     1) make and install EditTextVariations
     2) Enable "Settings > Display over other apps" for
        EditTextVariations
     3) Launch EditTextVariations from all apps
     4) Menu -> Show IME focuable overlay
     5) Go to home screen by gesture or pressing home key
     6) Launch any app (e.g. Chrome) and tap the editor
     7) Expect IME can show up

Change-Id: Ib4b72e0a277d8b2fb78837bed5d2e9cccd819a07

[automerger skipped] Merge "Merge Android 12L" am: 85ef644a -s ours am: c932faf4 -s ours am: a9786e84 -s ours

am skip reason: Merged-In Iea002572895dfdb74f72b5d6fe7a1efbd4139cac with SHA-1 6454ff57 is already in history

Original change: https://android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/2013416

Change-Id: I80f31beb6bc22130874b31d172b2fd60cc4a5d5b

[automerger skipped] Merge Android 12L am: 81057889 -s ours am: d4cc9ab2 -s ours am: 39f406f8 -s ours

am skip reason: Merged-In Iea002572895dfdb74f72b5d6fe7a1efbd4139cac with SHA-1 6454ff57 is already in history

Original change: https://android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/2013416

Change-Id: I043e801e312f24aa88bc0d318b5a3f7989e51409

am skip reason: Merged-In Iea002572895dfdb74f72b5d6fe7a1efbd4139cac with SHA-1 6454ff57 is already in history

Original change: https://android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/2013416

Change-Id: I44c6f56f70b925b34509b1b82c969edf7ad8f139

am skip reason: Merged-In Iea002572895dfdb74f72b5d6fe7a1efbd4139cac with SHA-1 6454ff57 is already in history

Original change: https://android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/2013416

Change-Id: I1655b2e046170ac38d2e87f5b98226340d1da90e

am skip reason: Merged-In Iea002572895dfdb74f72b5d6fe7a1efbd4139cac with SHA-1 6454ff57 is already in history

Original change: https://android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/2013416

Change-Id: I9a987e3c8ba883d4471b9adc60181e659e6b2665

am skip reason: Merged-In Iea002572895dfdb74f72b5d6fe7a1efbd4139cac with SHA-1 6454ff57 is already in history

Original change: https://android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/2013416

Change-Id: Ic5c820036065498cfbeaea02232a21831616e3c5

Bug: 222710654
Merged-In: Iea002572895dfdb74f72b5d6fe7a1efbd4139cac
Change-Id: I4460e29cf09d440add5649faea52954c241bc524

Remove the showDictionaryAvailableNotification
method since there is no module use it.

Bug: 209479751
Test: presubmit
Change-Id: I4c88b4a2d0cb36761d9102ce35260f93303625d9

[automerger skipped] Merge sc-v2-dev-plus-aosp-without-vendor@8084891 am: 6454ff57 -s ours am: c04a7cc9 -s ours

am skip reason: Merged-In If2cc1c5bdb257a9c0af653fa7157cf781a90bf1d with SHA-1 6c752d8e is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/16845178

Change-Id: Ia2961743696694ae9fd4b467b119a2caa3ecce46