Skip to content
Snippets Groups Projects
  1. Jul 06, 2023
  2. Mar 20, 2023
  3. Mar 19, 2023
    • Jing Mike's avatar
      Remove unused variables · 03eef94a
      Jing Mike authored
      
      Since some variables with module LatinIME are defined but not used,
      when compiled with build combination "sdk_pc_x86_64-userdebug" and
      build command "mmm packages/inputmethods/LatinIME", the following
      code lines will be reported that "variable 'XXX' set but not used".
      (should be similar for all the other build combinations)
      
      Repeated 10 times for each:
      terminal_position_lookup_table.cpp:74:9 removedEntryCount
      terminal_position_lookup_table.cpp:85:9 removedEntryCount
      proximity_info_state_utils.cpp:493:9 tempTime
      trie_map.cpp:56:9 unusedRegionSize
      suggestion_results.cpp:100:9 index
      
      Repeated 80+ times:
      proximity_info_utils.h:75:25 proximityChar
      
      With this patch we are removing some of the unused variables and
      putting the C++ 17 attribute [[maybe_unused]] to the others which
      are used for logging. Then all the related build warnings have been
      eliminated.
      
      Test: mmm packages/inputmethods/LatinIME, presubmit check.
      
      Change-Id: Ia66766322d6ae8a010b1cb55cc22993fbc6d012c
      Signed-off-by: default avatarJing Mike <jingyangliu@eswincomputing.com>
      03eef94a
  4. Oct 17, 2022
  5. Aug 24, 2022
  6. Aug 17, 2022
  7. Aug 16, 2022
  8. Jun 30, 2022
  9. Jun 29, 2022
  10. Jun 27, 2022
  11. Apr 21, 2022
  12. Mar 09, 2022
  13. Mar 08, 2022
  14. Feb 23, 2022
    • Wilson Wu's avatar
      Remove unused method for dictionarypack · 0d93961d
      Wilson Wu authored
      Remove the showDictionaryAvailableNotification
      method since there is no module use it.
      
      Bug: 209479751
      Test: presubmit
      Change-Id: I4c88b4a2d0cb36761d9102ce35260f93303625d9
      0d93961d
  15. Feb 14, 2022
Loading