Skip to content

Refactor Server Configuration

Harpo requested to merge hr/refactor-server-setup into master

This updates the existing server configuration components to always derive server state from the server list query. This fixes several edge cases related to the server list being updated while the user is currently editing. Another bug is fixed where it is impossible to close the new server box on cancellation. As part of this the configuration for ServerListTable row has switched to a tagged union for the two distinct cases, no longer using implicit empty string values. Additionally when a server mutation has submitted the component then enters a disabled state that disallows further action while the asynchronous actions are manipulating state. One negative of these bug fixes is that things now jump around a bit on submit. I think perhaps the server list should be ordered backwards to prevent that, or maybe the edit box placed on the top.

Edited by Harpo

Merge request reports