- Aug 15, 2023
-
-
abb128 authored
-
- Aug 14, 2023
-
-
Aleksandras Kostarevas authored
-
Aleksandras Kostarevas authored
Remove ICS and Holo themes. Remove most png keyboard resources, replacing with xml shapes and colors
-
- Jul 06, 2023
-
-
abb128 authored
-
- Oct 17, 2022
-
-
Cole Faust authored
This commit is part of a large scale change to fix errorprone errors that have been downgraded to warnings in the android source tree, so that they can be promoted to errors again. The full list of changes include the following, but not all will be present in any one individual commit: BadAnnotationImplementation BadShiftAmount BanJNDI BoxedPrimitiveEquality ComparableType ComplexBooleanConstant CollectionToArraySafeParameter ConditionalExpressionNumericPromotion DangerousLiteralNull DoubleBraceInitialization DurationFrom DurationTemporalUnit EmptyTopLevelDeclaration EqualsNull EqualsReference FormatString FromTemporalAccessor GetClassOnAnnotation GetClassOnClass HashtableContains IdentityBinaryExpression IdentityHashMapBoxing InstantTemporalUnit InvalidTimeZoneID InvalidZoneId IsInstanceIncompatibleType JUnitParameterMethodNotFound LockOnBoxedPrimitive MathRoundIntLong MislabeledAndroidString MisusedDayOfYear MissingSuperCall MisusedWeekYear ModifyingCollectionWithItself NoCanIgnoreReturnValueOnClasses NonRuntimeAnnotation NullableOnContainingClass NullTernary OverridesJavaxInjectableMethod ParcelableCreator PeriodFrom PreconditionsInvalidPlaceholder ProtoBuilderReturnValueIgnored ProtoFieldNullComparison RandomModInteger RectIntersectReturnValueIgnored ReturnValueIgnored SelfAssignment SelfComparison SelfEquals SizeGreaterThanOrEqualsZero StringBuilderInitWithChar TreeToString TryFailThrowable UnnecessaryCheckNotNull UnusedCollectionModifiedInPlace XorPower See https://errorprone.info/bugpatterns for more information on the checks. Bug: 253827323 Test: m RUN_ERROR_PRONE=true javac-check Change-Id: I454a105ae82484a2d19aff1808e8d9dd55ba64f4
-
- Jun 15, 2021
-
-
Yohei Yukawa authored
With this CL, versionCode, targetSdkVersion and minSdkVersion will be bumped/set as follows: versionCode: 28 -> 30 targetSdkVersion: 28 -> 30 minSdkVersion: 21 As far as we know, there should be no user-visible behavior change on supported OS versions. Fix: 189558760 Test: manually verified that LatinIME still is functional Change-Id: I3a7deb452960b370f5290f3d1bac9c79fe935303 Merged-In: I4bf7588c62fb77bf78d4afcb665e9bfbbef53966 (cherry picked from commit 360052f3)
-
Yohei Yukawa authored
With this CL, versionCode, targetSdkVersion and minSdkVersion will be bumped/set as follows: versionCode: 28 -> 30 targetSdkVersion: 28 -> 30 minSdkVersion: 21 As far as we know, there should be no user-visible behavior change on supported OS versions. Fix: 189558760 Test: manually verified that LatinIME still is functional Change-Id: I4bf7588c62fb77bf78d4afcb665e9bfbbef53966
-
- Feb 17, 2021
-
-
Bob Badour authored
Added SPDX-license-identifier-Apache-2.0 to: Android.bp common/Android.bp java/Android.bp native/dicttoolkit/Android.bp native/jni/Android.bp tests/Android.bp tools/EditTextVariations/Android.bp tools/dicttool/Android.bp tools/make-keyboard-text/Android.bp Bug: 68860345 Bug: 151177513 Bug: 151953481 Test: m all Exempt-From-Owner-Approval: janitorial work Change-Id: I440008bffac5c97a2497970af377a9d03262b6d8
-
- Jul 31, 2020
-
-
Seigo Nonaka authored
See https://source.android.com/setup/contribute/respectful-code for reference Bug: 161896447 Test: tapas LatinIME && m Change-Id: Ic06f948c023a091e1532db826a78dd01031d7205
-
Jeff Sharkey authored
See https://source.android.com/setup/contribute/respectful-code for reference Bug: 161896447 Change-Id: I171bc299e660f96f20041a67a3052bd8a2ed781c
-
- Dec 14, 2018
-
-
Brett Chabot authored
See go/jetpack-test-android-migration Test: make checkbuild Change-Id: I63edeced1465725cd8d6467cd75ea1acc2608932
-
- Nov 13, 2018
-
-
Yohei Yukawa authored
With this CL, targetSdkVersion and minSdkVersion will be bumped as follows: targetSdkVersion: 23 -> 28 minSdkVersion: 14 -> 21 As far as we know, there should be no user-visible behavior change on supported OS versions. Fix: 119489995 Test: manually verified that LatinIME still is functional Change-Id: I68f1545778b0c8b44c6850f22f3f5ca25bdb6de0
-
Yohei Yukawa authored
This logically reverts my previous CL [1], which moved <uses-sdk /> from AndroidManifest.xml to AndroidManifest_SdkVersion.xml, which was later accidentally removed during Android.bp migration [2]. Since gradle support in LatinIME is still experimental and not used in official build, it is OK to keep it broken for a while. A more important problem right now is letting LatinIME target API 28. As the first step to let LatinIME target SDK 28, <uses-sdk> will be revived in AndroidManifest.xml [1]: Ib673bca5a31b2f95329c9310a127ec0701bd8fdc 9cd42f39 [2]: Ib8867d3b74f09fc1d9f95adc9a49a81ac0f7f054 22ebec6e Bug: 110741422 Bug: 119489995 Test: manually verified that LatinIME still is functional Change-Id: I8b04caa56fe2431c07e076fb6f97c560d5da8838
-
- Nov 01, 2018
-
-
Dan Willemsen authored
See build/soong/README.md for more information. Test: cd packages/inputmethods/LatinIME; mma Change-Id: Ib8867d3b74f09fc1d9f95adc9a49a81ac0f7f054 Merged-In: Ib8867d3b74f09fc1d9f95adc9a49a81ac0f7f054
-
Dan Willemsen authored
See build/soong/README.md for more information. Test: cd packages/inputmethods/LatinIME; mma Change-Id: Ib8867d3b74f09fc1d9f95adc9a49a81ac0f7f054
-
- Oct 29, 2018
-
-
Tadashi G. Takaoka authored
This CL partially reverts - Id88b02b74bdfe4ca05b08181ceb6b34d5652fc0c - I05c7d8429e8d9a26139456763c77997340fea8c2 And followup (remove shortcut support) - I73b7dc008a5acaf75a31a36a2d332b5afabd82d0 Bug: 28255684 Test: make -j10 dicttool_aosp Change-Id: I2e01ed86b9517a1141aee35ea6d8ef39258981d1
-
- Aug 13, 2018
-
-
Yohei Yukawa authored
These tests are supposed to run even withotu @RunWith annocation, but for better consistency we should have it there. Bug: 110805255 Test: verified as follows. No new test failures. tapas adb LatinIME LatinIMETests arm64 userdebug && \ DISABLE_PROGUARD=true make -j LatinIME && \ adb install -r $OUT/system/app/LatinIME/LatinIME.apk && \ atest LatinIMETests:com.android.inputmethod.latin.ContactsDictionaryUtilsTest && \ atest LatinIMETests:com.android.inputmethod.latin.ContactsContentObserverTest Change-Id: I5c115d57b2ad41642f5f9b09b0c0d8f8c12480b0
-
- Jul 26, 2018
-
-
Yohei Yukawa authored
This should be the most convenient way for both make build and Android Studio build to share the same version code. Bug: 110741422 Test: tapas LatinIME LatinIMETests arm64 userdebug && make -j Change-Id: I35f850c392553b2640a4c3c7398441ac28e90eca
-
- Jul 25, 2018
-
-
Yohei Yukawa authored
Basically Android Studio does want targetSdkVersion to be specified in build.gradle rather than AndroidManifest.xml. To make both make build and Android Studio build happy, this CL splits <uses-sdk /> from the main AndroidManifest.xml to a different file and let them merged in make build. There should be no behavior change. Bug: 110741422 Test: Manually verified that there is no difference in AndroidManifest.xml in the APK. Change-Id: Ib673bca5a31b2f95329c9310a127ec0701bd8fdc
-
- Jul 24, 2018
-
-
Yohei Yukawa authored
InstrumentationTestCase and ActivityInstrumentationTestCase2 are deprecated. This CL rewrites tests that rely on those deprecated classes by using Android Testing Support Library. Bug: 110805255 Test: verified as follows. No new test failures. tapas adb LatinIME LatinIMETests arm64 userdebug && \ DISABLE_PROGUARD=true make -j LatinIME && \ adb install -r $OUT/system/app/LatinIME/LatinIME.apk && \ atest LatinIMETests:com.android.inputmethod.keyboard.internal.MoreKeySpecStringReferenceTests LatinIMETests:com.android.inputmethod.latin.settings.AccountsSettingsFragmentTests Change-Id: I4fefccaa0c480cfba7142ed36883da2f19b6a5f9
-
Yohei Yukawa authored
This is a follow up CL to previous CLs that converted unit tests to use Android Testing Support Library but forgot to remove unused import lines. Bug: 110805255 Test: verified as follows. No new test failures. tapas adb LatinIME LatinIMETests arm64 userdebug && \ DISABLE_PROGUARD=true make -j LatinIME && \ adb install -r $OUT/system/app/LatinIME/LatinIME.apk && \ atest LatinIMETests:com.android.inputmethod.latin Change-Id: I8762b0dfc209bdf68867f725b03a22286026faae
-
- Jul 06, 2018
-
-
Yohei Yukawa authored
This CL converts 19 test classes under com.android.inputmethod.latin to Android Testing Support Library. Bug: 110805255 Test: verified as follows. No new test failures. tapas adb LatinIME LatinIMETests arm64 userdebug && \ DISABLE_PROGUARD=true make -j LatinIME && \ adb install -r $OUT/system/app/LatinIME/LatinIME.apk && \ atest LatinIMETests:com.android.inputmethod.latin Change-Id: I878fcae0126f57c43a644af341e5a0a8ac8f5cc9
-
Yohei Yukawa authored
This CL converts 7 test classes under com.android.inputmethod.keyboard to Android Testing Support Library. This CL also fix missing annotations in KeyboardLayoutTest. Bug: 110805255 Test: verified as follows. No new test failures. tapas adb LatinIME LatinIMETests arm64 userdebug && \ DISABLE_PROGUARD=true make -j LatinIME && \ adb install -r $OUT/system/app/LatinIME/LatinIME.apk && \ atest LatinIMETests:com.android.inputmethod.keyboard Change-Id: I8ab9e3329f159f0df02812fafe44c25efa76c0d1
-
- Jul 05, 2018
-
-
Yohei Yukawa authored
This CL converts the following 3 test cases to Android Testing Support Library. * MoreKeysKeyboardBuilderAutoOrderTests * MoreKeysKeyboardBuilderFixedOrderTests * MoreKeysKeyboardBuilderMaxOrderTests Bug: 110805255 Test: atest LatinIMETests:com.android.inputmethod.keyboard.MoreKeysKeyboardBuilderAutoOrderTests Test: atest LatinIMETests:com.android.inputmethod.keyboard.MoreKeysKeyboardBuilderFixedOrderTests Test: atest LatinIMETests:com.android.inputmethod.keyboard.MoreKeysKeyboardBuilderMaxOrderTests Change-Id: I68d6c1901d4bb77bdc59d0be71eb565984fbd97d
-
Yohei Yukawa authored
This CL converts tests under com.android.inputmethod.latin.utils to Android Testing Support Library. Bug: 110805255 Test: verified as follows. No new test failures. tapas adb LatinIME LatinIMETests arm64 userdebug && \ DISABLE_PROGUARD=true make -j LatinIME && \ adb install -r $OUT/system/app/LatinIME/LatinIME.apk && \ atest LatinIMETests:com.android.inputmethod.latin.utils Change-Id: I5cc2ddbc4116003ab6407432ab521b6b560052ae
-
Yohei Yukawa authored
This CL converts tests under com.android.inputmethod.compat to Android Testing Support Library. Bug: 110805255 Test: verified as follows. No new test failures. tapas adb LatinIME LatinIMETests arm64 userdebug && \ DISABLE_PROGUARD=true make -j LatinIME && \ adb install -r $OUT/system/app/LatinIME/LatinIME.apk && \ atest LatinIMETests:com.android.inputmethod.compat Change-Id: I6766447ca27f5cccdb1e9f7e751235daa04cc252
-
Yohei Yukawa authored
PersonalDictionaryLookup has never been used. Usually proguard can remove this class but it also makes it difficult to run unit tests. We should just remove this unused class. Bug: 111164993 Test: compile Test: No new test failure Change-Id: I732db94cb3aac4ed9c6b5954679b896334a12a9c
-
Yohei Yukawa authored
Fix: 111161344 Test: Manually tested as follows tapas adb LatinIME LatinIMETests arm64 userdebug && \ DISABLE_PROGUARD=true make -j LatinIME && \ adb install -r $OUT/system/app/LatinIME/LatinIME.apk && \ atest LatinIMETests Change-Id: If9f5691d5c624c9856acd31a3e1de307360d2c7c
-
- Dec 15, 2017
-
-
Paul Duffin authored
In preparation for the removal of the non-junit classes in the android.test.base library from the android.jar this adds a dependency on android.test.base/stubs to ensure this code will continue to compile. The following change descriptions were generated automatically and so may be a little repetitive. They are provided to give the reviewer enough information to check the comments match what has actually been changed and check the reasoning behind the changes. * tests/Android.mk Added 'android.test.base.stubs' to LOCAL_JAVA_LIBRARIES because LatinIMETests's will need them in order to compile once its classes are removed from the current SDK on which it currently depends. Bug: 30188076 Test: make dist Change-Id: I9f2244d4b5711620dc02dd24dc407807d726480e
-
- Dec 07, 2017
-
-
Paul Duffin authored
Remove dependencies on android.test.mock.sdk as it is a duplicate of android.test.mock.stubs and will be removed. The following change descriptions were generated automatically and so may be a little repetitive. They are provided to give the reviewer enough information to check the comments match what has actually been changed and check the reasoning behind the changes. * tests/Android.mk Replaced 'android.test.mock.sdk' with 'android.test.mock.stubs' in LOCAL_JAVA_LIBRARIES because android.test.mock.sdk has been deprecated. Bug: 30188076 Test: make checkbuild Change-Id: I50a306c3bb80a9d7cdf2d19744734f304abf3bd1 Merged-In: I50a306c3bb80a9d7cdf2d19744734f304abf3bd1 (cherry picked from commit 097130d1)
-
- Dec 05, 2017
-
-
Paul Duffin authored
Previous changes statically included legacy-android-test in preparation for removing android.test.* and junit.* classes from the android.jar. Unfortunately, that lead to duplicate classes between APKs and the bootclasspath which caused build problems (Proguard) and also runtime problems (when targeting and running on older releases). Switching from statically including the classes to using the runtime libraries cannot be done in one step because legacy-android-test is statically included in libraries which are used in many APKs and so removing it from those libraries requires that all APKs be updated at once. Doing that atomically across dozens of projects is not practical. This change modifies APKS that statically include the legacy-android-test library indirectly. * If the APK manifest uses the android.test.runner library then the APK is modified to stop statically including legacy-android-test and instead build against android.test.base/mock/runner libraries instead. * Otherwise, the APK statically includes legacy-android-test. Also, any libraries that statically include are modified to stop statically including it and if it has source dependencies on the classes is changed to build against the android.test.base/mock/runner libraries. The following change descriptions were generated automatically and so may be a little repetitive. They are provided to give the reviewer enough information to check the comments match what has actually been changed and check the reasoning behind the changes. * tests/Android.mk Replaced 'legacy-android-test' with 'android.test.runner.stubs' in LOCAL_JAVA_LIBRARIES because LatinIMETests's source depends on its classes. The classes do not need to be statically included because the classes will be provided by the runtime, either from the default bootclasspath or from the android.test.runner library that LatinIMETests specifies in its manifest. Bug: 30188076 Test: make checkbuild Change-Id: I3c70889b35d402626f79c986771b9c2ea8823b8a
-
- Nov 16, 2017
-
-
Paul Duffin authored
Remove dependencies on android.test.mock.sdk as it is a duplicate of android.test.mock.stubs and will be removed. The following change descriptions were generated automatically and so may be a little repetitive. They are provided to give the reviewer enough information to check the comments match what has actually been changed and check the reasoning behind the changes. * tests/Android.mk Replaced 'android.test.mock.sdk' with 'android.test.mock.stubs' in LOCAL_JAVA_LIBRARIES because android.test.mock.sdk has been deprecated. Bug: 30188076 Test: make checkbuild Change-Id: I50a306c3bb80a9d7cdf2d19744734f304abf3bd1
-
- Jun 14, 2017
-
-
Paul Duffin authored
A previous change added legacy-android-test as a static dependency to all packages that build against the current, test_current or system_current and failed to compile when the junit and android.test classes were removed from the API. Unfortunately, those changes did not take into account that some of those packages target earlier API versions and so will always have the classes available at runtime. This change replaces those static dependencies with dynamic dependencies for any package that targets an earlier API version. The file changes were made automatically by a tool that constructed and then analyzed a full dependency graph of all the Android Java modules. The individual changes were checked manually to ensure that the changes matched the intent. The affected modules were built against an API with the junit and android.test classes removed. Any issues found during this process resulted in either the tool being updated to address the issue or a separate change being made to fix an existing problem with the build. A sample of the affected packages were run to ensure that they worked as expected at runtime; no issues were found during testing. The following change descriptions were generated automatically and so may be a little repetitive. They are provided to give the reviewer enough information to check the comments match what has actually been changed and check the reasoning behind the changes. * tests/Android.mk Removed legacy-android-test from LOCAL_STATIC_JAVA_LIBRARIES because LatinIMETests's manifest file (AndroidManifest.xml) targets API level 21 and dynamically includes the android.test.runner library at runtime so there is no point in statically including the classes. Added 'android.test.mock.sdk' and 'legacy-android-test' to LOCAL_JAVA_LIBRARIES because module LatinIMETests builds against 'LOCAL_SDK_VERSION := current' and uses classes from packages android.test and android.test.mock (possibly indirectly) so will no longer compile once they are removed from the API. Dependency 'android.test.mock.sdk' is used instead of 'android.test.mock' because module LatinIMETests builds against the API not internal jars and so should use libraries that build against the API not internal jars. A future change will replace the dependency on 'legacy-android-test', which builds against the internal jars with a dependency on 'android.legacy.test' which will build against the API. Bug: 30188076 Test: make checkbuild and ran a sample of tests Change-Id: I63f1a8ad16a76aba0da89b69a64cdae4400af5a0 Merged-In: Icab8a4c4801536f112e29dfd2dc66be8b90b811d
-
- Jun 13, 2017
-
-
Paul Duffin authored
A previous change added legacy-android-test as a static dependency to all packages that build against the current, test_current or system_current and failed to compile when the junit and android.test classes were removed from the API. Unfortunately, those changes did not take into account that some of those packages target earlier API versions and so will always have the classes available at runtime. This change replaces those static dependencies with dynamic dependencies for any package that targets an earlier API version. The file changes were made automatically by a tool that constructed and then analyzed a full dependency graph of all the Android Java modules. The individual changes were checked manually to ensure that the changes matched the intent. The affected modules were built against an API with the junit and android.test classes removed. Any issues found during this process resulted in either the tool being updated to address the issue or a separate change being made to fix an existing problem with the build. A sample of the affected packages were run to ensure that they worked as expected at runtime; no issues were found during testing. The following change descriptions were generated automatically and so may be a little repetitive. They are provided to give the reviewer enough information to check the comments match what has actually been changed and check the reasoning behind the changes. * tests/Android.mk Removed legacy-android-test from LOCAL_STATIC_JAVA_LIBRARIES because LatinIMETests's manifest file (AndroidManifest.xml) targets API level 21 and dynamically includes the android.test.runner library at runtime so there is no point in statically including the classes. Added 'android.test.mock.sdk' and 'legacy-android-test' to LOCAL_JAVA_LIBRARIES because module LatinIMETests builds against 'LOCAL_SDK_VERSION := current' and uses classes from packages android.test and android.test.mock (possibly indirectly) so will no longer compile once they are removed from the API. Dependency 'android.test.mock.sdk' is used instead of 'android.test.mock' because module LatinIMETests builds against the API not internal jars and so should use libraries that build against the API not internal jars. A future change will replace the dependency on 'legacy-android-test', which builds against the internal jars with a dependency on 'android.legacy.test' which will build against the API. Bug: 30188076 Test: make checkbuild and ran a sample of tests Change-Id: Icab8a4c4801536f112e29dfd2dc66be8b90b811d
-
- May 10, 2017
-
-
Paul Duffin authored
In preparation for removing junit and android.test classes from the Android API this change adds explicit dependencies on junit and/or legacy-android-test to ensure that modules will compile properly once it is removed. Care was taken to ensure that any targets that depended, directly or indirectly, on android-support-test did not also depend on junit or hamcrest as they conflict with the versions embedded within android-support-test. Bug: 30188076 Test: make checkbuild Change-Id: Icf844999082db141cffcb099aa4004afc7a7c749 Merged-In: I743f9e20e1e60836ceba9b9051fa17835deba3a2
-
- May 08, 2017
-
-
Paul Duffin authored
In preparation for removing junit and android.test classes from the Android API this change adds explicit dependencies on junit and/or legacy-android-test to ensure that modules will compile properly once it is removed. Care was taken to ensure that any targets that depended, directly or indirectly, on android-support-test did not also depend on junit or hamcrest as they conflict with the versions embedded within android-support-test. Bug: 30188076 Test: make checkbuild Change-Id: I160c136ecd1089a2b13d5cdba9eee1287aad93f9 Merged-In: I743f9e20e1e60836ceba9b9051fa17835deba3a2
-
- May 05, 2017
-
-
Paul Duffin authored
In preparation for removing junit and android.test classes from the Android API this change adds explicit dependencies on junit and/or legacy-android-test to ensure that modules will compile properly once it is removed. Care was taken to ensure that any targets that depended, directly or indirectly, on android-support-test did not also depend on junit or hamcrest as they conflict with the versions embedded within android-support-test. Bug: 30188076 Test: make checkbuild Change-Id: I743f9e20e1e60836ceba9b9051fa17835deba3a2
-
- Aug 25, 2016
-
-
Guang Zhu authored
Bug: 31072145 Test: make droid checkbuild Change-Id: I507b476694f88cc960804904feff330e6f9358c4
-
- Jul 15, 2015
-
-
Mohammadinamul Sheik authored
This build has been compiled against API 23 This build is approved to go out with the M OTA, but may NOT be released to the public until the Play Store has enabled API level 23 apps Version: 4.1.2300x.build_id 1. Replaces the personalization is on information with the suggest contacts. 2. Enables "Use Contacts" only if the app has permission to read contacts. 3. Disables the contacts dictionary in the Facilitator. 4. Do not register/read the contacts in the contact observer. Bug: 22236416 Change-Id: I9674e13d0d0f4a2014c5024fde0178de684c07e7
-
- Jun 23, 2015
-
-
Tom Ouyang authored
Change-Id: I4f0472b9f2ea2daeeba3025c588e6d0042c31be7
-