Skip to content
Snippets Groups Projects
  1. Jun 16, 2014
  2. Jun 10, 2014
    • Jean Chalard's avatar
      Remove mPrevWordsInfo · 367c199d
      Jean Chalard authored
      This member has outlived its usefulness. It's not clear now that it
      makes things really faster, but it does bring a lot of complexity
      that we can avoid by removing it.
      
      Change-Id: Ifbc8094a45b56b958fe165b1930f4cc358a97721
      367c199d
  3. Jun 06, 2014
    • Jean Chalard's avatar
      When starting input, include the literal word in suggestions · fca2c4b4
      Jean Chalard authored
      This change also includes a fix that has suggestions re-computed
      when the typed word is included but no prior suggestions were
      found in spans.
      
      Bug: 2349475
      Change-Id: Ic06e6ac492507126ffc1e96a5f396c971b567272
      fca2c4b4
    • Jean Chalard's avatar
      Fix a bug on rotation with selection. · 9fd9a68d
      Jean Chalard authored
      The symptom : when text is selected and the device is rotated,
      sometimes the keyboard sets the word as being composed around
      the start of the selection. Upon the next rotation this ends up
      with the keyboard committing some text in place of the selection.
      
      The cause : another bug in the framework with rotation >.>
      The keyboard receives a call to startInput with a wrong cursor
      position, namely one that does not represent a selection. The
      keyboard sets a composition according to this wrong data. When
      the keyboard is rotated again, it commits the text, which takes
      the place of the selection.
      
      The solution : actually when restarting input the keyboard
      realizes that the cursor position is wrong. We cancel composition
      at that time.
      For robustness, this change also implements two other defensive
      changes : upon call to onUpdateSelection, we actually realize
      that the previous values were wrong, so we also fix it at that
      time, and in addition, when rotating, we finishComposingText()
      instead of commitText() which is less dangerous. Implementing
      this later change also allows us to let less internal variables
      from InputLogic escape to LatinIME, so it's also a good change
      for design.
      
      Bug: 14140799
      
      Change-Id: Ib10de18e53e376ac1bbc8487e13d969828483346
      9fd9a68d
  4. Jun 05, 2014
  5. Jun 04, 2014
    • Jean Chalard's avatar
      Don't recapitalize just at the start of input · c84b1084
      Jean Chalard authored
      Bug: 13283555
      Change-Id: Iab0466425dc44779d110f2cd29d725d22eb04827
      c84b1084
    • Jean Chalard's avatar
      Refactoring · 4a1113b6
      Jean Chalard authored
      Rename `initialize' to `start' and `deactivate' to `stop' for ease
      of understanding. It's completely bizarre that you can "deactivate"
      a recapitalization and that will just restart a new one the next time
      you press shift. Start and stop are easier to understand.
      
      Change-Id: I455175aebfcfe11198c6c61bf2c6b19efc3f82df
      4a1113b6
  6. May 30, 2014
  7. May 29, 2014
  8. May 28, 2014
  9. May 26, 2014
  10. May 23, 2014
  11. May 22, 2014
  12. May 21, 2014
  13. May 20, 2014
  14. May 14, 2014
  15. May 12, 2014
  16. May 01, 2014
  17. Apr 24, 2014
  18. Apr 16, 2014
  19. Apr 14, 2014
  20. Apr 10, 2014
    • Jean Chalard's avatar
      Fix some flaky tests. · 4370ff09
      Jean Chalard authored
      In tests, we create many instances of LatinIME, but we never
      destroy them. That means we never close the dictionaries nor
      the handlers.
      This change calls onDestroy, which closes all dictionaries, and
      adds some code to finish the handlers.
      
      Change-Id: I942517a2a940c54256b08763f6b38f5b55809f55
      4370ff09
  21. Apr 07, 2014
  22. Apr 03, 2014
Loading