Skip to content
Snippets Groups Projects
  1. Aug 13, 2014
  2. Aug 12, 2014
  3. Aug 08, 2014
  4. Aug 06, 2014
  5. Aug 05, 2014
    • Jean Chalard's avatar
      [HW14] Cleanup · dd31a2de
      Jean Chalard authored
      Do away with the didAutoCorrect local variables which are
      unnatural to return out of all these functions.
      
      Change-Id: I22024004d2c489de018beff812c2c589bfd8ca32
      dd31a2de
  6. Aug 04, 2014
  7. Jul 27, 2014
    • Tadashi G. Takaoka's avatar
      Make "Show correction suggestions" as a binary option · ab661e3e
      Tadashi G. Takaoka authored
      Formerly "Show correction suggestions" had three options, "always
      show", "show in portrait mode", and "always hide". The reason behind
      "show in portrait mode" was that there may not be enough screen estate
      in landscape mode to show suggestions. Because recent phone devices
      have relatively large screen, we decide to remove "show in portrait
      mode" option.
      
      Bug: 15780939
      Change-Id: I896d737452c3893d43ce20bd88127f10c1eb3d83
      ab661e3e
  8. Jul 29, 2014
  9. Jul 28, 2014
  10. Jul 20, 2014
    • Yohei Yukawa's avatar
      Enable InputMethodService#onUpdateCursor behind the flag · 3f513f10
      Yohei Yukawa authored
      With this CL, InputMethodService#onUpdateCursor and
      InputMethodService#onUpdateCursorAnchorInfo can be enabled
      on L when ENABLE_CURSOR_ANCHOR_INFO_CALLBACK and
      ENABLE_CURSOR_RECT_CALLBACK are specified, respectively.
      
      BUG: 16382260
      Change-Id: I29924128f6bd2f08cbd91cc4e82c9c4a6ecce3ff
      3f513f10
  11. Jul 17, 2014
  12. Jul 01, 2014
  13. Jun 30, 2014
    • Jean Chalard's avatar
      [SD4] Restart suggestions on language change · 6345562e
      Jean Chalard authored
      ...otherwise we can't recompute the composition when we
      change scripts.
      
      This also fixes when we register that we need to take note
      that the current subtype was used. Luckily this is a good
      occasion for some cleanup that I've wanted to do for some
      time: use InputTransaction for onTextInput (with the goal
      to ultimately remove it entirely)
      
      Bug: 15840116
      Change-Id: Ie4f4f9157b66b79237eeb3db75535803124d3e19
      6345562e
  14. Jun 27, 2014
  15. Jul 01, 2014
    • Jean Chalard's avatar
      Fix a unit test · fa4c59f9
      Jean Chalard authored
      When switching languages, we need to wait until the dictionary is
      loaded to compute suggestions.
      
      Change-Id: I7c32a900b297cd6302bfdc020842581315f3007f
      fa4c59f9
  16. Jun 27, 2014
  17. Jun 16, 2014
  18. Jun 13, 2014
  19. Jun 11, 2014
  20. Jun 09, 2014
  21. Jun 06, 2014
    • Tadashi G. Takaoka's avatar
      Refactor logic to determine showing suggestions strip or not · 987bff91
      Tadashi G. Takaoka authored
      The logic to determine when the suggestions strip (a.k.a. the
      contextual strip) should be shown is already complex. In addition to
      that the voice input key get shown on the strip as well. There are a
      several factors to be considered and a few things to control.
      
      - The password input field shouldn't have the strip.
      - Show voice input key on the strip or not.
        - User preference settings "Show Voice Input Key".
        - A voice IME exists and is enabled.
        - The input field may have a private IME option to prevent the voice
          input key from being displayed.
      - Application can specify auto completions.
        - Full screen mode or not.
      - User preference settings "Show correction suggestions".
        - Always show, Show in portrait mode, Always hide.
      - The input field may have flags to prevent showing suggestions or
        auto corrections.
      - Suggestions is empty or not.
      - An important notice may be shown.
      
      Bug: 14981852
      Bug: 15436479
      Change-Id: I3050fd53ee6271fc64a8f17b6b12d9581d37b750
      987bff91
    • Jean Chalard's avatar
      When starting input, include the literal word in suggestions · fca2c4b4
      Jean Chalard authored
      This change also includes a fix that has suggestions re-computed
      when the typed word is included but no prior suggestions were
      found in spans.
      
      Bug: 2349475
      Change-Id: Ic06e6ac492507126ffc1e96a5f396c971b567272
      fca2c4b4
    • Jean Chalard's avatar
      Fix a small bug with rotation. · c69ba563
      Jean Chalard authored
      Bug: 2349475
      Change-Id: Id4aa5ce56b1a545e4cb88ca1b01cf24642deade2
      c69ba563
    • Tadashi G. Takaoka's avatar
      Always update voice key visibility · aa4b2c71
      Tadashi G. Takaoka authored
      Bug: 15128166
      Change-Id: Ie15724c323efa3b102f6aebddc3bda210aad1727
      aa4b2c71
    • Tadashi G. Takaoka's avatar
      Remove unused supportsSwitchingToShortcutIme attribute · 3ca65c8f
      Tadashi G. Takaoka authored
      Change-Id: I51c5247ac925a158facb79057f704b763b903552
      3ca65c8f
    • Jean Chalard's avatar
      Fix a bug on rotation with selection. · 9fd9a68d
      Jean Chalard authored
      The symptom : when text is selected and the device is rotated,
      sometimes the keyboard sets the word as being composed around
      the start of the selection. Upon the next rotation this ends up
      with the keyboard committing some text in place of the selection.
      
      The cause : another bug in the framework with rotation >.>
      The keyboard receives a call to startInput with a wrong cursor
      position, namely one that does not represent a selection. The
      keyboard sets a composition according to this wrong data. When
      the keyboard is rotated again, it commits the text, which takes
      the place of the selection.
      
      The solution : actually when restarting input the keyboard
      realizes that the cursor position is wrong. We cancel composition
      at that time.
      For robustness, this change also implements two other defensive
      changes : upon call to onUpdateSelection, we actually realize
      that the previous values were wrong, so we also fix it at that
      time, and in addition, when rotating, we finishComposingText()
      instead of commitText() which is less dangerous. Implementing
      this later change also allows us to let less internal variables
      from InputLogic escape to LatinIME, so it's also a good change
      for design.
      
      Bug: 14140799
      
      Change-Id: Ib10de18e53e376ac1bbc8487e13d969828483346
      9fd9a68d
  22. Jun 05, 2014
  23. May 29, 2014
Loading