Skip to content
Snippets Groups Projects
  1. Oct 10, 2023
  2. Sep 28, 2023
  3. Jul 06, 2023
  4. Mar 19, 2023
    • Jing Mike's avatar
      Remove unused variables · 03eef94a
      Jing Mike authored
      
      Since some variables with module LatinIME are defined but not used,
      when compiled with build combination "sdk_pc_x86_64-userdebug" and
      build command "mmm packages/inputmethods/LatinIME", the following
      code lines will be reported that "variable 'XXX' set but not used".
      (should be similar for all the other build combinations)
      
      Repeated 10 times for each:
      terminal_position_lookup_table.cpp:74:9 removedEntryCount
      terminal_position_lookup_table.cpp:85:9 removedEntryCount
      proximity_info_state_utils.cpp:493:9 tempTime
      trie_map.cpp:56:9 unusedRegionSize
      suggestion_results.cpp:100:9 index
      
      Repeated 80+ times:
      proximity_info_utils.h:75:25 proximityChar
      
      With this patch we are removing some of the unused variables and
      putting the C++ 17 attribute [[maybe_unused]] to the others which
      are used for logging. Then all the related build warnings have been
      eliminated.
      
      Test: mmm packages/inputmethods/LatinIME, presubmit check.
      
      Change-Id: Ia66766322d6ae8a010b1cb55cc22993fbc6d012c
      Signed-off-by: default avatarJing Mike <jingyangliu@eswincomputing.com>
      03eef94a
  5. Feb 17, 2021
    • Bob Badour's avatar
      [LSC] Add LOCAL_LICENSE_KINDS to packages/inputmethods/LatinIME · f3d9532a
      Bob Badour authored
      Added SPDX-license-identifier-Apache-2.0 to:
        Android.bp
        common/Android.bp
        java/Android.bp
        native/dicttoolkit/Android.bp
        native/jni/Android.bp
        tests/Android.bp
        tools/EditTextVariations/Android.bp
        tools/dicttool/Android.bp
        tools/make-keyboard-text/Android.bp
      
      Bug: 68860345
      Bug: 151177513
      Bug: 151953481
      
      Test: m all
      
      Exempt-From-Owner-Approval: janitorial work
      Change-Id: I440008bffac5c97a2497970af377a9d03262b6d8
      f3d9532a
  6. Feb 16, 2021
  7. Feb 15, 2021
  8. Jul 31, 2020
  9. Apr 13, 2020
    • Orion Hodson's avatar
      Add explicit dependencies on jni_headers · 54c4f2af
      Orion Hodson authored
      Preparation for removing implicit include paths for jni.h from soong.
      
      Bug: 152482542
      Test: lunch aosp_x86_64 && m checkbuild
      Change-Id: Ib36e679819a3309ccbf12fd592309b16c8bbd6c8
      54c4f2af
  10. Jan 11, 2019
    • Anton Hansson's avatar
      Move LatinIME and its lib to /product · 1c429e3a
      Anton Hansson authored
      This app is frequently overriden by proprietary apps
      on shipping devices, so move it to /product along with
      its jni library.
      
      Bug: 122353713
      Test: launch keyboard on aosp_arm64 emulator
      Change-Id: Ied8c1e6133b67e28da76b0e48254e2e2e0ed15bf
      1c429e3a
  11. Dec 11, 2018
  12. Nov 01, 2018
    • Dan Willemsen's avatar
      Convert to Android.bp · a23407bf
      Dan Willemsen authored
      See build/soong/README.md for more information.
      
      Test: cd packages/inputmethods/LatinIME; mma
      Change-Id: Ib8867d3b74f09fc1d9f95adc9a49a81ac0f7f054
      Merged-In: Ib8867d3b74f09fc1d9f95adc9a49a81ac0f7f054
      a23407bf
    • Dan Willemsen's avatar
      Convert to Android.bp · 22ebec6e
      Dan Willemsen authored
      See build/soong/README.md for more information.
      
      Test: cd packages/inputmethods/LatinIME; mma
      Change-Id: Ib8867d3b74f09fc1d9f95adc9a49a81ac0f7f054
      22ebec6e
  13. Sep 25, 2018
  14. Jul 26, 2018
    • Yohei Yukawa's avatar
      Fix lint warnings in LatinIME JNI code · 3d74fc73
      Yohei Yukawa authored
      This CL addresses compiler warnings when building libjni_latinime.so
      with NDK from Android Studio.
      
      There should be no behavior change.
      
      Bug: 110741422
      Bug: 110757803
      Test: tapas LatinIME LatinIMETests arm64 userdebug && make -j
      Change-Id: Icc711dd46511a167b1fd90028552def5b2f9941f
      3d74fc73
  15. Jul 25, 2018
    • Yohei Yukawa's avatar
      Deprecate host-side C++ test in LatinIME · f4131e3f
      Yohei Yukawa authored
      Host-side C++ test in LatinIME is no longer actively used and is
      actually not compatible with Android Studio build.
      
      Let's just remove this for now.
      
      Bug: 13754552
      Bug: 110741422
      Test: compile
      Change-Id: I3e81285fe559022e1a296051036e74d2f2afbf9c
      f4131e3f
  16. Nov 02, 2017
  17. Oct 20, 2017
  18. Sep 11, 2017
  19. Oct 07, 2016
  20. Mar 23, 2016
    • Dan Albert's avatar
      Stop mixing and matching platform and NDK. · a4e93839
      Dan Albert authored
      The library was being built with the NDK, but the test is being built
      with the platform, in this case building against the NDK STL headers
      and then using the platform library, which are not ABI compatible.
      
      Bug: http://b/27801981
      Change-Id: I7386dfe6ac73334d7c1b1e0cbc8dc346c84313bf
      a4e93839
  21. Jun 23, 2015
    • Dan Albert's avatar
      Use the new sanitizer option. · 1c2d6743
      Dan Albert authored
      I apparently forgot to upload this change last week when I was
      cleaning this up.
      
      Change-Id: Ibe8c871b4ebb2e814b8d234f8f38fa5f5f721ae2
      1c2d6743
  22. Mar 27, 2015
  23. Dec 17, 2014
  24. Dec 15, 2014
  25. Dec 09, 2014
  26. Nov 25, 2014
    • Keisuke Kuroyanagi's avatar
      Enable Quadgram for personalized dicts. · 60021bbd
      Keisuke Kuroyanagi authored
      Before:
      Total words: 1134659, Success Num: 944709, Success Percentage: 83.259%
      Bad Failures, with auto-correction (typed word == expected word, output word != expected word): 1258, Bad Failure Percentage: 0.111%
      Failures, with auto-correction (F-C): 28013, F-C Percentage: 2.469%
      Max Keystrokes: 6072844, Min Keystrokes: 3347332, Keystroke Saving Percentage:44.880%
      
      After:
      Total words: 1134665, Success Num: 945026, Success Percentage: 83.287%
      Bad Failures, with auto-correction (typed word == expected word, output word != expected word): 1271, Bad Failure Percentage: 0.112%
      Failures, with auto-correction (F-C): 27756, F-C Percentage: 2.446%
      Max Keystrokes: 6072850, Min Keystrokes: 3290996, Keystroke Saving Percentage:45.808%
      
      Change-Id: I16af52a3e9c371b95fd6f0741f45ee6b2443bea6
      60021bbd
    • Keisuke Kuroyanagi's avatar
      Use enum to specify ngram type. · 78212a6d
      Keisuke Kuroyanagi authored
      Change-Id: Ie28768ceadcd7a2d940c57eb30be7d4c364e509f
      78212a6d
  27. Nov 19, 2014
  28. Nov 17, 2014
  29. Nov 11, 2014
  30. Nov 10, 2014
Loading