Skip to content
Snippets Groups Projects
  1. Mar 25, 2014
    • Keisuke Kuroyanagi's avatar
      Remove logic related to dictionary loading from LatinIME. · adfb2627
      Keisuke Kuroyanagi authored
      Make mSuggest final and give DictionaryFacilitator the
      responsibility to manage dictionary loading state.
      This can simplify the logic to decide how to deal with
      additional dictionaries when loading settings or language
      switching.
      
      Bug: 13273534
      Change-Id: I9f3d328272f25addfa186fbeedaaf8417455ba99
      adfb2627
  2. Dec 26, 2013
  3. Jul 31, 2013
  4. May 23, 2013
  5. May 14, 2013
    • Kurt Partridge's avatar
      Add claifying comment · 3e8df13c
      Kurt Partridge authored
      This is a follow-up to I7c01c3dd3ac33d7e96c00836256bae9c14b124ed
      
      Change-Id: I9e3f8968c4bbf9525d5dfe101f71373c42f88361
      3e8df13c
  6. May 11, 2013
    • Kurt Partridge's avatar
      Avoid JsonWriter multi-write error · 7d72ca0b
      Kurt Partridge authored
      JsonWriter requires that its clients pass it only a single top-level object.
      The existing implementation tries to make code cleaner by having mJsonWriter
      never be null, and instead use a global static "NULL_JSON_WRITER" that just
      discards data.  But because JsonWriter complains if more than one top-level
      object is passed, making this a global object does not work.  This change
      instead copes with mJsonWriter being null.
      
      Change-Id: Ia37ccfc8646e91f11a64713dd92d2846eb86ac54
      7d72ca0b
  7. May 07, 2013
    • Kurt Partridge's avatar
      Fix looping logic bugs. · 8064c669
      Kurt Partridge authored
      shiftOut() is getting called once too often through these for loops.
      
      Change-Id: I9a68b49e6cc1469bcddd673ab1567e238cf192b8
      8064c669
  8. Apr 19, 2013
    • Kurt Partridge's avatar
      Allow LogUnits to hold >1 word · e92b5e14
      Kurt Partridge authored
      LogUnits have been annotated with the autocorrected words, but
      until now this was assumed to be a single word without spaces.
      But spaceless typing can result in spaces in the LogUnit label.  With this
      change, the LogUnit inspects the autocorrected text to determine how many
      words were inserted, and counts them accurately.
      
      This change corrects a privacy problem, which was that if the word sampling
      algorithm chose a LogUnit that actually contained multiple words, then more
      than two successive words would be included in the log.
      
      Change-Id: I7c01c3dd3ac33d7e96c00836256bae9c14b124ed
      e92b5e14
  9. Apr 17, 2013
    • Kurt Partridge's avatar
      Fix bug in counting words between samples · bf62dc94
      Kurt Partridge authored
      Previously MainLogBuffer#shiftOutWords() assumed it wouldn't be called if
      mNumWordsUntilSafeToSample was 0.  This relaxes this assumption (which is in fact
      false in the current code).
      
      Change-Id: I8723248095e84a0d9d6f4639b4742cc7dda9716b
      bf62dc94
  10. Mar 18, 2013
  11. Mar 01, 2013
  12. Feb 27, 2013
    • Kurt Partridge's avatar
      [TestPrep17] Allow fake dictionary for testing · 5ee261a9
      Kurt Partridge authored
      Currently ResearchLog requires a full dictionary to perform privacy-related checks.
      This makes testing difficult.  This change allows a fake dictionary to be used instead.
      
      Change-Id: Ifca5bd8647475a6b84e4324117e0faa0a35479ee
      5ee261a9
  13. Feb 21, 2013
  14. Jan 23, 2013
  15. Jan 21, 2013
    • Kurt Partridge's avatar
      [Rlog78b] Make log privacy filtering decisions on n-grams · 80685aa4
      Kurt Partridge authored
      Previously, words were pushed out of a LogBuffer one at a time.  The receiving code had to keep
      state to know whether a n-gram was safe to log.  This patch looks at the entire n-gram and makes a
      single decision based on it alone.
      
      mult-project commit with I3c40d7e02c77943d2668094ddb1d03efb942c74f
      
      Change-Id: Id7d90bbd551b1a2f4e0e35f38852652f68f273f8
      80685aa4
    • Tadashi G. Takaoka's avatar
      Fix Apache license comment · 8aa9963a
      Tadashi G. Takaoka authored
      Change-Id: Ic56167f952a7f4449da366e1e81610e72c966086
      8aa9963a
  16. Jan 10, 2013
    • Kurt Partridge's avatar
      [Rlog56] Buffer words before pushing out LogUnit · 403c4239
      Kurt Partridge authored
      Previously, a logbuffer only held an n-gram.  Data went in and out of it, FIFO, until privacy
      conditions were met (i.e. data not collected too frequently), and then an n-gram was saved.
      E.g., if n=2, and only 10% of data is collected, then 18 words went through the logbuffer before
      it captured the next 2 words.
      
      However, if a user then went back and edited the n-gram, these edits were not captured.
      
      This change changes the logbuffer size to temporarily hold data about words that are not recorded,
      so that if the user backs up over them, the edits to an n-gram that we do eventually capture are
      stored.  If the example above, instead of a logbuffer holding 2 words, it holds 20.  The system
      waits until all the words not needed for the n-gram have been gathered (i.e. the buffer is full),
      so the user has adequate time to edit, before shifting out the n-gram.  The buffer is still flushed
      when the user closes the IME.  See the comment for MainLogBuffer for an explanation.
      
      multi-project commit with I45317bc95eeb859adc1b35b24d0478f2df1a67f3
      
      Change-Id: I4ffd95d08c6437dcf650d866ef9e24b6af512334
      403c4239
    • Kurt Partridge's avatar
      [Rlog50] capture bigrams properly even with deletions · 3b95eaf7
      Kurt Partridge authored
      multi-project commit with Ia4ec213e8356897807cb6a278fccdbaa945732f0
      
      Change-Id: Ib3fe886dc889954a31586ab81d00a21d8d55efd2
      3b95eaf7
  17. Jan 04, 2013
  18. Dec 19, 2012
    • Kurt Partridge's avatar
      Add ProductionFlag.IS_EXPERIMENTAL_DEBUG · 0aafbcf8
      Kurt Partridge authored
      The IS_EXPERIMENTAL_DEBUG flag gives a single place to turn off all debugging flags that might be
      set and to also enforce privacy controls.  Currently only used in the research package.
      
      multi-project commit with I9275a7c8e40bf56106447a02d3056655329074b3
      
      Change-Id: If769fe3a633f33963ca49e8ddf01ab24a30b6fd2
      0aafbcf8
  19. Dec 18, 2012
    • Kurt Partridge's avatar
      [Rlog4] ResearchLogger add LOG_EVERYTHING flag · 1a273368
      Kurt Partridge authored
      - broaden OUTPUT_WHOLE_BUFFER to log not just the buffer at the end, but everything along the
        way.  This should only be set when the user is aware that logging is on, e.g. in a user test.
      
      Change-Id: I8f9874697524e533586da40d0a3e452f6a04d3e4
      1a273368
  20. Dec 17, 2012
    • Kurt Partridge's avatar
      [Rlog2] ResearchLogging fix multi-space logging · 3370dc82
      Kurt Partridge authored
      multi-space logging should look like single-space logging, missing a few minor log statements
      (SuggestionUpdates, SetComposingText)
      
      multi-project commit with I2af842348c2f2b8f7271ac5b63def245e83df24d
      
      Change-Id: Icd3187c0d0377255f82787afffea657c14345803
      3370dc82
  21. Dec 14, 2012
    • Kurt Partridge's avatar
      [Rlog1] Track time of log statements · 5e854e28
      Kurt Partridge authored
      Log statements are now recorded with a timestamp.  This is important for filtering out statements
      not part of words that are sampled when spaces are inserted automatically.
      
      multi-project commit with Change-Id: I68221a2528045d25632aef4bb716f92a4f4a56a4
      
      Change-Id: I46ac9b3b1dcbb08425160d0109028cb64445139c
      5e854e28
  22. Nov 29, 2012
  23. Aug 22, 2012
    • Kurt Partridge's avatar
      ResearchLogging capture full n-gram data · bf653996
      Kurt Partridge authored
      - Captures complete motion data for all words in an n-gram.
      - Also filters n-grams properly; if any word in the n-gram is not
        in the dictionary, it is not included.
      - Simplify ResearchLog to not require explicit state
      - Added LogBuffer class MainLogBuffer class to allow n-gram-level decisions
        about privacy.
      - Moved LogUnit out from ResearchLogger
      
      multi-project change with Ic70ccb6c2e11eb02d887821434b44daa3eb7a3e2
      
      Bug: 6188932
      Change-Id: I731d6cff6539e997874f723b68bdb0d9b651b937
      bf653996
  24. Aug 20, 2012
  25. Aug 18, 2012
    • Kurt Partridge's avatar
      ResearchLogging capture full n-gram data · 221e756f
      Kurt Partridge authored
      DO NOT MERGE
      
      - Captures complete motion data for all words in an n-gram.
      - Also filters n-grams properly; if any word in the n-gram is not
        in the dictionary, it is not included.
      - Simplify ResearchLog to not require explicit state
      - Added LogBuffer class MainLogBuffer class to allow n-gram-level decisions
        about privacy.
      - Moved LogUnit out from ResearchLogger
      
      multi-project change with Ie2bc79fd7fe6b951b24771e94b8d4ca21989af65
      
      Bug: 6188932
      Change-Id: I568c90d4af07e7c759c1e7fc64b716bd8c7b4ae5
      221e756f
  26. Aug 08, 2012
  27. Aug 05, 2012
    • Kurt Partridge's avatar
      ResearchLogging capture full n-gram data · 838e6c1e
      Kurt Partridge authored
      - Captures complete motion data for all words in an n-gram.
      - Also filters n-grams properly; if any word in the n-gram is not
        in the dictionary, it is not included.
      - Simplify ResearchLog to not require explicit state
      - Added LogBuffer class MainLogBuffer class to allow n-gram-level decisions
        about privacy.
      - Moved LogUnit out from ResearchLogger
      
      multi-project change with Id997fb6572daa3ff55591afa1676953bb204f33a
      
      Because of a strange Gerrit interaction, earlier patchsets were recorded
      as the following separate changes (to soon be abandoned):
      
      - I59d86ae28123890ddb7aabc7dc9a73a75eecbca4
      - I9cc95266fa4500d019e09ec53ec00e5dea7ffd38
      - Ie6f23a2035e160f231406df1388a43725380df1d
      - Id87909e96fa7fa91174c86395a964404f3490fe1
      - I57c5cbde0425c42538d589fa4d1802b3e5688f7c
      - Ic1f9d7727e416da1b6c4f1a45b53750cd4088dcf
      - I20a72ccc4ba1bc08ed3ee39bff71d2adb376588c
      - I417f6f364144b90085f5fef4bd2de1a40b5dfa79
      
      Bug: 6188932
      Change-Id: I771e57e3b8c0eb6721c2022e775cb0b528bdff93
      838e6c1e
Loading