Skip to content
Snippets Groups Projects
  1. Apr 03, 2015
  2. Oct 21, 2014
    • Tadashi G. Takaoka's avatar
      Fix some compiler warnings · 5f00fe09
      Tadashi G. Takaoka authored
      This CL fixes the following compiler warnings.
      
      - Indirect access to static member
      - Access to a non-accessible member of an enclosing type
      - Parameter assignment
      - Method can be static
      - Local variable declaration hides another field or variable
      - Value of local variable is not used
      - Unused import
      - Unused private member
      - Unnecessary 'else' statement
      - Unnecessary declaration of throw exception
      - Redundant type arguments
      - Missing '@Override' annotation
      - Unused '@SuppressWarning' annotations
      
      Bug: 18003991
      Change-Id: Icfebe753e53a2cc621848f769d6a3d7ce501ebc7
      5f00fe09
  3. Sep 03, 2014
    • Jatin Matani's avatar
      Attempt retry for broken dictionaries · 256b1b2a
      Jatin Matani authored
      1. Add retry count column within metadata in dictionary pack.
      2. Attempt a retry for download and installation by running StartDownloadAction.
      3. If the number retrial are at the threshold, we don't attempt it again.
      
      Bug: 15150487
      Change-Id: I70720353e5803fccf4728c2aa798883ba75c61e5
      256b1b2a
  4. May 23, 2014
  5. May 22, 2014
  6. Feb 18, 2014
    • Jean Chalard's avatar
      Straighten out database cursors behavior. · b8ff8ca9
      Jean Chalard authored
      Some were never closed, other closed twice. This change
      makes all Cursor instances behave, having the #close()
      call in a finally{} clause, and puts the burden of closing
      the cursor squarely on the creator rather than in the
      called methods.
      There is however one exception that is beyond the scope
      of this change: UserDictionarySettings have a Cursor
      member, it's never closed, and fixing the problem is not
      obvious. This change adds a TODO for now.
      
      It's not very clear if this change actually helps with
      bug#12670151, but it may be related and it's a good
      think to do anyway.
      
      Bug: 12670151
      Change-Id: I87cc44387e7dee3da1488671b93a28d9d73f7dc0
      b8ff8ca9
  7. Mar 19, 2013
Loading