Straighten out database cursors behavior.
Some were never closed, other closed twice. This change makes all Cursor instances behave, having the #close() call in a finally{} clause, and puts the burden of closing the cursor squarely on the creator rather than in the called methods. There is however one exception that is beyond the scope of this change: UserDictionarySettings have a Cursor member, it's never closed, and fixing the problem is not obvious. This change adds a TODO for now. It's not very clear if this change actually helps with bug#12670151, but it may be related and it's a good think to do anyway. Bug: 12670151 Change-Id: I87cc44387e7dee3da1488671b93a28d9d73f7dc0
Showing
- java/src/com/android/inputmethod/dictionarypack/DictionaryProvider.java 4 additions, 2 deletions...ndroid/inputmethod/dictionarypack/DictionaryProvider.java
- java/src/com/android/inputmethod/dictionarypack/DictionarySettingsFragment.java 62 additions, 55 deletions...nputmethod/dictionarypack/DictionarySettingsFragment.java
- java/src/com/android/inputmethod/dictionarypack/MetadataDbHelper.java 39 additions, 19 deletions.../android/inputmethod/dictionarypack/MetadataDbHelper.java
- java/src/com/android/inputmethod/dictionarypack/MetadataHandler.java 9 additions, 8 deletions...m/android/inputmethod/dictionarypack/MetadataHandler.java
- java/src/com/android/inputmethod/latin/BinaryDictionaryFileDumper.java 12 additions, 11 deletions...android/inputmethod/latin/BinaryDictionaryFileDumper.java
- java/src/com/android/inputmethod/latin/ContactsBinaryDictionary.java 39 additions, 35 deletions...m/android/inputmethod/latin/ContactsBinaryDictionary.java
- java/src/com/android/inputmethod/latin/userdictionary/UserDictionaryList.java 11 additions, 6 deletions.../inputmethod/latin/userdictionary/UserDictionaryList.java
- java/src/com/android/inputmethod/latin/userdictionary/UserDictionarySettings.java 2 additions, 0 deletions...utmethod/latin/userdictionary/UserDictionarySettings.java
Loading
Please register or sign in to comment