Skip to content
Snippets Groups Projects
  1. Mar 20, 2015
  2. Nov 07, 2014
  3. Oct 21, 2014
    • Tadashi G. Takaoka's avatar
      Fix some compiler warnings · 5f00fe09
      Tadashi G. Takaoka authored
      This CL fixes the following compiler warnings.
      
      - Indirect access to static member
      - Access to a non-accessible member of an enclosing type
      - Parameter assignment
      - Method can be static
      - Local variable declaration hides another field or variable
      - Value of local variable is not used
      - Unused import
      - Unused private member
      - Unnecessary 'else' statement
      - Unnecessary declaration of throw exception
      - Redundant type arguments
      - Missing '@Override' annotation
      - Unused '@SuppressWarning' annotations
      
      Bug: 18003991
      Change-Id: Icfebe753e53a2cc621848f769d6a3d7ce501ebc7
      5f00fe09
  4. May 23, 2014
  5. Feb 18, 2014
    • Jean Chalard's avatar
      Straighten out database cursors behavior. · b8ff8ca9
      Jean Chalard authored
      Some were never closed, other closed twice. This change
      makes all Cursor instances behave, having the #close()
      call in a finally{} clause, and puts the burden of closing
      the cursor squarely on the creator rather than in the
      called methods.
      There is however one exception that is beyond the scope
      of this change: UserDictionarySettings have a Cursor
      member, it's never closed, and fixing the problem is not
      obvious. This change adds a TODO for now.
      
      It's not very clear if this change actually helps with
      bug#12670151, but it may be related and it's a good
      think to do anyway.
      
      Bug: 12670151
      Change-Id: I87cc44387e7dee3da1488671b93a28d9d73f7dc0
      b8ff8ca9
  6. Feb 14, 2014
  7. Jul 01, 2013
    • Jean Chalard's avatar
      Fix a bug where no URL means refresh never ends · 3f0858eb
      Jean Chalard authored
      This patch does two things:
      - If there is no URL to download new data from, then the
      Refresh button is not shown.
      - Even if for some reason refresh starts for a client for
      which there is no URL, loading correctly finishes.
      
      Bug: 9388602
      Change-Id: I3fd9214da50faa4b59d0bd3e775293dd34f07547
      3f0858eb
  8. May 31, 2013
  9. May 30, 2013
    • Jean Chalard's avatar
      Fix dictionary pack preference order. · b3d150aa
      Jean Chalard authored
      It turns out giving them in the right order is not enough, you
      also have to actually give them a numeric priority.
      
      Bug: 9165928
      Change-Id: I2ecff38f65b70746feeeeb0ed2cc86a586a35363
      b3d150aa
  10. May 10, 2013
    • Jean Chalard's avatar
      Reuse old preferences if possible. · a2ec5e83
      Jean Chalard authored
      This is an optimization. It also happens to work around what
      seems to be a framework bug in JB MR1 / MR1.1.
      
      Bug: 8771179
      Change-Id: I62cc7acdc8656d75f8a50c068c4e9d8c6ceb74a0
      a2ec5e83
  11. Apr 26, 2013
  12. Apr 24, 2013
    • Jean Chalard's avatar
      [PB4] Make a memory non-static · c017f18a
      Jean Chalard authored
      The life span of this object is actually the life span of the interface.
      It should not be static.
      Also, we'll have a few other things to store in there soon.
      
      Bug: 7600384
      Change-Id: I708019e9ee53653e83a1e52c8e76326c3e39bcf3
      c017f18a
  13. Apr 01, 2013
    • Jean Chalard's avatar
      Ask the client to make itself known when it's not · 76d5f512
      Jean Chalard authored
      Upon invoking the settings of the dictionary pack with an unknown
      client, we now launch an intent to ask the client to make itself known.
      This change also includes the code that receives this intent and
      acts upon it.
      
      Bug: 8492879
      Change-Id: I2c6496dea845646961ecafcf64e282cb93ee91dc
      76d5f512
  14. Mar 28, 2013
    • Jean Chalard's avatar
      Fix an NPE · 28d5f457
      Jean Chalard authored
      The code was passing the wrong parameter.
      
      Bug: 8492879
      Change-Id: I091d62ca29601e3807eed287c7bdad38bf43a502
      28d5f457
    • Jean Chalard's avatar
      Cleanup · dae90cfb
      Jean Chalard authored
      Seems there was an unclosed cursor :o
      
      Change-Id: I7616849ace5217d8c6f54465f7b3a634e3c14116
      dae90cfb
  15. Mar 19, 2013
Loading