Skip to content
Snippets Groups Projects
  1. Jan 10, 2014
    • Jean Chalard's avatar
      [IL54.5] Use the cursor pos estimate, not the last value · a224aafe
      Jean Chalard authored
      For edit tasks, the estimate is actually the right thing to use.
      This is really dangerous, but it will get rid of pretty much all
      race conditions.
      
      Change-Id: I2d5ca3ce45e32f1bd9c8b778421fd54b9c1f6f63
      a224aafe
    • Jean Chalard's avatar
      [IL54] Add a mirror method to fix the cursor pos estimate · ecf46df2
      Jean Chalard authored
      This just mirrors what InputLogic#tryFixLyingCursorPosition
      is doing. That method will go away in the next change.
      
      Change-Id: Ifa2827dbc1f1d20e2c642d6f2d23514a01ed9203
      ecf46df2
    • Jean Chalard's avatar
      [IL53] Fix a wrong test. · 6fbe83be
      Jean Chalard authored
      This test was intended only for cases without a selection, and as
      a safety net for cases where the app would pretend the cursor
      is at N but we can get P chars from the editor where P > N.
      
      When there is a selection, this is wrong. In the practice it works
      because these values are not used in this case, but it's still wrong.
      
      The case where P > N is arguable, but actually I see little reason
      to trust the getTextBeforeCursor() method more than the
      onUpdate selection method. Plus in the practice, I don't think
      we are aware of any app with this bug, and it's probably not a
      great idea to be too robust about this as it may encourage wrong
      values sent to onUpdateSelection.
      
      Change-Id: I42f2065d7aee668074e6b8e40b259da7e88e16e1
      6fbe83be
    • Jean Chalard's avatar
      Merge "Fix an NPE." · 958e4520
      Jean Chalard authored
      958e4520
    • Jean Chalard's avatar
      Fix an NPE. · e1de87ae
      Jean Chalard authored
      Bug: 12397228
      Change-Id: I7632931f0685fc8f0558946be66025b2bb2b5a3d
      e1de87ae
    • Jean Chalard's avatar
      Fix build. · 84a3047e
      Jean Chalard authored
      Change-Id: I6d0b572190080e58e95f72856ad39e72a49537b7
      84a3047e
  2. Jan 09, 2014
  3. Jan 08, 2014
Loading