- Jan 10, 2014
-
-
Jean Chalard authored
For edit tasks, the estimate is actually the right thing to use. This is really dangerous, but it will get rid of pretty much all race conditions. Change-Id: I2d5ca3ce45e32f1bd9c8b778421fd54b9c1f6f63
-
Jean Chalard authored
This just mirrors what InputLogic#tryFixLyingCursorPosition is doing. That method will go away in the next change. Change-Id: Ifa2827dbc1f1d20e2c642d6f2d23514a01ed9203
-
Jean Chalard authored
This test was intended only for cases without a selection, and as a safety net for cases where the app would pretend the cursor is at N but we can get P chars from the editor where P > N. When there is a selection, this is wrong. In the practice it works because these values are not used in this case, but it's still wrong. The case where P > N is arguable, but actually I see little reason to trust the getTextBeforeCursor() method more than the onUpdate selection method. Plus in the practice, I don't think we are aware of any app with this bug, and it's probably not a great idea to be too robust about this as it may encourage wrong values sent to onUpdateSelection. Change-Id: I42f2065d7aee668074e6b8e40b259da7e88e16e1
-
Jean Chalard authored
-
Jean Chalard authored
Bug: 12397228 Change-Id: I7632931f0685fc8f0558946be66025b2bb2b5a3d
-
Jean Chalard authored
Change-Id: I6d0b572190080e58e95f72856ad39e72a49537b7
-
- Jan 09, 2014
-
-
Tadashi G. Takaoka authored
This change must be checked in together with Iec437d6df0. Change-Id: Idf745b8870965f3bdf690de7ff3b22f83f6204bf
-
Tadashi G. Takaoka authored
Change-Id: I174c50f509ed6998b755e1a712e7f6c0f82f4425
-
Tadashi G. Takaoka authored
-
Tadashi G. Takaoka authored
-
Tadashi G. Takaoka authored
Change-Id: I0b06e8cc75a403f7061864c5b7f3f6a2cacd60eb
-
Tadashi G. Takaoka authored
Change-Id: Ic2663eaef38fbe7c5bd1fb3a81771e94c2d4de52
-
Keisuke Kuroyanagi authored
-
Keisuke Kuroyanagi authored
Change-Id: I63a20bb2e4b3c39495fade6cae3a14fdd11ca48c
-
Yohei Yukawa authored
Just a style fix to follow up the previous commit. BUG: 11439600 Change-Id: Ib7a4654627a6fc22d86f2097f86f001bd76426e9
-
Keisuke Kuroyanagi authored
-
Jean Chalard authored
-
Yohei Yukawa authored
-
Jean Chalard authored
Change-Id: I5cfa0d2fccc139bd6c45c5590a68c3e0c90534b8
-
Jean Chalard authored
-
Jean Chalard authored
Bug: 12453966 Change-Id: Idd65f732e2de0a7309e08315893c28cca63732c5
-
Yohei Yukawa authored
EmojiPalettesView triggers the haptic feedback at the timing of touch-up rather than touch-down. This patch set changes the timing to touch-up so that the UX on the EmojiPalettesView can be consistent with normal keyboard layouts. This patch set also fixes the missing haptic feedback from facemarks such as ":-)". Bug: 11439600 Change-Id: I22245946712bd1c36226786d6ff81e3b563f7ef7
-
- Jan 08, 2014
-
-
Baligh Uddin authored
Change-Id: Ia2d0f4528529df463307e1706cd4d7265b3958c1 Auto-generated-cl: translation import
-
Keisuke Kuroyanagi authored
Bug: 11736529 Change-Id: I27973212da7e922b2185dbb4febfb5bb4dfbdcbb
-
Keisuke Kuroyanagi authored
-
Keisuke Kuroyanagi authored
Bug: 8187060 Change-Id: I852a751d748f39512e62c9cd69748dfbe87b2151
-
Jean Chalard authored
This reverts commit 8bc42779. Change-Id: I34f509998afdb1a7c120fbfdb9f0a1b188224a4d
-
Jean Chalard authored
Don't use absolute cursor positions when making edits, this leads to race conditions. This is a bit ugly and will need to be fixed soon. Plans are underway to clean this up. Bug: 12390573 Change-Id: I69c09fc41b979880d0800c55a710e39373287cff
-
Jean Chalard authored
-
Jean Chalard authored
This is conflicting with later changes. Temporary revert for cherry-pick. This reverts commit 0b593ce8. Change-Id: Id53eadb023a950cfcca496c0cfbfe583c7ec7b8c
-
Jean Chalard authored
-
Jean Chalard authored
Conflicts prevent this to be cherry-picked. This reverts commit dd3d697a. Change-Id: Ib97fae2234633b4bb27d611f48a79060db9ab16f
-
Jean Chalard authored
-
Jean Chalard authored
-
Jean Chalard authored
Don't use absolute cursor positions when making edits, this leads to race conditions. This is a bit ugly and will need to be fixed soon. Plans are underway to clean this up. Bug: 12390573 Change-Id: Ib42d4149343c642b1b5c1937b424e8afdbd4cc1f
-
Jean Chalard authored
This reverts commit 38401272. Change-Id: I7f0d975ec9e18d94fe3505250360c2b79ccbe96d
-
Tadashi G. Takaoka authored
Change-Id: I5580250c91b29f93ed886b080ce33845b3b67ace
-
Tadashi G. Takaoka authored
Change-Id: I68862b98f228210f1d76fef4fd7454edbfd8e01d
-
Tadashi G. Takaoka authored
-
Tadashi G. Takaoka authored
InputPointers.getTime(int) has a validity check of time values. And the check is enabled when LatinImeLogger.sDBG is on. Such situation may occur while unit testing. This change ensure that time values are monotonic while unit testing. Change-Id: I9ff2cff2bcd253de0e8206dd3be964fe565170fa
-