Skip to content
Snippets Groups Projects
  1. Apr 22, 2024
  2. Apr 18, 2024
  3. Apr 11, 2024
  4. Apr 10, 2024
  5. Apr 09, 2024
  6. Mar 31, 2024
  7. Mar 30, 2024
  8. Mar 21, 2024
  9. Mar 13, 2024
  10. Mar 05, 2024
  11. Feb 20, 2024
  12. Jan 30, 2024
  13. Jan 28, 2024
  14. Jan 23, 2024
  15. Jan 22, 2024
  16. Jan 16, 2024
  17. Dec 19, 2023
  18. Dec 04, 2023
  19. Nov 28, 2023
  20. Nov 25, 2023
  21. Nov 14, 2023
  22. Nov 07, 2023
  23. Nov 06, 2023
  24. Oct 10, 2023
  25. Sep 28, 2023
  26. Jul 06, 2023
  27. Mar 19, 2023
    • Jing Mike's avatar
      Remove unused variables · 03eef94a
      Jing Mike authored
      
      Since some variables with module LatinIME are defined but not used,
      when compiled with build combination "sdk_pc_x86_64-userdebug" and
      build command "mmm packages/inputmethods/LatinIME", the following
      code lines will be reported that "variable 'XXX' set but not used".
      (should be similar for all the other build combinations)
      
      Repeated 10 times for each:
      terminal_position_lookup_table.cpp:74:9 removedEntryCount
      terminal_position_lookup_table.cpp:85:9 removedEntryCount
      proximity_info_state_utils.cpp:493:9 tempTime
      trie_map.cpp:56:9 unusedRegionSize
      suggestion_results.cpp:100:9 index
      
      Repeated 80+ times:
      proximity_info_utils.h:75:25 proximityChar
      
      With this patch we are removing some of the unused variables and
      putting the C++ 17 attribute [[maybe_unused]] to the others which
      are used for logging. Then all the related build warnings have been
      eliminated.
      
      Test: mmm packages/inputmethods/LatinIME, presubmit check.
      
      Change-Id: Ia66766322d6ae8a010b1cb55cc22993fbc6d012c
      Signed-off-by: default avatarJing Mike <jingyangliu@eswincomputing.com>
      03eef94a
  28. Jul 31, 2020
  29. Dec 11, 2018
  30. Sep 25, 2018
  31. Jul 26, 2018
    • Yohei Yukawa's avatar
      Fix lint warnings in LatinIME JNI code · 3d74fc73
      Yohei Yukawa authored
      This CL addresses compiler warnings when building libjni_latinime.so
      with NDK from Android Studio.
      
      There should be no behavior change.
      
      Bug: 110741422
      Bug: 110757803
      Test: tapas LatinIME LatinIMETests arm64 userdebug && make -j
      Change-Id: Icc711dd46511a167b1fd90028552def5b2f9941f
      3d74fc73
Loading