Skip to content
Snippets Groups Projects
  1. Dec 16, 2011
  2. Dec 15, 2011
    • Tadashi G. Takaoka's avatar
      Cleanup unused variables and parameters · 2ac5988f
      Tadashi G. Takaoka authored
      Change-Id: Iad756a7a775c93f3344c6962e7b3456ef8339490
      2ac5988f
    • Jean Chalard's avatar
      Group all input-related info into an inner class. · 27dff638
      Jean Chalard authored
      Currently, these variables hold the info about the composing
      word, or maybe some outdated info, and it's not very clear
      which it is. LatinIME is maintaining the freshness info in
      a separate boolean, and uses it throughout the code for many,
      many things, leading to much confusion.
      The idea in grouping this info is, it can be saved in another
      instance and restored later. It can be tested against to know
      whether there is actually outdated but kept info or not, and
      it should allow to straighten out what is actually currently
      being typed. Ultimately, it will eliminate the need for
      LatinIME to keep track of the status of the info in the
      word composer.
      
      Change-Id: I00e2c690f303f8320c9be35590a6df4583e9e456
      27dff638
    • Tadashi G. Takaoka's avatar
      Change visibility to avoid synthetic accessor method · 2d748062
      Tadashi G. Takaoka authored
      Change-Id: Ie93c7437fb9a3fe63adaa48c2d4a723f96c0a0e1
      2d748062
    • Tadashi G. Takaoka's avatar
      Fix auto correction spacebar LED · 23d27fef
      Tadashi G. Takaoka authored
      Change-Id: I4894d188d5612380cc9f8eec7cb72544e37fb2b0
      23d27fef
  3. Dec 14, 2011
  4. Dec 13, 2011
    • Jean Chalard's avatar
      Decouple member logic from control flow · 7b5bc1ff
      Jean Chalard authored
      This place is very confusing because a member variable with
      a consistent meaning is hijacked for the duration of a function
      to mean something else. This is in the way of easy-to-understand
      refactoring.
      
      Change-Id: If79bc771950d6bfc0ad5f0e9c51c7ef1dbb45b66
      7b5bc1ff
    • Jean Chalard's avatar
      Various mini-cleanups · f7d6517d
      Jean Chalard authored
      - Stop the word composer from escaping - take a page from the law
        of Demeter and only report what is actually needed.
      - Fix typos in comments.
      - Add a comment for a fishy processing.
      - Remove a useless local variable.
      
      Change-Id: I5fa78901cbb5483fc9683bfb7094f47244b85df6
      f7d6517d
    • Jean Chalard's avatar
      Remove the input connection sidework from handleCharacter · dafa7a8e
      Jean Chalard authored
      Change-Id: I3d376dfda3acd8864274390de3ff5752b18456e0
      dafa7a8e
    • Jean Chalard's avatar
      Move mBestWord to the word composer. · 117fc93f
      Jean Chalard authored
      mBestWord has a confusing name - it's actually an auto-correction.
      It's cleaner if it lives in the word composer because an
      auto-correction should be tied to a specific user input, and
      should be reset each time the user input changes to avoid
      race conditions.
      
      Change-Id: I718d29395bc747372067e6440e090c6a181994ae
      117fc93f
Loading