Skip to content
Snippets Groups Projects
  1. Apr 03, 2014
  2. Feb 18, 2014
    • Jean Chalard's avatar
      Straighten out database cursors behavior. · b8ff8ca9
      Jean Chalard authored
      Some were never closed, other closed twice. This change
      makes all Cursor instances behave, having the #close()
      call in a finally{} clause, and puts the burden of closing
      the cursor squarely on the creator rather than in the
      called methods.
      There is however one exception that is beyond the scope
      of this change: UserDictionarySettings have a Cursor
      member, it's never closed, and fixing the problem is not
      obvious. This change adds a TODO for now.
      
      It's not very clear if this change actually helps with
      bug#12670151, but it may be related and it's a good
      think to do anyway.
      
      Bug: 12670151
      Change-Id: I87cc44387e7dee3da1488671b93a28d9d73f7dc0
      b8ff8ca9
    • Jean Chalard's avatar
      Avoid crashing when the Content URL is not found. · 9967f0a1
      Jean Chalard authored
      I'm not sure when this can happen, but it seems it does
      at least on older versions of the platform. Let's avoid
      crashing.
      
      Bug: 11618402
      Change-Id: If730b5bd8f20e0f60b884eab5900099116afc5f0
      9967f0a1
  3. Feb 17, 2014
  4. Feb 14, 2014
  5. Jan 09, 2014
  6. Oct 09, 2013
  7. Oct 02, 2013
  8. Jul 31, 2013
  9. Jul 16, 2013
    • Jean Chalard's avatar
      Serialize commands sent to a separate threads · 6a7a5698
      Jean Chalard authored
      Bug: 9715797
      Change-Id: I1eda4d2f0056f70cfb8a92d658e0875706efc170
      6a7a5698
    • Jean Chalard's avatar
      Fix a bug with bad view reuse. · 6912342a
      Jean Chalard authored
      There are many ways to fix this problem but this is the most
      direct way. Removing a view from the cache when any animation
      is started will ensure it won't be used again, and will be garbage
      collected when it's possible. Since views are created on demand
      anyway, a new one will just get created when needed, and that's
      it.
      
      Bug: 9400128
      Change-Id: I4945d2859d642e79694d51ae90cf4f5bde9a5f1d
      6912342a
  10. Jul 11, 2013
  11. Jul 05, 2013
  12. Jul 01, 2013
    • Jean Chalard's avatar
      Fix a bug where no URL means refresh never ends · 3f0858eb
      Jean Chalard authored
      This patch does two things:
      - If there is no URL to download new data from, then the
      Refresh button is not shown.
      - Even if for some reason refresh starts for a client for
      which there is no URL, loading correctly finishes.
      
      Bug: 9388602
      Change-Id: I3fd9214da50faa4b59d0bd3e775293dd34f07547
      3f0858eb
  13. Jun 25, 2013
  14. Jun 24, 2013
  15. Jun 11, 2013
    • Kurt Partridge's avatar
      Make intents unique to AOSP · 2c1796c2
      Kurt Partridge authored
      This is to avoid confusion if multiple IMEs are installed with
      dictionary pack components
      
      Change-Id: Ibc91951e4fdd5db13f681e4cb06197da98527bbc
      2c1796c2
  16. Jun 07, 2013
    • Jean Chalard's avatar
      Fix an illegal argument exception · 0ad14896
      Jean Chalard authored
      This is a bit of a shot in the dark, as I really don't see how this
      can happen, but this should fix it in the correct way no matter
      how it's actually happening.
      
      Bug: 9301836
      Change-Id: I472865b7a78883942c9fd46773238c23788674f8
      0ad14896
  17. May 31, 2013
  18. May 30, 2013
  19. May 29, 2013
    • Jean Chalard's avatar
      Rub some butter on dictionary list scrolling. · 2b34b4ea
      Jean Chalard authored
      The default implementation for preferences refuses to
      cache the views for custom preferences at all. We can
      do it, but the system won't do it for us, so this does it.
      This makes the screen scrolling smooth again.
      
      Incidentally it also fixes the bug where the button may
      not animate on the first element.
      
      Bug: 8882722
      Bug: 8883108
      Change-Id: I9b2306ac4bf93761a808ebfee3477a65f017cddf
      2b34b4ea
  20. May 24, 2013
  21. May 10, 2013
    • Jean Chalard's avatar
      Reuse old preferences if possible. · a2ec5e83
      Jean Chalard authored
      This is an optimization. It also happens to work around what
      seems to be a framework bug in JB MR1 / MR1.1.
      
      Bug: 8771179
      Change-Id: I62cc7acdc8656d75f8a50c068c4e9d8c6ceb74a0
      a2ec5e83
  22. Apr 30, 2013
  23. Apr 26, 2013
  24. Apr 25, 2013
    • Jean Chalard's avatar
      Work around a bug in older DownloadManager versions. · 43590149
      Jean Chalard authored
      This adds a number to the extension.
      
      Note that for DownloadManager to keep this, the server
      needs to send it a mime type it does not recognize. Right
      now, it does not recognize application/json so it's okay,
      but we'd do well to remove the content/type header from
      the server to prevent problems.
      
      Bug: 8467516
      Change-Id: Ic484f66ac3f67c36f59f2c0bcb8c7fdeb6e8590d
      43590149
    • Jean Chalard's avatar
      [PB8] Add an animation upon status change. · 513c63e8
      Jean Chalard authored
      Bug: 7600384
      Change-Id: If5efb9357075193d10255187008e870e2933bdb8
      513c63e8
    • Jean Chalard's avatar
      [PB7] Export animation code out of the preference · 2d72590c
      Jean Chalard authored
      Bug: 7600384
      Change-Id: I8009b31d96646acd667db410b94e969daea91d52
      2d72590c
    • Jean Chalard's avatar
      [PB6] Encapsulate the buttons into a view · 2cf450f4
      Jean Chalard authored
      Handling buttons directly in the preference causes large
      problems of code readability and interface.  It's better to
      have a class to manage the buttons and their animations
      separately. This is feature-equivalent, and mostly
      delegates stuff for now.
      
      Bug: 7600384
      Change-Id: Ia8da0ec68ffac84fc1d65e1760539a87a73fa776
      2cf450f4
  25. Apr 24, 2013
    • Jean Chalard's avatar
      [PB5] Store state in a more convenient manner · cadea5d2
      Jean Chalard authored
      This is more readable and will help with animations going forward.
      
      Bug: 7600384
      Change-Id: I255598d860d1e451fef106b00da63c282fe95f95
      cadea5d2
    • Jean Chalard's avatar
      [PB4] Make a memory non-static · c017f18a
      Jean Chalard authored
      The life span of this object is actually the life span of the interface.
      It should not be static.
      Also, we'll have a few other things to store in there soon.
      
      Bug: 7600384
      Change-Id: I708019e9ee53653e83a1e52c8e76326c3e39bcf3
      c017f18a
    • Jean Chalard's avatar
      [PB3] Simplify storage · 43e8639e
      Jean Chalard authored
      By looping through children, there is no need to remember the
      last index.
      
      Bug: 7600384
      Change-Id: I8b42b0aa38874ee494c6c4ecc09194a1d3c16922
      43e8639e
Loading