Skip to content
Snippets Groups Projects
  1. Feb 21, 2015
  2. May 23, 2014
  3. May 22, 2014
  4. Feb 18, 2014
    • Jean Chalard's avatar
      Straighten out database cursors behavior. · b8ff8ca9
      Jean Chalard authored
      Some were never closed, other closed twice. This change
      makes all Cursor instances behave, having the #close()
      call in a finally{} clause, and puts the burden of closing
      the cursor squarely on the creator rather than in the
      called methods.
      There is however one exception that is beyond the scope
      of this change: UserDictionarySettings have a Cursor
      member, it's never closed, and fixing the problem is not
      obvious. This change adds a TODO for now.
      
      It's not very clear if this change actually helps with
      bug#12670151, but it may be related and it's a good
      think to do anyway.
      
      Bug: 12670151
      Change-Id: I87cc44387e7dee3da1488671b93a28d9d73f7dc0
      b8ff8ca9
  5. Dec 13, 2013
    • Ken Wakasa's avatar
      Reset to 9bd6dac4 · 2fa3693c
      Ken Wakasa authored
      The bulk merge from -bayo to klp-dev should not have been merged to master.
      
      Change-Id: I527a03a76f5247e4939a672f27c314dc11cbb854
      2fa3693c
  6. Dec 04, 2013
    • Jean Chalard's avatar
      [RF1] Remove files that don't match the expected format, step 1 · 5e80e699
      Jean Chalard authored
      This implements the skeleton implementation, and enables a
      fallback implementation in the case the file is coming from the
      dictionary provider.
      - A better scheme should be used for provider-supplied dicts.
      - This does not implement the solution for device-generated
          dicts yet. This will come in a future change.
      - This does not implement the checking process on the native
          side yet. This will come in a future change.
      
      Bug: 11281748
      Change-Id: Ifa6e237d19dfbffe503e3674915480ea867b0ddf
      5e80e699
  7. Oct 21, 2013
  8. Jul 22, 2013
  9. Jul 05, 2013
    • Jean Chalard's avatar
      Add a trace. · cb13d11c
      Jean Chalard authored
      Emit a trace when a new dictionary is copied to LatinIME
      successfully, not just when it fails. That will help diagnosing
      some problems by being able to ensure this step succeeded
      looking at the log.
      This does not happen often (like, maybe 3 times at device
      activation, and once every few weeks afterwards), so I think
      the extra line in the log is more than acceptable.
      
      Change-Id: I1674bc22d950a7be801076c5aa7e8bbebccab14b
      cb13d11c
  10. Jun 28, 2013
  11. Jun 24, 2013
  12. May 30, 2013
  13. Apr 30, 2013
  14. Apr 23, 2013
  15. Apr 11, 2013
  16. Apr 01, 2013
    • Jean Chalard's avatar
      Ask the client to make itself known when it's not · 76d5f512
      Jean Chalard authored
      Upon invoking the settings of the dictionary pack with an unknown
      client, we now launch an intent to ask the client to make itself known.
      This change also includes the code that receives this intent and
      acts upon it.
      
      Bug: 8492879
      Change-Id: I2c6496dea845646961ecafcf64e282cb93ee91dc
      76d5f512
  17. Mar 19, 2013
  18. Feb 15, 2013
  19. Feb 14, 2013
  20. Feb 13, 2013
  21. Feb 12, 2013
  22. Feb 11, 2013
  23. Feb 07, 2013
  24. Feb 06, 2013
  25. Feb 02, 2013
  26. Jan 29, 2013
    • Jean Chalard's avatar
      Refactoring · d515f134
      Jean Chalard authored
      This creates a new DictionaryInfoUtils class and moves a bunch
      of static methods there for later usage.
      
      Change-Id: Iecb0643e6029a7be36bd6cb36aa918c40e6d8c6a
      d515f134
  27. Jan 21, 2013
  28. Nov 13, 2012
    • Jean Chalard's avatar
      Make sure all FDs are correctly closed. · 5c32b6da
      Jean Chalard authored
      In this kind of series of calls, it's possible that an outer call to a
      constructor fails, but the inner succeeded.
      Example:
      try {
          is = new A(new B());
      } finally {
          if (null != is) is.close();
      }
      In this case, if new B() succeeds but new A() throws an
      exception, is stays null and the intermediate object is never
      closed. This is what was happening in this instance.
      
      Bug: 7377336
      Change-Id: I3fae9fec1135244982fcf5098c76d93f3e0f2add
      5c32b6da
  29. Oct 23, 2012
    • Jean Chalard's avatar
      Fix the build. · 1e0cc86b
      Jean Chalard authored
      It seems this change snuck out from a previous version.
      
      Change-Id: I9c33d51273732b1d55bfd60f0957184c86fa88ab
      1e0cc86b
    • Jean Chalard's avatar
      Add reader and writer for the combined dict format. · 9bb4eebf
      Jean Chalard authored
      This introduces a new textual format for the dictionary that combines
      words, bigrams and shortcuts to avoid complexity. It is also extensible
      to n-grams to fool-prof for the future, and easier to read than XML.
      
      Bug: 7388540
      Change-Id: I942bbad51bd0c905a5a54c278667563fd6dd66ec
      9bb4eebf
  30. Oct 12, 2012
  31. Oct 11, 2012
  32. Oct 04, 2012
  33. Sep 27, 2012
Loading