Skip to content
Snippets Groups Projects
  1. Dec 14, 2011
  2. Dec 13, 2011
    • Jean Chalard's avatar
      Decouple member logic from control flow · 7b5bc1ff
      Jean Chalard authored
      This place is very confusing because a member variable with
      a consistent meaning is hijacked for the duration of a function
      to mean something else. This is in the way of easy-to-understand
      refactoring.
      
      Change-Id: If79bc771950d6bfc0ad5f0e9c51c7ef1dbb45b66
      7b5bc1ff
    • Jean Chalard's avatar
      Various mini-cleanups · f7d6517d
      Jean Chalard authored
      - Stop the word composer from escaping - take a page from the law
        of Demeter and only report what is actually needed.
      - Fix typos in comments.
      - Add a comment for a fishy processing.
      - Remove a useless local variable.
      
      Change-Id: I5fa78901cbb5483fc9683bfb7094f47244b85df6
      f7d6517d
    • Jean Chalard's avatar
      Remove the input connection sidework from handleCharacter · dafa7a8e
      Jean Chalard authored
      Change-Id: I3d376dfda3acd8864274390de3ff5752b18456e0
      dafa7a8e
    • Jean Chalard's avatar
      Move mBestWord to the word composer. · 117fc93f
      Jean Chalard authored
      mBestWord has a confusing name - it's actually an auto-correction.
      It's cleaner if it lives in the word composer because an
      auto-correction should be tied to a specific user input, and
      should be reset each time the user input changes to avoid
      race conditions.
      
      Change-Id: I718d29395bc747372067e6440e090c6a181994ae
      117fc93f
    • Tadashi G. Takaoka's avatar
      Introduce KeyboardSet to hold related KeyboardIds · c42f285b
      Tadashi G. Takaoka authored
      This change moves
        * KeyboardSwitcher.getKeyboardId to KeyboardSet.<init> and
          KeyboardSet.getKeyboardId.
        * KeyboardSwitcher.getF2KeyMode to KeyboardSet.
      This is the first step to get rid of shift state from Keyboard.
      
      Bug: 5002108
      Bug: 5679585
      Change-Id: I2a5a97e5e89277bc606916d45c1afbc8d105d773
      c42f285b
    • Jean Chalard's avatar
      Consolidate underlining code under one function. · 77d59b06
      Jean Chalard authored
      Change-Id: I4393ff1ec28a6b3118d1344dd6d82d04899dea42
      77d59b06
    • Jean Chalard's avatar
      Tighten conditions for space-related cancelling · 8ad40134
      Jean Chalard authored
      Instead of ignoring silently a found bug, throw an exception.
      
      Change-Id: I0aa96d0cab022b6a5e7cffe8a592dcc443c3c7a8
      8ad40134
    • satok's avatar
      Extract the jni library name · ba526e31
      satok authored
      Change-Id: Icc58ccea1178d9f35f5be0dceebab67bbb965b7f
      ba526e31
    • Tadashi G. Takaoka's avatar
      Remove KeyboardSwitcher.updateShiftLockState method · 34f18203
      Tadashi G. Takaoka authored
      Change-Id: I032fc50a62a573ba4258530e695c8c88467783c6
      34f18203
    • Jean Chalard's avatar
      Remove a useless return · 14cb8448
      Jean Chalard authored
      Change-Id: Iefe10e94e2d88171387351a5b6cab52e281d0f76
      14cb8448
    • Jean Chalard's avatar
      Simplification · 29390639
      Jean Chalard authored
      Both tests have the same meaning. They should be merged.
      Also, if "deleteLast()" deletes more than one char (which
      never happens in the current implementation, but it's not
      guaranteed), the new code is more correct.
      
      Change-Id: I216df7cd45f4a7d76d1d5d6aa7f8d7f9a6e35ea3
      29390639
    • Jean Chalard's avatar
      Refactoring · d2c69c7d
      Jean Chalard authored
      If mHasUncommittedTypedChars is true, then
      mWordSavedForAutoCorrectCancellation must always be null, and
      spaceState must always be SPACE_STATE_NONE.
      Hence, this change is supposed to be very no-op.
      
      Change-Id: I2716f7372d996cc4dec40a4b7ac1ee7f5f4afe91
      d2c69c7d
    • Jean Chalard's avatar
      Refactor + small bugfix · 2245c3b5
      Jean Chalard authored
      postUpdateShiftKeyState used to be called also when
      mEnteredText is not null => this is a bugfix.
      The rest does not change the logic, as posting a message can
      be done anywhere within the function with no impact.
      
      Change-Id: I7888797c0778702d64f96701e35b611a55a6a259
      2245c3b5
    • Jean Chalard's avatar
      Refactoring · a2a85d45
      Jean Chalard authored
      Change-Id: I57b2232f7fde32df5f6e1925aad1df988def34f9
      a2a85d45
    • Tadashi G. Takaoka's avatar
      Remove current keyboard id variable · dc52e7c6
      Tadashi G. Takaoka authored
      Change-Id: Iec19af98209e1ea8ecd176d3be04d628d4b38950
      dc52e7c6
  3. Dec 12, 2011
Loading