- Dec 14, 2011
-
-
Tadashi G. Takaoka authored
Bug: 5759092 Change-Id: I328e2043075ce5d0d0285febc4a9b7356702c250
-
Tadashi G. Takaoka authored
Change-Id: Ie288272bc75832db7d743262c4c4fbe73b6dca04
-
Tadashi G. Takaoka authored
Change-Id: I101b6927d43e86b3c636c1a527e181df8af9c73e
-
Tadashi G. Takaoka authored
Change-Id: I70919ff30622afa1d8c29ca45589fa617f2c1f0e
-
Jean Chalard authored
Change-Id: I724df0be7ac07ffb9f1f4974175aed5a2606221b
-
Tadashi G. Takaoka authored
Change-Id: I5fd8f6ac0f42152fb0e2aaaedc6092f6d82fe677
-
Jean Chalard authored
Also rename the function to reflect better the behavior. An upcoming change will clean up the remnants Change-Id: I19bdf0d9e95f62ee749e1f64fe17132c4a5ef0bc
-
Jean Chalard authored
Change-Id: Ibea64133f200dce80034c641d4798b62843a2512
-
Tadashi G. Takaoka authored
Bug: 5759096 Change-Id: Ie1f1800d0f32ac0938715c79974e0f382c9c3d27
-
Jean Chalard authored
Small simplification of the code. Change-Id: I1f67ae529bbb2c9316bf5e083d367c57040ea22c
-
Tadashi G. Takaoka authored
Change-Id: Ie0d1204e94fcdf9d578974256bf2ae3e87797f13
-
Tadashi G. Takaoka authored
This change introduces KeyboardSet and SubKeyboard XML definitions to represent a set of keyboard layouts. Bug: 5002108 Bug: 5679585 Change-Id: Ib6c8d5936187381bb6725c9fe574e93871c01a86
-
Jean Chalard authored
Upon autocorrection, there is visual feedback in the text view that quickly flashes the background of the text that just changed. This fixes a race condition that happens upon autocorrection when typing fast, and that results in flashing one character too far left (typically, the flashing area includes the whitespace before the corrected word and not the last character of the corrected word). This happens because the call to commitCorrection may happen before or after the IPC sent by sendKeyChar, but the arguments are fit only for the case where it arrives first. Change-Id: I9b5442a665aad5a9bc66cd49228075b9056b37fa
-
Tadashi G. Takaoka authored
Bug: 5722703 Change-Id: I56bcf6ccde82b4176093de4f197a8736b0cc8c10
-
- Dec 13, 2011
-
-
Jean Chalard authored
This place is very confusing because a member variable with a consistent meaning is hijacked for the duration of a function to mean something else. This is in the way of easy-to-understand refactoring. Change-Id: If79bc771950d6bfc0ad5f0e9c51c7ef1dbb45b66
-
Jean Chalard authored
- Stop the word composer from escaping - take a page from the law of Demeter and only report what is actually needed. - Fix typos in comments. - Add a comment for a fishy processing. - Remove a useless local variable. Change-Id: I5fa78901cbb5483fc9683bfb7094f47244b85df6
-
Jean Chalard authored
Change-Id: I3d376dfda3acd8864274390de3ff5752b18456e0
-
Jean Chalard authored
mBestWord has a confusing name - it's actually an auto-correction. It's cleaner if it lives in the word composer because an auto-correction should be tied to a specific user input, and should be reset each time the user input changes to avoid race conditions. Change-Id: I718d29395bc747372067e6440e090c6a181994ae
-
Tadashi G. Takaoka authored
This change moves * KeyboardSwitcher.getKeyboardId to KeyboardSet.<init> and KeyboardSet.getKeyboardId. * KeyboardSwitcher.getF2KeyMode to KeyboardSet. This is the first step to get rid of shift state from Keyboard. Bug: 5002108 Bug: 5679585 Change-Id: I2a5a97e5e89277bc606916d45c1afbc8d105d773
-
Jean Chalard authored
Change-Id: I4393ff1ec28a6b3118d1344dd6d82d04899dea42
-
Jean Chalard authored
Instead of ignoring silently a found bug, throw an exception. Change-Id: I0aa96d0cab022b6a5e7cffe8a592dcc443c3c7a8
-
satok authored
Change-Id: Icc58ccea1178d9f35f5be0dceebab67bbb965b7f
-
Tadashi G. Takaoka authored
Change-Id: I032fc50a62a573ba4258530e695c8c88467783c6
-
Jean Chalard authored
Change-Id: Iefe10e94e2d88171387351a5b6cab52e281d0f76
-
Jean Chalard authored
Both tests have the same meaning. They should be merged. Also, if "deleteLast()" deletes more than one char (which never happens in the current implementation, but it's not guaranteed), the new code is more correct. Change-Id: I216df7cd45f4a7d76d1d5d6aa7f8d7f9a6e35ea3
-
Jean Chalard authored
If mHasUncommittedTypedChars is true, then mWordSavedForAutoCorrectCancellation must always be null, and spaceState must always be SPACE_STATE_NONE. Hence, this change is supposed to be very no-op. Change-Id: I2716f7372d996cc4dec40a4b7ac1ee7f5f4afe91
-
Jean Chalard authored
postUpdateShiftKeyState used to be called also when mEnteredText is not null => this is a bugfix. The rest does not change the logic, as posting a message can be done anywhere within the function with no impact. Change-Id: I7888797c0778702d64f96701e35b611a55a6a259
-
Jean Chalard authored
Change-Id: I57b2232f7fde32df5f6e1925aad1df988def34f9
-
Tadashi G. Takaoka authored
Change-Id: Iec19af98209e1ea8ecd176d3be04d628d4b38950
-
- Dec 12, 2011
-
-
Jean Chalard authored
If there are no uncommitted chars, we shouldn't enter any of the tests that follow. We didn't use to, but a change today made it possible - it should not happen. There is no point in doing the rest of the tests, they are sure to fail. Change-Id: I580dd104aff3585de72a93b38989bfd9713f615b
-
Jean Chalard authored
Change-Id: I1a775cbf90dca301e1e6b596ddac64fdbc023199
-
Jean Chalard authored
This can be just read when it's needed. Change-Id: I00753fe55645c244db5d4a96e7fdb8f5325475d9
-
Jean Chalard authored
Change-Id: I1331ad6dec3a9d64a77e314f8a1f4c29282df31b
-
Jean Chalard authored
Today is a happy day Change-Id: I3ef484bd258d5a59815bfcb0bd35ea3606b32430
-
Jean Chalard authored
Change-Id: Ib98eea9e791e426435cfdfd0c9ab3ed9061664aa
-
Tadashi G. Takaoka authored
Bug: 5743584 Change-Id: I821b837a2078afb64b460191c98b28f7733cf2c1
-
Jean Chalard authored
Change-Id: Iea5ce5cfc05bad8b1d9085438e90147bd54b7e9c
-
Jean Chalard authored
This also includes a new memorized string with simpler logic that will allow to remove other members Change-Id: I0b97243084902e68fcb835b6163c86fef8190ebc
-
Tadashi G. Takaoka authored
Bug: 5708602 Change-Id: I1a8a9f4320948bb500a96df8773b0bfa1a1d4167
-
Tadashi G. Takaoka authored
Change-Id: I9cde21fbb45c1e5f1a568bb97b1b1a76524f4bf2
-