Skip to content
Snippets Groups Projects
  1. Sep 21, 2024
  2. Sep 19, 2024
  3. Sep 02, 2024
  4. Aug 31, 2024
  5. Aug 24, 2024
    • Aleksandras Kostarevas's avatar
      Refactor layout definition system · 2e883781
      Aleksandras Kostarevas authored
      Layouts are now defined in yaml files at latinime/java/assets/layouts. The new system makes simple layouts significantly easier to add.
      
      Many layouts still need to be ported over to the new system and some bugs still remain. The old layout system and XML layouts will need to be removed.
      2e883781
  6. Jun 21, 2024
  7. Apr 12, 2024
  8. Apr 11, 2024
  9. Mar 07, 2024
  10. Jan 17, 2024
  11. Jan 15, 2024
  12. Aug 15, 2023
  13. Aug 14, 2023
  14. Jul 06, 2023
  15. Oct 17, 2022
    • Cole Faust's avatar
      Fix errorprone warnings that should be errors · 91cb9a6a
      Cole Faust authored
      This commit is part of a large scale change to fix errorprone
      errors that have been downgraded to warnings in the android
      source tree, so that they can be promoted to errors again.
      The full list of changes include the following, but not all
      will be present in any one individual commit:
      
      BadAnnotationImplementation
      BadShiftAmount
      BanJNDI
      BoxedPrimitiveEquality
      ComparableType
      ComplexBooleanConstant
      CollectionToArraySafeParameter
      ConditionalExpressionNumericPromotion
      DangerousLiteralNull
      DoubleBraceInitialization
      DurationFrom
      DurationTemporalUnit
      EmptyTopLevelDeclaration
      EqualsNull
      EqualsReference
      FormatString
      FromTemporalAccessor
      GetClassOnAnnotation
      GetClassOnClass
      HashtableContains
      IdentityBinaryExpression
      IdentityHashMapBoxing
      InstantTemporalUnit
      InvalidTimeZoneID
      InvalidZoneId
      IsInstanceIncompatibleType
      JUnitParameterMethodNotFound
      LockOnBoxedPrimitive
      MathRoundIntLong
      MislabeledAndroidString
      MisusedDayOfYear
      MissingSuperCall
      MisusedWeekYear
      ModifyingCollectionWithItself
      NoCanIgnoreReturnValueOnClasses
      NonRuntimeAnnotation
      NullableOnContainingClass
      NullTernary
      OverridesJavaxInjectableMethod
      ParcelableCreator
      PeriodFrom
      PreconditionsInvalidPlaceholder
      ProtoBuilderReturnValueIgnored
      ProtoFieldNullComparison
      RandomModInteger
      RectIntersectReturnValueIgnored
      ReturnValueIgnored
      SelfAssignment
      SelfComparison
      SelfEquals
      SizeGreaterThanOrEqualsZero
      StringBuilderInitWithChar
      TreeToString
      TryFailThrowable
      UnnecessaryCheckNotNull
      UnusedCollectionModifiedInPlace
      XorPower
      
      See https://errorprone.info/bugpatterns for more
      information on the checks.
      
      Bug: 253827323
      Test: m RUN_ERROR_PRONE=true javac-check
      Change-Id: I454a105ae82484a2d19aff1808e8d9dd55ba64f4
      91cb9a6a
  16. Jun 15, 2021
    • Yohei Yukawa's avatar
      Bump targetSdkVersion to "30" · 07ce283a
      Yohei Yukawa authored
      With this CL, versionCode, targetSdkVersion and minSdkVersion will be
      bumped/set as follows:
      
             versionCode: 28 -> 30
        targetSdkVersion: 28 -> 30
           minSdkVersion: 21
      
      As far as we know, there should be no user-visible behavior change on
      supported OS versions.
      
      Fix: 189558760
      Test: manually verified that LatinIME still is functional
      Change-Id: I3a7deb452960b370f5290f3d1bac9c79fe935303
      Merged-In: I4bf7588c62fb77bf78d4afcb665e9bfbbef53966
      (cherry picked from commit 360052f3)
      07ce283a
    • Yohei Yukawa's avatar
      Bump targetSdkVersion to "30" · 360052f3
      Yohei Yukawa authored
      With this CL, versionCode, targetSdkVersion and minSdkVersion will be
      bumped/set as follows:
      
             versionCode: 28 -> 30
        targetSdkVersion: 28 -> 30
           minSdkVersion: 21
      
      As far as we know, there should be no user-visible behavior change on
      supported OS versions.
      
      Fix: 189558760
      Test: manually verified that LatinIME still is functional
      Change-Id: I4bf7588c62fb77bf78d4afcb665e9bfbbef53966
      360052f3
  17. Feb 17, 2021
    • Bob Badour's avatar
      [LSC] Add LOCAL_LICENSE_KINDS to packages/inputmethods/LatinIME · f3d9532a
      Bob Badour authored
      Added SPDX-license-identifier-Apache-2.0 to:
        Android.bp
        common/Android.bp
        java/Android.bp
        native/dicttoolkit/Android.bp
        native/jni/Android.bp
        tests/Android.bp
        tools/EditTextVariations/Android.bp
        tools/dicttool/Android.bp
        tools/make-keyboard-text/Android.bp
      
      Bug: 68860345
      Bug: 151177513
      Bug: 151953481
      
      Test: m all
      
      Exempt-From-Owner-Approval: janitorial work
      Change-Id: I440008bffac5c97a2497970af377a9d03262b6d8
      f3d9532a
  18. Jul 31, 2020
  19. Dec 14, 2018
  20. Nov 13, 2018
    • Yohei Yukawa's avatar
      Bump targetSdkVersion to "28" and minSdkVersion to "21" · 04573e30
      Yohei Yukawa authored
      With this CL, targetSdkVersion and minSdkVersion will be bumped as
      follows:
      
        targetSdkVersion: 23 -> 28
           minSdkVersion: 14 -> 21
      
      As far as we know, there should be no user-visible behavior change on
      supported OS versions.
      
      Fix: 119489995
      Test: manually verified that LatinIME still is functional
      Change-Id: I68f1545778b0c8b44c6850f22f3f5ca25bdb6de0
      04573e30
    • Yohei Yukawa's avatar
      Re-introduce <uses-sdk> to the main AndroidManifest.xml · 69ceec90
      Yohei Yukawa authored
      This logically reverts my previous CL [1], which moved <uses-sdk />
      from AndroidManifest.xml to AndroidManifest_SdkVersion.xml, which was
      later accidentally removed during Android.bp migration [2].
      
      Since gradle support in LatinIME is still experimental and not used in
      official build, it is OK to keep it broken for a while.  A more
      important problem right now is letting LatinIME target API 28.
      
      As the first step to let LatinIME target SDK 28, <uses-sdk> will be
      revived in AndroidManifest.xml
      
       [1]: Ib673bca5a31b2f95329c9310a127ec0701bd8fdc
            9cd42f39
       [2]: Ib8867d3b74f09fc1d9f95adc9a49a81ac0f7f054
            22ebec6e
      
      Bug: 110741422
      Bug: 119489995
      Test: manually verified that LatinIME still is functional
      Change-Id: I8b04caa56fe2431c07e076fb6f97c560d5da8838
      69ceec90
  21. Nov 01, 2018
    • Dan Willemsen's avatar
      Convert to Android.bp · a23407bf
      Dan Willemsen authored
      See build/soong/README.md for more information.
      
      Test: cd packages/inputmethods/LatinIME; mma
      Change-Id: Ib8867d3b74f09fc1d9f95adc9a49a81ac0f7f054
      Merged-In: Ib8867d3b74f09fc1d9f95adc9a49a81ac0f7f054
      a23407bf
    • Dan Willemsen's avatar
      Convert to Android.bp · 22ebec6e
      Dan Willemsen authored
      See build/soong/README.md for more information.
      
      Test: cd packages/inputmethods/LatinIME; mma
      Change-Id: Ib8867d3b74f09fc1d9f95adc9a49a81ac0f7f054
      22ebec6e
  22. Oct 29, 2018
    • Tadashi G. Takaoka's avatar
      Fix dicttool build · 6a1b3735
      Tadashi G. Takaoka authored
      This CL partially reverts
        - Id88b02b74bdfe4ca05b08181ceb6b34d5652fc0c
        - I05c7d8429e8d9a26139456763c77997340fea8c2
      And followup (remove shortcut support)
        - I73b7dc008a5acaf75a31a36a2d332b5afabd82d0
      
      Bug: 28255684
      Test: make -j10 dicttool_aosp
      Change-Id: I2e01ed86b9517a1141aee35ea6d8ef39258981d1
      6a1b3735
  23. Aug 13, 2018
    • Yohei Yukawa's avatar
      Add missing test runner annotations · d6525756
      Yohei Yukawa authored
      These tests are supposed to run even withotu @RunWith annocation, but
      for better consistency we should have it there.
      
      Bug: 110805255
      Test: verified as follows. No new test failures.
          tapas adb LatinIME LatinIMETests arm64 userdebug && \
          DISABLE_PROGUARD=true make -j LatinIME && \
          adb install -r $OUT/system/app/LatinIME/LatinIME.apk && \
          atest LatinIMETests:com.android.inputmethod.latin.ContactsDictionaryUtilsTest && \
          atest LatinIMETests:com.android.inputmethod.latin.ContactsContentObserverTest
      Change-Id: I5c115d57b2ad41642f5f9b09b0c0d8f8c12480b0
      d6525756
  24. Jul 26, 2018
    • Yohei Yukawa's avatar
      Specify version code in AndroidManifest.xml · 41f89ae8
      Yohei Yukawa authored
      This should be the most convenient way for both make build and Android
      Studio build to share the same version code.
      
      Bug: 110741422
      Test: tapas LatinIME LatinIMETests arm64 userdebug && make -j
      Change-Id: I35f850c392553b2640a4c3c7398441ac28e90eca
      41f89ae8
  25. Jul 25, 2018
    • Yohei Yukawa's avatar
      Move <uses-sdk /> to a differnt XML · 9cd42f39
      Yohei Yukawa authored
      Basically Android Studio does want targetSdkVersion to be specified in
      build.gradle rather than AndroidManifest.xml.  To make both make build
      and Android Studio build happy, this CL splits <uses-sdk /> from the
      main AndroidManifest.xml to a different file and let them merged in
      make build.
      
      There should be no behavior change.
      
      Bug: 110741422
      Test: Manually verified that there is no difference in
            AndroidManifest.xml in the APK.
      Change-Id: Ib673bca5a31b2f95329c9310a127ec0701bd8fdc
      9cd42f39
  26. Jul 24, 2018
    • Yohei Yukawa's avatar
      Migrate to Android Testing Support Lib (part 7/N) · c0aa76f8
      Yohei Yukawa authored
      InstrumentationTestCase and ActivityInstrumentationTestCase2 are
      deprecated.  This CL rewrites tests that rely on those deprecated
      classes by using Android Testing Support Library.
      
      Bug: 110805255
      Test: verified as follows. No new test failures.
          tapas adb LatinIME LatinIMETests arm64 userdebug && \
          DISABLE_PROGUARD=true make -j LatinIME && \
          adb install -r $OUT/system/app/LatinIME/LatinIME.apk && \
          atest LatinIMETests:com.android.inputmethod.keyboard.internal.MoreKeySpecStringReferenceTests LatinIMETests:com.android.inputmethod.latin.settings.AccountsSettingsFragmentTests
      Change-Id: I4fefccaa0c480cfba7142ed36883da2f19b6a5f9
      c0aa76f8
Loading