Skip to content
Snippets Groups Projects
  1. Feb 13, 2013
  2. Feb 12, 2013
    • Jean Chalard's avatar
      Some cleanups · 80180510
      Jean Chalard authored
      Improve a slew of logging statements, and put commands that we don't
      expect to need protecting against exceptions out of a try {} block.
      
      This is a followup to Id3dc510a
      
      Change-Id: Idc6f419ac095b5b0f2d6862d58926ef888cb34e6
      80180510
  3. Feb 11, 2013
  4. Feb 07, 2013
  5. Feb 06, 2013
  6. Feb 02, 2013
  7. Jan 29, 2013
    • Jean Chalard's avatar
      Refactoring · d515f134
      Jean Chalard authored
      This creates a new DictionaryInfoUtils class and moves a bunch
      of static methods there for later usage.
      
      Change-Id: Iecb0643e6029a7be36bd6cb36aa918c40e6d8c6a
      d515f134
  8. Jan 21, 2013
  9. Nov 13, 2012
    • Jean Chalard's avatar
      Make sure all FDs are correctly closed. · 5c32b6da
      Jean Chalard authored
      In this kind of series of calls, it's possible that an outer call to a
      constructor fails, but the inner succeeded.
      Example:
      try {
          is = new A(new B());
      } finally {
          if (null != is) is.close();
      }
      In this case, if new B() succeeds but new A() throws an
      exception, is stays null and the intermediate object is never
      closed. This is what was happening in this instance.
      
      Bug: 7377336
      Change-Id: I3fae9fec1135244982fcf5098c76d93f3e0f2add
      5c32b6da
  10. Oct 23, 2012
    • Jean Chalard's avatar
      Fix the build. · 1e0cc86b
      Jean Chalard authored
      It seems this change snuck out from a previous version.
      
      Change-Id: I9c33d51273732b1d55bfd60f0957184c86fa88ab
      1e0cc86b
    • Jean Chalard's avatar
      Add reader and writer for the combined dict format. · 9bb4eebf
      Jean Chalard authored
      This introduces a new textual format for the dictionary that combines
      words, bigrams and shortcuts to avoid complexity. It is also extensible
      to n-grams to fool-prof for the future, and easier to read than XML.
      
      Bug: 7388540
      Change-Id: I942bbad51bd0c905a5a54c278667563fd6dd66ec
      9bb4eebf
  11. Oct 12, 2012
  12. Oct 11, 2012
  13. Oct 04, 2012
  14. Sep 27, 2012
  15. Aug 22, 2012
  16. Jul 04, 2012
  17. May 23, 2012
  18. Apr 20, 2012
  19. Apr 12, 2012
  20. Mar 29, 2012
  21. Mar 21, 2012
  22. Oct 04, 2011
  23. Aug 31, 2011
    • Jean Chalard's avatar
      Check the magic number of a decoded file · 7a408431
      Jean Chalard authored
      Checking the magic number of a file upon decoding is necessary,
      because if the file is corrupt and we don't check it, we will
      fall back to a simple copy of the corrupted file. Latin IME
      would realize this and would not crash, but would not use the
      corrupted dictionary. If this happened to be a main dictionary,
      then the user would lose the ability to use the correct
      built-in dictionary.
      
      Not the same, but kinda similar to
      Bug: 5223031
      
      Change-Id: Ic2783dc9dd5f3dcf2865623d9452765fe3778db7
      7a408431
  24. Aug 25, 2011
  25. Aug 24, 2011
    • Jean Chalard's avatar
      Add a debug variable · a16621ad
      Jean Chalard authored
      ...that was missing
      
      Change-Id: Ia3b17909f295e0a93dee633c8d67c0e03840023e
      a16621ad
    • Jean Chalard's avatar
      Avoid unnecessary output to the system log. · 20973de7
      Jean Chalard authored
      The message this removes gets printed under normal conditions.
      Normally dictionary files are compressed then crypted, but not
      compressed a second time; however LatinIME tries to open a
      compressed-crypted-compressed file first, because it could not
      do it afterwards and we want to support this case. So under
      normal operations, the first method LatinIME tries is actually
      expected to fail.
      Also, if we decide to stop compressing or/and encrypting dicts
      LatinIME supports it as a valid use case. It should not print
      errors to the log.
      
      If the file cannot be open at all, then it is an unexpected
      case, and Latin IME still reports to the log.
      
      Change-Id: Ic5228c51365a101af1d03e2c893484d3050b5a1c
      20973de7
    • Jean Chalard's avatar
      Call the decrypt/unzip routines upon copying a dictionary. · 38d512c0
      Jean Chalard authored
      Bug: 5095140
      Change-Id: I7000f752bc9b7fd6a7af4839b2f225c085300128
      38d512c0
    • Jean Chalard's avatar
      Refactoring: cut out a method for caching a word list · 7b1f74bb
      Jean Chalard authored
      This is preparation to have the decrypting/unzipping code
      moved over to LatinIME.
      
      Bug: 5095140
      Change-Id: Ic3fdcc3de673b46cef2eb9ebe6a52cbdd614e50a
      7b1f74bb
  26. Aug 18, 2011
    • Jean Chalard's avatar
      Exception refactoring · 80e0bf04
      Jean Chalard authored
      Now that the dictionary pack can return several files, it's better
      to handle IO exceptions for each file rather than globally. This
      also will help with next implementation steps.
      
      Bug: 5095140
      Change-Id: I5ed135ad2ad4f55f61f9b3f92c48a35d5c24bdb2
      80e0bf04
  27. Aug 11, 2011
  28. Aug 10, 2011
  29. Aug 09, 2011
  30. Aug 02, 2011
    • Jean Chalard's avatar
      Change the dictionary file passing schema to a list of ids · fae8d60e
      Jean Chalard authored
      The dictionary filename used to be passed directly to Latin IME.
      This change implements, on the part of Latin IME, the passing of
      them as an id that should then be passed through
      openAssetFileDescriptor.
      
      Bug: 5095140
      Change-Id: I7d1e9d57c19f0645045368f68681680f238189fc
      fae8d60e
  31. Jul 26, 2011
Loading