- Apr 16, 2013
-
-
Jean Chalard authored
Change-Id: Ibf2cdedf510c296561bb5eeb6ff18c3414d6d6f4
-
Jean Chalard authored
Bug: 7657025 Change-Id: I2f8fe7fc4596a498322ba5ccabbd0c18a2bc36cf
-
Jean Chalard authored
Change-Id: Ib4d002f90cd3a0e9ad4c04b883b0c1f05ada3ccf
-
Jean Chalard authored
Bug: 8620678 Change-Id: Ia91761f33518a010b2844d34523cadece261c67e
-
Jean Chalard authored
Bug: 8620758 Change-Id: I39f07939ebb6148a48aae5b915ee807002a5b02d
-
- Apr 15, 2013
-
-
Jean Chalard authored
Bug: 8583091 Change-Id: I9195d68e44e9a282e25ccd2978d7b4088f600170
-
Jean Chalard authored
The only place where it's used is checked for nullity. Also, it's possible, also difficult, to match a different recapitalize with the old code, triggering a bug that this fixes. Change-Id: I717d6df489025c75d1caca290a9086c3b39a9306
-
Jean Chalard authored
Bug: 7980115 Change-Id: I8de31068992aec712eaad132857d9dc61f28e30a
-
Jean Chalard authored
Upon pressing Shift, if there is currently a selected string, have Latin IME change its capitalization. This does not yet have the keyboard mode follow the mode - the change is complicated enough as is. Bug: 7657025 Change-Id: I54fe8485f44e04efd72c71ac9feee5ce21ba06f2
-
Jean Chalard authored
Bug: 8084810 Change-Id: I1743c09c43ca6835bb2f607684b037bf17d36335
-
Jean Chalard authored
If the user gestures a word, then hits backspace in disapproval, and gestures about the same thing again, make sure that we don't suggest the same thing again. Bug: 7549311 Change-Id: I793bc4df7c3841fa8f2f4146707c26e873f374c1
-
Tadashi G. Takaoka authored
Bug: 8560722 Change-Id: I825b135bd13aca17e712330660978b834648dbc3
-
Tadashi G. Takaoka authored
Bug: 8613600 Change-Id: I279d3264080aede59203205c45763c7f8ff08ae6
-
Tadashi G. Takaoka authored
Bug: 8605150 Change-Id: Iadbebfb80e765c97e58e8524eb87419f2a9e41d4
-
Jean Chalard authored
There are two problems here. The first one is the tests would send an invalid unicode character. Although we could want dicttool to handle this more gracefully, it's fine for now. The second problem is much more serious. If a node has more than 128 children, then the java code will crash trying to read the dictionary back because of a bug that this change fixes. In theory, it's possible that happens when we try to load the user history dictionary back from the disk - native code is not affected so there is no other point that may cause a problem. In the practice, that means you'd need to have 129 words with a common prefix (including empty string) but all different after this. It's almost impossible with Google Keyboard since there are only so many keys on the keyboard that you can make a word out of, and then again you'd have to do it repeatedly until it actually enters the user history dictionary, wait for it to get saved on the disk. The bad news is, if you manage to get this far, the keyboard will crash every time and won't be able to get up until you clear data for the package. The good news is, the dictionary itself is not corrupted and only the reading code is wrong. So updating to a newer version would actually even recover from this situation. All in all, considering how almost-impossible this is to trigger, I don't think even a single user actually did hit this bug. Bug: 8583091 Change-Id: Iabb2a7f47cbd9ed3193d2a3487318d280753e071
-
- Apr 12, 2013
-
-
Jean Chalard authored
Bug: 8561056 Change-Id: I91fb0ac76dabfc841bafc0e2c0ea9f63e6f604f9
-
Jean Chalard authored
This uses the old suggestions. It does not try to recompute new suggestions if there are no old suggestions yet: this is coming in a later change. If there are no suggestions, this shows the word itself as a suggestion. Bug: 8084810 Change-Id: I4c2e25df0ff3673be1825f57a0c19a9d23d47a48
-
Jean Chalard authored
Bug: 7369456 Change-Id: Iecd6f6d617f31bd2aa6749516711aeb1f0549622
-
Jean Chalard authored
Bug: 8562529 Change-Id: Ibd853f0cb995e7fb35f8730eafcef73ead58c869
-
- Apr 11, 2013
-
-
Jean Chalard authored
Bug: 8376173 Change-Id: Icaac8ad412e0180c44e6a955943e3b208981b2ea
-
Jean Chalard authored
Bug: 7657025 Change-Id: I4889721b5348c77ed56c5157557e9988dea48a02
-
Tadashi G. Takaoka authored
Change-Id: I2d939bc1e3279253902b28ff12bbf7861716b64d
-
- Apr 10, 2013
-
-
Jean Chalard authored
Both bugs only affect debug mode. One has the wrong object tested with equals, the other has the iteration failing in some cases. Change-Id: Ie9100d257a3f9e3be340cf3e38116f63417bdc1a
-
Jean Chalard authored
Bug: 8583675 Change-Id: I14924fef5663f48481994c02c56be45f9f85be65
-
Tadashi G. Takaoka authored
Change-Id: Ifc62bacbd0583a7d102009681a94bdd9ccff7d47
-
Jean Chalard authored
Change-Id: Ic220129dc59f585164dbf63591cd1c96de17fe6f
-
Tadashi G. Takaoka authored
Bug: 8541190 Change-Id: I37d3de12558efd55f157389d2e0b51fc83dc5da1
-
Tadashi G. Takaoka authored
Bug: 8582061 Change-Id: Iac8f65defdd92d7df533bdf0e2937ad897d96363
-
Tadashi G. Takaoka authored
Bug: 8581647 Change-Id: Id530f1a33a5c919f4a732ec0d545dfbe76e56316
-
Tadashi G. Takaoka authored
Bug: 8581647 Change-Id: Id530f1a33a5c919f4a732ec0d545dfbe76e56316
-
Tadashi G. Takaoka authored
Change-Id: I56a64228a5fd85d440d0d08ac67cba8bf2e5690d
-
- Apr 09, 2013
-
-
Jean Chalard authored
That includes gestures, which used not to work. Bug: 8532637 Change-Id: I04606565d7000faadf954c4a806c39d4d162a2c1
-
- Apr 08, 2013
-
-
Ken Wakasa authored
Change-Id: I6aef328ec9041666cc168c8323bed04d39591b71
-
- Apr 05, 2013
-
-
Jean Chalard authored
Change-Id: I6b56b91ace57f4a49584b5dceb71b145859f839e
-
Jean Chalard authored
Change-Id: I9cc2e9a7ac0b3346af40bcb083f939333336cf09
-
- Apr 02, 2013
-
-
Tadashi G. Takaoka authored
Change-Id: I544eec9d661796d57749dbaa2163bc1e2a891353
-
Jean Chalard authored
This reverts commit c741f1f8 DO NOT MERGE is ignored and this is merged anyway :( Change-Id: Ie044cdfc6021933379ec97ad7346c5c8591f70bf
-
Jean Chalard authored
Change-Id: Ifdec9338a454291621b2b87c899f5d4301480b27
-
- Apr 01, 2013
-
-
Kurt Partridge authored
Previously handleSeparator() caused the ResearchLogger to mark the time at which a LogUnit should be broken. However, this causes the motion data associated with a separator to be associated with the LogUnit of the previous word. This change corrects this bug. Change-Id: I8b4d4fa6de2a013de9e2a28bb668c446a07f1957
-
Jean Chalard authored
Bug: 8000119 Change-Id: I021481343d6d87efd8ff6110e9aa0906a1a3d11d
-