Skip to content
Snippets Groups Projects
Select Git revision
  • master default protected
  • trie-js-dumping protected
  • hitbox-boosting protected
  • model-metadata protected
  • lm-2-finetuning-whisperggml protected
  • lm-2-finetuning protected
  • lm-2 protected
  • language_model_experiments protected
  • 0.1.24.2 protected
  • 0.1.24.2-rc1 protected
  • 0.1.24.1 protected
  • 0.1.24.1-rc1 protected
  • 0.1.24 protected
  • 0.1.24-rc1 protected
  • 0.1.23.2 protected
  • 0.1.23.1 protected
  • 0.1.23 protected
  • 0.1.22 protected
  • 0.1.21 protected
  • 0.1.20 protected
  • 0.1.19 protected
  • 0.1.18 protected
  • 0.1.17 protected
  • 0.1.16 protected
  • 0.1.15 protected
  • 0.1.14.1 protected
  • 0.1.14 protected
  • 0.1.13 protected
28 results
Search by author
  • Any Author
  • Aleksandras Kostarevas Aleksandras Kostarevas alex
  • Dean Dean dean
  • Tom Folbrecht Tom Folbrecht tom
  • sameer sameer sameer
4 authors
  1. Apr 16, 2013
  3. Apr 15, 2013
    • Jean Chalard's avatar
      Remove a useless function · bc501647
      Jean Chalard authored 
      Bug: 8583091
Change-Id: I9195d68e44e9a282e25ccd2978d7b4088f600170
      bc501647
    • Jean Chalard's avatar
      Small performance improvement / minor bugfix · 1e5bbe4c
      Jean Chalard authored 
      The only place where it's used is checked for nullity.
Also, it's possible, also difficult, to match a different
recapitalize with the old code, triggering a bug that
this fixes.

Change-Id: I717d6df489025c75d1caca290a9086c3b39a9306
      1e5bbe4c
    • Jean Chalard's avatar
      Remove gesture suggestions with an INT_MIN score · a5a2f3e3
      Jean Chalard authored 
      Bug: 7980115
Change-Id: I8de31068992aec712eaad132857d9dc61f28e30a
      a5a2f3e3
    • Jean Chalard's avatar
      Have Latin IME re-capitalize a selected string · 2995abe7
      Jean Chalard authored 
      Upon pressing Shift, if there is currently a selected string, have
Latin IME change its capitalization.
This does not yet have the keyboard mode follow the mode - the change
is complicated enough as is.

Bug: 7657025
Change-Id: I54fe8485f44e04efd72c71ac9feee5ce21ba06f2
      2995abe7
    • Jean Chalard's avatar
      If there are no suggestion span, recompute suggestions. · 0e9ee4d3
      Jean Chalard authored 
      Bug: 8084810
Change-Id: I1743c09c43ca6835bb2f607684b037bf17d36335
      0e9ee4d3
    • Jean Chalard's avatar
      Reject a previously user-refused suggestion. · d40f3f6b
      Jean Chalard authored 
      If the user gestures a word, then hits backspace in
disapproval, and gestures about the same thing again,
make sure that we don't suggest the same thing again.

Bug: 7549311
Change-Id: I793bc4df7c3841fa8f2f4146707c26e873f374c1
      d40f3f6b
    • Tadashi G. Takaoka's avatar
      Remove unnecessary harmful finish() from SettingsActivity · 216fb6a0
      Tadashi G. Takaoka authored 
      Bug: 8560722
Change-Id: I825b135bd13aca17e712330660978b834648dbc3
      216fb6a0
    • Tadashi G. Takaoka's avatar
      Add preference dependency to gesture input related options · 29105a72
      Tadashi G. Takaoka authored 
      Bug: 8613600
Change-Id: I279d3264080aede59203205c45763c7f8ff08ae6
      29105a72
    • Tadashi G. Takaoka's avatar
      Ignore modifier key while sliding key input · 8dfbb740
      Tadashi G. Takaoka authored 
      Bug: 8284624
Change-Id: I839d7a769d98f29be647dbe511ba3f73ca44446d
      8dfbb740
    • Tadashi G. Takaoka's avatar
      Reset vertical correction when more suggestions are in modal mode · 51c38a44
      Tadashi G. Takaoka authored 
      Bug: 8605150
Change-Id: Iadbebfb80e765c97e58e8524eb87419f2a9e41d4
      51c38a44
    • Jean Chalard's avatar
      Fix Binary dict tests · c2e9c511
      Jean Chalard authored 
      There are two problems here. The first one is the tests would send
an invalid unicode character. Although we could want dicttool to
handle this more gracefully, it's fine for now.

The second problem is much more serious. If a node has more than
128 children, then the java code will crash trying to read the
dictionary back because of a bug that this change fixes. In
theory, it's possible that happens when we try to load the user
history dictionary back from the disk - native code is not affected
so there is no other point that may cause a problem.
In the practice, that means you'd need to have 129 words with a
common prefix (including empty string) but all different after
this. It's almost impossible with Google Keyboard since there are
only so many keys on the keyboard that you can make a word out
of, and then again you'd have to do it repeatedly until it
actually enters the user history dictionary, wait for it to get
saved on the disk.
The bad news is, if you manage to get this far, the keyboard will
crash every time and won't be able to get up until you clear
data for the package.
The good news is, the dictionary itself is not corrupted and only
the reading code is wrong. So updating to a newer version would
actually even recover from this situation.

All in all, considering how almost-impossible this is to trigger,
I don't think even a single user actually did hit this bug.

Bug: 8583091
Change-Id: Iabb2a7f47cbd9ed3193d2a3487318d280753e071
      c2e9c511
    • Tadashi G. Takaoka's avatar
      Suppress calling onPressKey and onReleaseKey while detecting gesture · a91da766
      Tadashi G. Takaoka authored 
      Bug: 8284624
Change-Id: I14470bb2373965aefa921b2c94948450bfa438e3
      a91da766
  5. Apr 12, 2013
  7. Apr 11, 2013
  9. Apr 10, 2013