- Mar 04, 2014
-
-
Tadashi G. Takaoka authored
Bug: 13204690 Change-Id: Ife438e78d9bbbf796df20f95c2da7a4d50e5a035
-
Jean Chalard authored
Bug: 8636060 Change-Id: I0d8f93985ddc6e93ce9af0d92a8056620351a498
-
Jean Chalard authored
We should not test punctuation with this equality test any more. Also, whether the suggestion strip is displayed or not, or whether the hint is displayed or not, has nothing to do with this method and should be handled elsewhere rather than here -- and as a matter of fact, it is, which makes this useless. Bug: 8636060 Change-Id: I6a54ee87e4e9f81bc33158acf4a264c3abd5829d
-
Jean Chalard authored
Bug: 8636060 Change-Id: Ic7c2dec2521613d52707457463691bec383177ff
-
Jean Chalard authored
...and improve encapsulation and readability. Bug: 8636060 Change-Id: I36407630b307df0721ea7fdb7e7a22cdf2b018b3
-
Tadashi G. Takaoka authored
This CL also release key graphics and dismiss sliding key input preview. Bug: 13204690 Change-Id: Ie8eb7b7beca51689a907da9c0713b4d34d48dda1
-
Tadashi G. Takaoka authored
Bug: 13204690 Change-Id: I9188edd0e99ca8acdcb0f0e045be7d267d56b12d
-
- Mar 03, 2014
-
-
Tadashi G. Takaoka authored
Bug: 13271570 Change-Id: Ie06cd83baaaf674d8b34f0232c164c4541aceb43
-
Tadashi G. Takaoka authored
Change-Id: I2994fd72bc284c84757f5a2bfa8045aa574a8fbc
-
- Feb 28, 2014
-
-
Keisuke Kuroyanagi authored
This happens when there are tailing single quotes. Bug: 13237314 Change-Id: I7fd2a20b25ac2217f9621d7f2510345bbd633c14
-
Keisuke Kuroyanagi authored
Bug: 13197276 Change-Id: Ib5247da691ff24a73e13485288237ccc51bb54f0
-
Keisuke Kuroyanagi authored
Bug: 13231889 Change-Id: If64b7422967c3e4107c845072b64a7bb26a35f7e
-
Ken Wakasa authored
It may just return null. Change-Id: I778fb48262ef8af28a4af50b70bb94ace75a488c
-
- Feb 27, 2014
-
-
Keisuke Kuroyanagi authored
Bug: 8187060 Bug: 13127350 Change-Id: I081ee904c41898128efa8ba7a1bf3fa0a46c6231
-
Keisuke Kuroyanagi authored
Bug: 13216198 Change-Id: I20ce61c4a10c360e028bf6427f632cc5299763e4
-
Keisuke Kuroyanagi authored
Change-Id: I2edab4e3ba4ea0b9b13f9bb224aac86cac9b9f31
-
Jean Chalard authored
Bug: 13215163 Change-Id: I00099cb4927c96de46e57e14ab906d41c9c2151a
-
- Feb 26, 2014
-
-
Keisuke Kuroyanagi authored
Bug: 13197276 Change-Id: I206cf4e599ca9cdf40d669358a1067a2954d11e3
-
Keisuke Kuroyanagi authored
Bug: 13197276 Change-Id: I80311a51d9e98bfeb8c0dd9cd4adde93af366d54
-
Keisuke Kuroyanagi authored
Bug: 13197276 Change-Id: I6c38a127e1745903594b7bf0ec80ef179e794feb
-
Keisuke Kuroyanagi authored
Bug: 13197276 Change-Id: I23f453c2c1deea70eab552f8d433fe264adf68b3
-
Jean Chalard authored
...and make a method private. Bug: 8636060 Change-Id: If16f7e8ef3779f77a9db23fb7c54e7c23b043b86
-
Jean Chalard authored
Bug: 13062385 Change-Id: I426545d1fe8fd76bcf4d1dce19e6b571a55c79ae
-
- Feb 25, 2014
-
-
Jean Chalard authored
Bug: 10385162 Change-Id: Icf9471d474a3a8ed8f38c46c7948c66f9131691e
-
Jean Chalard authored
This is more correct. When predictions, the typed word should always be null unless explicitly passed. The text color should be that of a valid typed word only if it's actually the typed word. Bug: 13170509 Change-Id: I769ae100e112c37c6f02064fe9ef2f81372ca9e5
-
Jean Chalard authored
This fixes the color of the predictions when running on a theme that has different colors for typed and suggested words (GB theme). Also, this is easier to understand and to modify from now on. Change-Id: Ifdc6d86a1695e83e16103041b06a2451f8d52cc4
-
Jean Chalard authored
Rename some variables for clarity and use constants instead of immediates. Change-Id: Ie07fbfcc3738ac4e67aefddc339fc54259172c39
-
Jean Chalard authored
Bug: 13170509 Change-Id: Ib9f10b8a137fc773ab0e5dc903e577038e29a9e2
-
Jean Chalard authored
In the practice it works because this never tries to access inside the suggestion strip, and the worst that can happen is a wrong text color for a suggestion. But since the two colors that would be swapped are the same, nobody ever notices -- unless they are using the GingerBread theme. Change-Id: Ic8c70d8b3cdddf92946dfefbbc6d061572626c7a
-
- Feb 24, 2014
-
-
Jean Chalard authored
Bug: 13164518 Change-Id: I8768ad887af8b89ad9f29637f606c3c68629c7ca
-
Jean Chalard authored
Bug: 13082957 Change-Id: I25570ab4da94337ed60330c0869fe47657096626
-
Jean Chalard authored
Preliminary refactoring to fix Bug: 13082957 Change-Id: I9f1283c37089bc96140b774b1c559d58031de004
-
Jean Chalard authored
Bug: 13136079 Change-Id: Ieae6bafbd5339a033f0f342ba9af7dcc4ce209fa
-
Keisuke Kuroyanagi authored
Bug: 13138201 Change-Id: Ibaa3c2c22a4fe44ea23e92ce8576141bbad09b12
-
- Feb 21, 2014
-
-
Keisuke Kuroyanagi authored
File descriptors will be closed in BinaryDictionary.finalize(); but, this leads to unit test fails. Bug: 13066902 Change-Id: I2b0d3e54ee91fa844530df54596f86bbbbac81a5
-
Jean Chalard authored
We already have a mechanism to avoid this crash, but it wasn't used every time it needed to. It's possible that ending a batch input and starting a batch input happen while suggestions are being pulled out, which would result in pointers that have been reset being passed for trimming. Just increasing the sequence number should get rid of the problem. Bug: 12178124 Change-Id: I36ef3bc8a78679bc09daa39e665f5ce1bab50c2a
-
Tadashi G. Takaoka authored
Change-Id: Icaeb7dddd16362cd4a6384d295f89c7fbabc8b35
-
Keisuke Kuroyanagi authored
Bug: 12916055 Change-Id: I2c390ab1dc483915691b47a605772cbc2dfeaf09
-
Tadashi G. Takaoka authored
This change must be checked in together with If38a754d00. Bug: 10587358 Change-Id: I91580f9468bc5ee7ed1694d7852a60dc6793dac0
-
- Feb 20, 2014
-
-
Jean Chalard authored
The heuristic in RichInputConnection makes little sense when textLength > mExpectedSelStart but we have more than 1024 characters of text. If there are that many, it's about 100% sure that 1024 is not the correct cursor position. With no good guess, we'll just continue trusting the app, even though we know it's lying : at least it will make the problem visible to the app author. Also, there have been a lot of confusion about initialSelStart and initialSelEnd. The keyboard should log them so that it helps us and editor authors debug more easily these common problems. Issue #65170 in AOSP and Bug: 12772035 Change-Id: I6665a16c9f2832d33ee323f033bb38bcc092a3b4
-