Skip to content
Snippets Groups Projects
  1. Mar 04, 2014
  2. Mar 03, 2014
  3. Feb 28, 2014
  4. Feb 27, 2014
  5. Feb 26, 2014
  6. Feb 25, 2014
    • Jean Chalard's avatar
      [QRP6] Fix: recorrection top candidate is displayed in bold · 57c0c577
      Jean Chalard authored
      Bug: 10385162
      Change-Id: Icf9471d474a3a8ed8f38c46c7948c66f9131691e
      57c0c577
    • Jean Chalard's avatar
      [QRP5] Fix boldness for predictions, and small refactoring · 0c34ee20
      Jean Chalard authored
      This is more correct. When predictions, the typed word should
      always be null unless explicitly passed. The text color should be
      that of a valid typed word only if it's actually the typed word.
      
      Bug: 13170509
      Change-Id: I769ae100e112c37c6f02064fe9ef2f81372ca9e5
      0c34ee20
    • Jean Chalard's avatar
      [QRP4] Simplification & small correctness fix. · 783f1932
      Jean Chalard authored
      This fixes the color of the predictions when running
      on a theme that has different colors for typed and
      suggested words (GB theme).
      Also, this is easier to understand and to modify from
      now on.
      
      Change-Id: Ifdc6d86a1695e83e16103041b06a2451f8d52cc4
      783f1932
    • Jean Chalard's avatar
      [QRP3] Refactoring · a0984662
      Jean Chalard authored
      Rename some variables for clarity and use constants
      instead of immediates.
      
      Change-Id: Ie07fbfcc3738ac4e67aefddc339fc54259172c39
      a0984662
    • Jean Chalard's avatar
      [QRP2] Small refactor · 74224f2c
      Jean Chalard authored
      Bug: 13170509
      Change-Id: Ib9f10b8a137fc773ab0e5dc903e577038e29a9e2
      74224f2c
    • Jean Chalard's avatar
      [QRP1] Fix a bug where the wrong value would get passed · ef3a4564
      Jean Chalard authored
      In the practice it works because this never tries to access
      inside the suggestion strip, and the worst that can happen
      is a wrong text color for a suggestion. But since the two
      colors that would be swapped are the same, nobody ever
      notices -- unless they are using the GingerBread theme.
      
      Change-Id: Ic8c70d8b3cdddf92946dfefbbc6d061572626c7a
      ef3a4564
  7. Feb 24, 2014
  8. Feb 21, 2014
    • Keisuke Kuroyanagi's avatar
      Fix: file descriptor leaking. · d24a99cf
      Keisuke Kuroyanagi authored
      File descriptors will be closed in
      BinaryDictionary.finalize(); but, this leads to unit test fails.
      
      Bug: 13066902
      Change-Id: I2b0d3e54ee91fa844530df54596f86bbbbac81a5
      d24a99cf
    • Jean Chalard's avatar
      Don't trim newer inputpointers with old data · 2a5ec003
      Jean Chalard authored
      We already have a mechanism to avoid this crash, but it wasn't
      used every time it needed to. It's possible that ending a batch
      input and starting a batch input happen while suggestions
      are being pulled out, which would result in pointers that have
      been reset being passed for trimming.
      Just increasing the sequence number should get rid of the
      problem.
      
      Bug: 12178124
      Change-Id: I36ef3bc8a78679bc09daa39e665f5ce1bab50c2a
      2a5ec003
    • Tadashi G. Takaoka's avatar
      Add ImportantNoticeDialog · d73044a2
      Tadashi G. Takaoka authored
      Change-Id: Icaeb7dddd16362cd4a6384d295f89c7fbabc8b35
      d73044a2
    • Keisuke Kuroyanagi's avatar
      Remove corrupted ver4 dictionaries. · d934fb43
      Keisuke Kuroyanagi authored
      Bug: 12916055
      Change-Id: I2c390ab1dc483915691b47a605772cbc2dfeaf09
      d934fb43
    • Tadashi G. Takaoka's avatar
      Support versioned important notice · fe39d576
      Tadashi G. Takaoka authored
      This change must be checked in together with If38a754d00.
      
      Bug: 10587358
      Change-Id: I91580f9468bc5ee7ed1694d7852a60dc6793dac0
      fe39d576
  9. Feb 20, 2014
    • Jean Chalard's avatar
      Change a heuristic and add a log. · 3b4c1d30
      Jean Chalard authored
      The heuristic in RichInputConnection makes little sense
      when textLength > mExpectedSelStart but we have
      more than 1024 characters of text. If there are that many,
      it's about 100% sure that 1024 is not the correct cursor
      position. With no good guess, we'll just continue trusting
      the app, even though we know it's lying : at least it will
      make the problem visible to the app author.
      
      Also, there have been a lot of confusion about initialSelStart
      and initialSelEnd. The keyboard should log them so that
      it helps us and editor authors debug more easily these
      common problems.
      
      Issue #65170 in AOSP and
      Bug: 12772035
      Change-Id: I6665a16c9f2832d33ee323f033bb38bcc092a3b4
      3b4c1d30
Loading