Skip to content
Snippets Groups Projects
  1. Jul 31, 2014
  2. Jul 30, 2014
  3. Jul 29, 2014
  4. Jul 27, 2014
    • Tadashi G. Takaoka's avatar
      Make "Show correction suggestions" as a binary option · ab661e3e
      Tadashi G. Takaoka authored
      Formerly "Show correction suggestions" had three options, "always
      show", "show in portrait mode", and "always hide". The reason behind
      "show in portrait mode" was that there may not be enough screen estate
      in landscape mode to show suggestions. Because recent phone devices
      have relatively large screen, we decide to remove "show in portrait
      mode" option.
      
      Bug: 15780939
      Change-Id: I896d737452c3893d43ce20bd88127f10c1eb3d83
      ab661e3e
  5. Jul 30, 2014
  6. Jul 29, 2014
  7. Jul 30, 2014
  8. Jul 29, 2014
  9. Jul 30, 2014
  10. Jul 29, 2014
  11. Jul 17, 2014
  12. Jul 08, 2014
  13. Jul 01, 2014
  14. Jun 30, 2014
    • Jean Chalard's avatar
      [SD5] Remove useless args · 1d300239
      Jean Chalard authored
      Bug: 15840116
      Change-Id: Ib3380cfc9d343c6f8953bba03af3801142bc3bdb
      1d300239
    • Jean Chalard's avatar
      [SD4] Restart suggestions on language change · 6345562e
      Jean Chalard authored
      ...otherwise we can't recompute the composition when we
      change scripts.
      
      This also fixes when we register that we need to take note
      that the current subtype was used. Luckily this is a good
      occasion for some cleanup that I've wanted to do for some
      time: use InputTransaction for onTextInput (with the goal
      to ultimately remove it entirely)
      
      Bug: 15840116
      Change-Id: Ie4f4f9157b66b79237eeb3db75535803124d3e19
      6345562e
  15. Jun 27, 2014
  16. Jul 01, 2014
    • Jean Chalard's avatar
      Fix a unit test · fa4c59f9
      Jean Chalard authored
      When switching languages, we need to wait until the dictionary is
      loaded to compute suggestions.
      
      Change-Id: I7c32a900b297cd6302bfdc020842581315f3007f
      fa4c59f9
  17. Jun 25, 2014
  18. Jun 26, 2014
    • Jean Chalard's avatar
      [HW1] Fix some bugs with event handling · 09291050
      Jean Chalard authored
      With hardware events, we do have some events that
      have both a keycode and a code point, so we need
      a better way of distinguishing between auto-insert
      keystrokes and others.
      
      Change-Id: Ia23042989b4dca9d3a7d4a4c06bcebdabe324a7a
      09291050
  19. Jun 25, 2014
  20. Jun 23, 2014
    • Jean Chalard's avatar
      Some cleanup to accommodate a fix · debe0dac
      Jean Chalard authored
      Also, this double tests for CODE_SPACE in the path going through
      maybeDoubleSpacePeriod, but that's temporary.
      
      Bug: 15740318
      Change-Id: I0a6ace09cc791f0009157d3017675b9b3eb92145
      debe0dac
  21. Jun 20, 2014
  22. Jun 19, 2014
  23. Jun 16, 2014
  24. Jun 10, 2014
    • Jean Chalard's avatar
      Remove mPrevWordsInfo · 367c199d
      Jean Chalard authored
      This member has outlived its usefulness. It's not clear now that it
      makes things really faster, but it does bring a lot of complexity
      that we can avoid by removing it.
      
      Change-Id: Ifbc8094a45b56b958fe165b1930f4cc358a97721
      367c199d
  25. Jun 06, 2014
    • Jean Chalard's avatar
      When starting input, include the literal word in suggestions · fca2c4b4
      Jean Chalard authored
      This change also includes a fix that has suggestions re-computed
      when the typed word is included but no prior suggestions were
      found in spans.
      
      Bug: 2349475
      Change-Id: Ic06e6ac492507126ffc1e96a5f396c971b567272
      fca2c4b4
    • Jean Chalard's avatar
      Fix a bug on rotation with selection. · 9fd9a68d
      Jean Chalard authored
      The symptom : when text is selected and the device is rotated,
      sometimes the keyboard sets the word as being composed around
      the start of the selection. Upon the next rotation this ends up
      with the keyboard committing some text in place of the selection.
      
      The cause : another bug in the framework with rotation >.>
      The keyboard receives a call to startInput with a wrong cursor
      position, namely one that does not represent a selection. The
      keyboard sets a composition according to this wrong data. When
      the keyboard is rotated again, it commits the text, which takes
      the place of the selection.
      
      The solution : actually when restarting input the keyboard
      realizes that the cursor position is wrong. We cancel composition
      at that time.
      For robustness, this change also implements two other defensive
      changes : upon call to onUpdateSelection, we actually realize
      that the previous values were wrong, so we also fix it at that
      time, and in addition, when rotating, we finishComposingText()
      instead of commitText() which is less dangerous. Implementing
      this later change also allows us to let less internal variables
      from InputLogic escape to LatinIME, so it's also a good change
      for design.
      
      Bug: 14140799
      
      Change-Id: Ib10de18e53e376ac1bbc8487e13d969828483346
      9fd9a68d
  26. Jun 05, 2014
  27. Jun 04, 2014
    • Jean Chalard's avatar
      Don't recapitalize just at the start of input · c84b1084
      Jean Chalard authored
      Bug: 13283555
      Change-Id: Iab0466425dc44779d110f2cd29d725d22eb04827
      c84b1084
    • Jean Chalard's avatar
      Refactoring · 4a1113b6
      Jean Chalard authored
      Rename `initialize' to `start' and `deactivate' to `stop' for ease
      of understanding. It's completely bizarre that you can "deactivate"
      a recapitalization and that will just restart a new one the next time
      you press shift. Start and stop are easier to understand.
      
      Change-Id: I455175aebfcfe11198c6c61bf2c6b19efc3f82df
      4a1113b6
  28. May 30, 2014
Loading