Skip to content

Remove callabck environment variables + smaller changes

Nick Orlowsky requested to merge no/rm-callback-envvar into master

This PR removes the need for specifying a PLATFORMNAME_CALLBACK_URL by generating it automatically as OAUTH_CALLBACK_DOMAIN/platforms/PLATFORM_NAME/oauth/callback. It also changes the type for the challengeResponse parameter in isTokenValid to string. These changes have been manually tested for all of the OAuth verifiers.

It also:

  • Fixes bug with Spotify OAuth not returning username in getToken
  • Adds improved error handling to Spotify OAuth
  • Fix bug in Discord OAuth isTokenValid causing
  • Ran formatter
  • Added formatter to CI

Since prettier cluttered up the diff, check this link for the diff of the actual code changed (excl spotify): https://gitlab.futo.org/videostreaming/verifiers/-/compare/master...6ab0d9b4632f286788d6ebeb5f599bee8ea35f50?from_project_id=68&straight=false

Here's the changes for just spotify: ff4c44fc

Edited by Nick Orlowsky

Merge request reports