Skip to content

Fix error handling in query-top-string-references

Aidan requested to merge ad-refactor-top-query-errors into master

Fix the timeout exception throwing and change fromPromiseExceptionToEmpty to fromPromiseExceptionToValue which returns undefined so forkJoin always runs (I thought forkJoin so long as a stream was completed, was wrong). Tested pretty rigorously with one fake and one real server URL this time.

With these changes, I haven't been able to reproduce the trending not loading bug since, so I hope this was the only cause

Merge request reports