- Jun 14, 2017
-
-
Paul Duffin authored
A previous change added legacy-android-test as a static dependency to all packages that build against the current, test_current or system_current and failed to compile when the junit and android.test classes were removed from the API. Unfortunately, those changes did not take into account that some of those packages target earlier API versions and so will always have the classes available at runtime. This change replaces those static dependencies with dynamic dependencies for any package that targets an earlier API version. The file changes were made automatically by a tool that constructed and then analyzed a full dependency graph of all the Android Java modules. The individual changes were checked manually to ensure that the changes matched the intent. The affected modules were built against an API with the junit and android.test classes removed. Any issues found during this process resulted in either the tool being updated to address the issue or a separate change being made to fix an existing problem with the build. A sample of the affected packages were run to ensure that they worked as expected at runtime; no issues were found during testing. The following change descriptions were generated automatically and so may be a little repetitive. They are provided to give the reviewer enough information to check the comments match what has actually been changed and check the reasoning behind the changes. * tests/Android.mk Removed legacy-android-test from LOCAL_STATIC_JAVA_LIBRARIES because LatinIMETests's manifest file (AndroidManifest.xml) targets API level 21 and dynamically includes the android.test.runner library at runtime so there is no point in statically including the classes. Added 'android.test.mock.sdk' and 'legacy-android-test' to LOCAL_JAVA_LIBRARIES because module LatinIMETests builds against 'LOCAL_SDK_VERSION := current' and uses classes from packages android.test and android.test.mock (possibly indirectly) so will no longer compile once they are removed from the API. Dependency 'android.test.mock.sdk' is used instead of 'android.test.mock' because module LatinIMETests builds against the API not internal jars and so should use libraries that build against the API not internal jars. A future change will replace the dependency on 'legacy-android-test', which builds against the internal jars with a dependency on 'android.legacy.test' which will build against the API. Bug: 30188076 Test: make checkbuild and ran a sample of tests Change-Id: I63f1a8ad16a76aba0da89b69a64cdae4400af5a0 Merged-In: Icab8a4c4801536f112e29dfd2dc66be8b90b811d
-
- Jun 13, 2017
-
-
Paul Duffin authored
A previous change added legacy-android-test as a static dependency to all packages that build against the current, test_current or system_current and failed to compile when the junit and android.test classes were removed from the API. Unfortunately, those changes did not take into account that some of those packages target earlier API versions and so will always have the classes available at runtime. This change replaces those static dependencies with dynamic dependencies for any package that targets an earlier API version. The file changes were made automatically by a tool that constructed and then analyzed a full dependency graph of all the Android Java modules. The individual changes were checked manually to ensure that the changes matched the intent. The affected modules were built against an API with the junit and android.test classes removed. Any issues found during this process resulted in either the tool being updated to address the issue or a separate change being made to fix an existing problem with the build. A sample of the affected packages were run to ensure that they worked as expected at runtime; no issues were found during testing. The following change descriptions were generated automatically and so may be a little repetitive. They are provided to give the reviewer enough information to check the comments match what has actually been changed and check the reasoning behind the changes. * tests/Android.mk Removed legacy-android-test from LOCAL_STATIC_JAVA_LIBRARIES because LatinIMETests's manifest file (AndroidManifest.xml) targets API level 21 and dynamically includes the android.test.runner library at runtime so there is no point in statically including the classes. Added 'android.test.mock.sdk' and 'legacy-android-test' to LOCAL_JAVA_LIBRARIES because module LatinIMETests builds against 'LOCAL_SDK_VERSION := current' and uses classes from packages android.test and android.test.mock (possibly indirectly) so will no longer compile once they are removed from the API. Dependency 'android.test.mock.sdk' is used instead of 'android.test.mock' because module LatinIMETests builds against the API not internal jars and so should use libraries that build against the API not internal jars. A future change will replace the dependency on 'legacy-android-test', which builds against the internal jars with a dependency on 'android.legacy.test' which will build against the API. Bug: 30188076 Test: make checkbuild and ran a sample of tests Change-Id: Icab8a4c4801536f112e29dfd2dc66be8b90b811d
-
- May 10, 2017
-
-
Paul Duffin authored
In preparation for removing junit and android.test classes from the Android API this change adds explicit dependencies on junit and/or legacy-android-test to ensure that modules will compile properly once it is removed. Care was taken to ensure that any targets that depended, directly or indirectly, on android-support-test did not also depend on junit or hamcrest as they conflict with the versions embedded within android-support-test. Bug: 30188076 Test: make checkbuild Change-Id: Icf844999082db141cffcb099aa4004afc7a7c749 Merged-In: I743f9e20e1e60836ceba9b9051fa17835deba3a2
-
- May 08, 2017
-
-
Paul Duffin authored
In preparation for removing junit and android.test classes from the Android API this change adds explicit dependencies on junit and/or legacy-android-test to ensure that modules will compile properly once it is removed. Care was taken to ensure that any targets that depended, directly or indirectly, on android-support-test did not also depend on junit or hamcrest as they conflict with the versions embedded within android-support-test. Bug: 30188076 Test: make checkbuild Change-Id: I160c136ecd1089a2b13d5cdba9eee1287aad93f9 Merged-In: I743f9e20e1e60836ceba9b9051fa17835deba3a2
-
- May 05, 2017
-
-
Paul Duffin authored
In preparation for removing junit and android.test classes from the Android API this change adds explicit dependencies on junit and/or legacy-android-test to ensure that modules will compile properly once it is removed. Care was taken to ensure that any targets that depended, directly or indirectly, on android-support-test did not also depend on junit or hamcrest as they conflict with the versions embedded within android-support-test. Bug: 30188076 Test: make checkbuild Change-Id: I743f9e20e1e60836ceba9b9051fa17835deba3a2
-
- Aug 25, 2016
-
-
Guang Zhu authored
Bug: 31072145 Test: make droid checkbuild Change-Id: I507b476694f88cc960804904feff330e6f9358c4
-
- Jul 15, 2015
-
-
Mohammadinamul Sheik authored
This build has been compiled against API 23 This build is approved to go out with the M OTA, but may NOT be released to the public until the Play Store has enabled API level 23 apps Version: 4.1.2300x.build_id 1. Replaces the personalization is on information with the suggest contacts. 2. Enables "Use Contacts" only if the app has permission to read contacts. 3. Disables the contacts dictionary in the Facilitator. 4. Do not register/read the contacts in the contact observer. Bug: 22236416 Change-Id: I9674e13d0d0f4a2014c5024fde0178de684c07e7
-
- Jun 23, 2015
-
-
Tom Ouyang authored
Change-Id: I4f0472b9f2ea2daeeba3025c588e6d0042c31be7
-
- Apr 21, 2015
-
-
Yohei Yukaw authored
Confusingly, specifying a null Locale object to the constructor of SuggestionSpan does not necessarily mean that SuggestionSpan#getLocale() returns null. The constructor in question also receives Context object, and Context's locale can be used as a fallback locale to initialize locale of SuggestionSpan. With this CL, LatinIME always specify non-null Locale object when instantiating SuggestionSpan object. It basically corresponds to the active main dictionary, but can be Locale#ROOT when one locale is not determined for some reasons. BUG: 20435013 Change-Id: I2c152466410327300e7dba4d7ed9a22f57c17c4f
-
- Apr 16, 2015
-
-
Tom Ouyang authored
This allows us to: 1. Rank contacts and only add the top N names to the keyboard LM. 2. Avoid adding duplicate names. Note: The affinity calcualuation is limited by the fact that some apps currently do not update the TIMES_CONTACTED counter. To better handle this case, the new measure also takes into account whether or not a name is in the visible contacts group. Bug: 20053274 Change-Id: I2741cb8958667d4a294aba8c437a45cec4b42dc7
-
- Apr 13, 2015
-
-
Jatin Matani authored
The raw strings would be sent to personal LM for decoding. Earlier lowercased strings were being used with the purpose of isValid checks (spelling does not consider casing for spell checking calls). But for showing these in suggestion, we need the raw strings. Note: PersonalDictionaryLookup#getWordsForLocale is used to feed the personal LM in PersonalLanguageModelHelper. Bug:20152986 Change-Id: I9d796fa57bf2073036bf11d86b143ff205a6199c
-
- Apr 10, 2015
-
-
Dan Zivkovic authored
Bug 20043003. Change-Id: I5ccac344c089855474263d1cdc547da1e6779301
-
- Apr 06, 2015
-
-
Dan Zivkovic authored
Bug 20071513. Change-Id: Iaab909575da29bfe6e17bb3865ce51d1e7720e7c
-
Dan Zivkovic authored
This reverts commit 24a9683a. Change-Id: I6f305aac6ac8d5c550a39eb5c88ec2881203cecc Reason: Breaks a clean build on master.
-
- Apr 02, 2015
-
-
Dan Zivkovic authored
Bug 19987461. Change-Id: Ia2714f555146f8f31a6d8c61f555d2b6fecdab7d
-
Alex Klyubin authored
This declares to the platform and tools that this app does not use cleartext network traffic. The platform and tools will be blocking (on best effort basis) attempts to use such traffic by this app. For example, attempts to use HTTP (rather than HTTPS) will be blocked. Bug: 19215516 Change-Id: I4c933a214457025797e077b72d8daf8a0c876923
-
Dan Zivkovic authored
Also move the class to the parent package, since it's no longer tied to the spell checking service. Bug 19966848. Bug 20036810. Change-Id: I35014d212fd87281eb90def03ee92e6872dcd63e
-
- Mar 27, 2015
-
-
Chieu Nguyen authored
Change-Id: Iaf4cd5d11b113be4738182fb662e5dc54b2f5366
-
- Mar 25, 2015
-
-
Mohammadinamul Sheik authored
- Also deleted a couple of dead methods. Bug:19929051 Change-Id: I4f88dbc2a8204d5e2a20d1ad8c205a23c6319f8d
-
- Mar 24, 2015
-
-
Chieu Nguyen authored
Bug: 19899126. Change-Id: I1824233b3bcb6cb6579714a7eb375ea2cebc39db
-
- Mar 23, 2015
-
-
Dan Zivkovic authored
Change-Id: I635a51acc2e45aebe23a1cf69da1b5c72a6ac9e1
-
Dan Zivkovic authored
Change-Id: I20a470a18ca0cd47fe7588958be904eb23fdf1a2
-
Dan Zivkovic authored
Change-Id: I800bb33a10f31d5b934b00768bc8fe4776e36f90
-
Jatin Matani authored
Bug:19532354 Change-Id: I50b3ae11b6e58f07b482353b624b1a7a73eadc99
-
- Mar 20, 2015
-
-
Dan Zivkovic authored
Change-Id: Ie319a6087297251e6b22ffd80014b69c746458e0
-
Dan Zivkovic authored
We're waiting 10 minutes for tests to run, and half of that time is spent in depreacted code related to migration of Delight2 dictionary files. LatinIME will never migrate another Delight2 dictionary file again, so we can delete this code. Change-Id: I05c7d8429e8d9a26139456763c77997340fea8c2
-
David Faden authored
Bug: 19712589 Change-Id: I81f9bf09b37487450780d85a1e4f752a9ba49370
-
- Mar 19, 2015
-
-
Mohammadinamul Sheik authored
Bug: 19712589 Bug: 19715579 Change-Id: Ie06665cab8405455c1b0a2ff034e0bb0731c9156
-
- Mar 18, 2015
-
-
Chieu Nguyen authored
Bug: 19087415. Change-Id: I3974f1b676aa4a9bb04ab7f609b6daf1860c64f1
-
Mohammadinamul Sheik authored
changed the usecase that fits the new decoder behavior. Change-Id: Ie31675f55af9f0b0b635e65d84bb629e1c89383e
-
Chieu Nguyen authored
Change-Id: Iaef87c1cd1661956d78a740507f2fd8d40b78d8b
-
Mohammadinamul Sheik authored
Change from sentence seperator to sentence terminator has broken this tests. Change-Id: I303a2e703c46191b481b7d32213f165bd00aaaa2
-
Chieu Nguyen authored
Bug: 19815109 Change-Id: I3681fcf17752defdf3c1bacff9dadb60df2468ab
-
- Mar 17, 2015
-
-
Tom Ouyang authored
Bug: 19795382 Change-Id: Id6cc4a494a06de03d351aa6257632bd3b82e2ec4
-
Mohammadinamul Sheik authored
Fixes the UserHistoryDictionaryTests Change-Id: I49776f53298ced3cd7e771cfe77a940b80b01f20
-
Dan Zivkovic authored
Change-Id: I3dd080844ee96dd60ab50ddc74632181dec775a2
-
Dan Zivkovic authored
Bug 19773815. Change-Id: Ib5eb27cdf385c81d1a3822836f424fa29c0bbaa8
-
- Mar 16, 2015
-
-
Dan Zivkovic authored
BinaryDictionaryTests runs all tests 3 times for 3 format verisons. Cut that number down by 33% to speed things up. Change-Id: I8a2f78017fa30f46b5873dcf6a5f478f57af2ebd
-
Dan Zivkovic authored
This reverts commit 1ae16dc3. Bug 19596067. Change-Id: Ie7286acbb70b215d7bd08e271bcf14526b68576f
-
- Mar 14, 2015
-
-
Mohammadinamul Sheik authored
Change-Id: I09378d74705e6943946ea4f76b15664086a387ed
-