Skip to content
Snippets Groups Projects
  1. Jun 14, 2017
    • Paul Duffin's avatar
      Fix dependencies of packages that target earlier releases · 76ae487e
      Paul Duffin authored
      A previous change added legacy-android-test as a static dependency to
      all packages that build against the current, test_current or
      system_current and failed to compile when the junit and android.test
      classes were removed from the API. Unfortunately, those changes did not
      take into account that some of those packages target earlier API
      versions and so will always have the classes available at runtime.
      
      This change replaces those static dependencies with dynamic dependencies
      for any package that targets an earlier API version. The file changes
      were made automatically by a tool that constructed and then analyzed a
      full dependency graph of all the Android Java modules. The individual
      changes were checked manually to ensure that the changes matched the
      intent. The affected modules were built against an API with the junit
      and android.test classes removed. Any issues found during this process
      resulted in either the tool being updated to address the issue or a
      separate change being made to fix an existing problem with the build. A
      sample of the affected packages were run to ensure that they worked as
      expected at runtime; no issues were found during testing.
      
      The following change descriptions were generated automatically and so
      may be a little repetitive. They are provided to give the reviewer
      enough information to check the comments match what has actually been
      changed and check the reasoning behind the changes.
      
      * tests/Android.mk
          Removed legacy-android-test from LOCAL_STATIC_JAVA_LIBRARIES
          because LatinIMETests's manifest file (AndroidManifest.xml) targets
          API level 21 and dynamically includes the android.test.runner
          library at runtime so there is no point in statically including the
          classes.
      
          Added 'android.test.mock.sdk' and 'legacy-android-test' to
          LOCAL_JAVA_LIBRARIES because module LatinIMETests builds against
          'LOCAL_SDK_VERSION := current' and uses classes from packages
          android.test and android.test.mock (possibly indirectly) so will no
          longer compile once they are removed from the API.
      
          Dependency 'android.test.mock.sdk' is used instead of
          'android.test.mock' because module LatinIMETests builds against the
          API not internal jars and so should use libraries that build
          against the API not internal jars.
      
          A future change will replace the dependency on
          'legacy-android-test', which builds against the internal jars with
          a dependency on 'android.legacy.test' which will build against the
          API.
      
      Bug: 30188076
      Test: make checkbuild and ran a sample of tests
      Change-Id: I63f1a8ad16a76aba0da89b69a64cdae4400af5a0
      Merged-In: Icab8a4c4801536f112e29dfd2dc66be8b90b811d
      76ae487e
  2. Jun 13, 2017
    • Paul Duffin's avatar
      Fix dependencies of packages that target earlier releases · 6767e059
      Paul Duffin authored
      A previous change added legacy-android-test as a static dependency to
      all packages that build against the current, test_current or
      system_current and failed to compile when the junit and android.test
      classes were removed from the API. Unfortunately, those changes did not
      take into account that some of those packages target earlier API
      versions and so will always have the classes available at runtime.
      
      This change replaces those static dependencies with dynamic dependencies
      for any package that targets an earlier API version. The file changes
      were made automatically by a tool that constructed and then analyzed a
      full dependency graph of all the Android Java modules. The individual
      changes were checked manually to ensure that the changes matched the
      intent. The affected modules were built against an API with the junit
      and android.test classes removed. Any issues found during this process
      resulted in either the tool being updated to address the issue or a
      separate change being made to fix an existing problem with the build. A
      sample of the affected packages were run to ensure that they worked as
      expected at runtime; no issues were found during testing.
      
      The following change descriptions were generated automatically and so
      may be a little repetitive. They are provided to give the reviewer
      enough information to check the comments match what has actually been
      changed and check the reasoning behind the changes.
      
      * tests/Android.mk
          Removed legacy-android-test from LOCAL_STATIC_JAVA_LIBRARIES
          because LatinIMETests's manifest file (AndroidManifest.xml) targets
          API level 21 and dynamically includes the android.test.runner
          library at runtime so there is no point in statically including the
          classes.
      
          Added 'android.test.mock.sdk' and 'legacy-android-test' to
          LOCAL_JAVA_LIBRARIES because module LatinIMETests builds against
          'LOCAL_SDK_VERSION := current' and uses classes from packages
          android.test and android.test.mock (possibly indirectly) so will no
          longer compile once they are removed from the API.
      
          Dependency 'android.test.mock.sdk' is used instead of
          'android.test.mock' because module LatinIMETests builds against the
          API not internal jars and so should use libraries that build
          against the API not internal jars.
      
          A future change will replace the dependency on
          'legacy-android-test', which builds against the internal jars with
          a dependency on 'android.legacy.test' which will build against the
          API.
      
      Bug: 30188076
      Test: make checkbuild and ran a sample of tests
      Change-Id: Icab8a4c4801536f112e29dfd2dc66be8b90b811d
      6767e059
  3. May 10, 2017
    • Paul Duffin's avatar
      Prepare for removal of junit and android.test classes from Android API (step 1) · 381c38a1
      Paul Duffin authored
      In preparation for removing junit and android.test classes from
      the Android API this change adds explicit dependencies on junit
      and/or legacy-android-test to ensure that modules will compile
      properly once it is removed.
      
      Care was taken to ensure that any targets that depended,
      directly or indirectly, on android-support-test did not also
      depend on junit or hamcrest as they conflict with the versions
      embedded within android-support-test.
      
      Bug: 30188076
      Test: make checkbuild
      Change-Id: Icf844999082db141cffcb099aa4004afc7a7c749
      Merged-In: I743f9e20e1e60836ceba9b9051fa17835deba3a2
      381c38a1
  4. May 08, 2017
    • Paul Duffin's avatar
      Prepare for removal of junit and android.test classes from Android API (step 1) · ddc9c28c
      Paul Duffin authored
      In preparation for removing junit and android.test classes from
      the Android API this change adds explicit dependencies on junit
      and/or legacy-android-test to ensure that modules will compile
      properly once it is removed.
      
      Care was taken to ensure that any targets that depended,
      directly or indirectly, on android-support-test did not also
      depend on junit or hamcrest as they conflict with the versions
      embedded within android-support-test.
      
      Bug: 30188076
      Test: make checkbuild
      Change-Id: I160c136ecd1089a2b13d5cdba9eee1287aad93f9
      Merged-In: I743f9e20e1e60836ceba9b9051fa17835deba3a2
      ddc9c28c
  5. May 05, 2017
    • Paul Duffin's avatar
      Prepare for removal of junit and android.test classes from Android API (step 1) · 3bc673c0
      Paul Duffin authored
      In preparation for removing junit and android.test classes from
      the Android API this change adds explicit dependencies on junit
      and/or legacy-android-test to ensure that modules will compile
      properly once it is removed.
      
      Care was taken to ensure that any targets that depended,
      directly or indirectly, on android-support-test did not also
      depend on junit or hamcrest as they conflict with the versions
      embedded within android-support-test.
      
      Bug: 30188076
      Test: make checkbuild
      Change-Id: I743f9e20e1e60836ceba9b9051fa17835deba3a2
      3bc673c0
  6. Aug 25, 2016
  7. Jul 15, 2015
    • Mohammadinamul Sheik's avatar
      [LatinIME] Support MNC permissions. · 60415866
      Mohammadinamul Sheik authored
      This build has been compiled against API 23
      
      This build is approved to go out with the M OTA, but may NOT be released
      to the public until the Play Store has enabled API level 23 apps
      
      Version: 4.1.2300x.build_id
      
      1. Replaces the personalization is on information with the suggest
         contacts.
      2. Enables "Use Contacts" only if the app has permission to read
         contacts.
      3. Disables the contacts dictionary in the Facilitator.
      4. Do not register/read the contacts in the contact observer.
      
      Bug: 22236416
      Change-Id: I9674e13d0d0f4a2014c5024fde0178de684c07e7
      60415866
  8. Jun 23, 2015
  9. Apr 21, 2015
    • Yohei Yukaw's avatar
      Always specify non-null Locale object to SuggestionSpan · 490fa47a
      Yohei Yukaw authored
      Confusingly, specifying a null Locale object to the constructor
      of SuggestionSpan does not necessarily mean that
      SuggestionSpan#getLocale() returns null.  The constructor in
      question also receives Context object, and Context's locale can
      be used as a fallback locale to initialize locale of
      SuggestionSpan.
      
      With this CL, LatinIME always specify non-null Locale object
      when instantiating SuggestionSpan object.  It basically
      corresponds to the active main dictionary, but can be
      Locale#ROOT when one locale is not determined for some reasons.
      
      BUG: 20435013
      Change-Id: I2c152466410327300e7dba4d7ed9a22f57c17c4f
      490fa47a
  10. Apr 16, 2015
    • Tom Ouyang's avatar
      Add affinity model for contact names. · 44a17573
      Tom Ouyang authored
      This allows us to:
      1. Rank contacts and only add the top N names to the keyboard LM.
      2. Avoid adding duplicate names.
      
      Note: The affinity calcualuation is limited by the fact that some apps
      currently do not update the TIMES_CONTACTED counter. To better handle
      this case, the new measure also takes into account whether or not a
      name is in the visible contacts group.
      
      Bug: 20053274
      Change-Id: I2741cb8958667d4a294aba8c437a45cec4b42dc7
      44a17573
  11. Apr 13, 2015
    • Jatin Matani's avatar
      Store raw strings for personal dictionary · 1bfd7be2
      Jatin Matani authored
      The raw strings would be sent to personal LM for decoding.
      Earlier lowercased strings were being used with the purpose
      of isValid checks (spelling does not consider casing for spell
      checking calls). But for showing these in suggestion, we need the
      raw strings.
      
      Note: PersonalDictionaryLookup#getWordsForLocale is used to feed
      the personal LM in PersonalLanguageModelHelper.
      
      Bug:20152986
      Change-Id: I9d796fa57bf2073036bf11d86b143ff205a6199c
      1bfd7be2
  12. Apr 10, 2015
  13. Apr 06, 2015
  14. Apr 02, 2015
    • Dan Zivkovic's avatar
      Log interrupted tasks in AOSP. · 5a53505f
      Dan Zivkovic authored
      Bug 19987461.
      
      Change-Id: Ia2714f555146f8f31a6d8c61f555d2b6fecdab7d
      5a53505f
    • Alex Klyubin's avatar
      Declare that LatinIME does not use cleartext network traffic. · 24a9683a
      Alex Klyubin authored
      This declares to the platform and tools that this app does not use
      cleartext network traffic. The platform and tools will be blocking
      (on best effort basis) attempts to use such traffic by this app.
      For example, attempts to use HTTP (rather than HTTPS) will be blocked.
      
      Bug: 19215516
      Change-Id: I4c933a214457025797e077b72d8daf8a0c876923
      24a9683a
    • Dan Zivkovic's avatar
      Add shortcut support to UserDictionaryLookup. · 87eb7ac2
      Dan Zivkovic authored
      Also move the class to the parent package, since it's no longer tied to the
      spell checking service.
      
      Bug 19966848.
      Bug 20036810.
      
      Change-Id: I35014d212fd87281eb90def03ee92e6872dcd63e
      87eb7ac2
  15. Mar 27, 2015
  16. Mar 25, 2015
  17. Mar 24, 2015
  18. Mar 23, 2015
  19. Mar 20, 2015
  20. Mar 19, 2015
  21. Mar 18, 2015
  22. Mar 17, 2015
  23. Mar 16, 2015
  24. Mar 14, 2015
Loading