This way is more understandable, and also supporting an
external string is helping for future refactorings

Bug: 13238601
Change-Id: I4ebeed46eb0b35011164946af71ac257c6449ddb

Bug: 13238601
Change-Id: I54ee9a85ecfee3c50c8db3eb4cd6f391a775a630

Bug: 15554503
Change-Id: If5e8c0d94ed26d929400ccbb0d45ac23dd98d180

This member has outlived its usefulness. It's not clear now that it
makes things really faster, but it does bring a lot of complexity
that we can avoid by removing it.

Change-Id: Ifbc8094a45b56b958fe165b1930f4cc358a97721

This CL must be checked in together with Ie52007dc5c.

Bug: 15318007
Change-Id: Ie665f296e43b5485ae8ba7e949aa262794ee0dcc

This reverts commit d941ea18 and builds on it to fix the behavior
of the broken cases.
It also fixes a small, related bug that probably has existed for
a very long time: predictions not displayed when cancelling
double-space-to-period.

Bug: 15148015
Change-Id: I1f9358f8b6f5804f831643611576be347e83999d

Bug: 15298959

Change-Id: Iba6eeb7981634e7ddb896404978b30f6efd6e72f

Bug: 13142176
Change-Id: Id5b7286d28897931f7bfe571be45d46ffeef4adf

Change-Id: If16ef50ae73147594615d0f49d6a22621eaf1aef

This reverts commit 7aa895e2.

Bug: 15148015
Change-Id: If39c4f8b897f247d4eb935923d55d81def4c8fb4

Bug: 13142176
Bug: 15094186
Change-Id: I9da67352ff2abcd289fa5885389895ced878a413

Bug: 15148015
Change-Id: Idcb729734bd62b537fb81acf8bdb5cae4470404c

Bug: 13917781
Change-Id: I7458d120898a7c8c0bc2db2f6db3578fd1dd1681

Bug: 14119293
Bug: 14425059

Change-Id: I3d5da84881a49a04550180dd9aac2c37da2ed762

Bug: 14985751
Change-Id: I9df2f737555ab02e24e0fbd231a97c1eec26bc57

This is an overdue refactoring that I have been wanted to
do forever, and that we can at last do now that suggestions
come only from instances of BinaryDictionary instances.

With this, all unit tests and regression tests are
passing again.

Bug: 13667648
Bug: 13665487
Bug: 8636060
Change-Id: Ie23a19f9b7e692edf2ee0b107ddaff2d7db564b6

Bug: 13622107
Bug: 13406701
Change-Id: I0023b398c4451253f9f717e2bd990b8a054004bc

Make mSuggest final and give DictionaryFacilitator the
responsibility to manage dictionary loading state.
This can simplify the logic to decide how to deal with
additional dictionaries when loading settings or language
switching.

Bug: 13273534
Change-Id: I9f3d328272f25addfa186fbeedaaf8417455ba99

Bug: 8187060
Change-Id: Ice2984e332b7bd3bb17174aefc80b5635b72fc50

This happens when there are tailing single quotes.

Bug: 13237314
Change-Id: I7fd2a20b25ac2217f9621d7f2510345bbd633c14

Change-Id: I2edab4e3ba4ea0b9b13f9bb224aac86cac9b9f31

Bug: 13215163
Change-Id: I00099cb4927c96de46e57e14ab906d41c9c2151a

This is more correct. When predictions, the typed word should
always be null unless explicitly passed. The text color should be
that of a valid typed word only if it's actually the typed word.

Bug: 13170509
Change-Id: I769ae100e112c37c6f02064fe9ef2f81372ca9e5

Bug: 13170509
Change-Id: Ib9f10b8a137fc773ab0e5dc903e577038e29a9e2

This change must be checked in together with I366c477516.

Bug: 12640318
Change-Id: I8d3864b9d9649c9e3306e82b01a6327b11281b1f

This change must be checked in together with Iac93eb79fc.

Bug: 12913520
Bug: 12179576
Change-Id: Ic9a40fb0529202893be8ccb6f5abfbbe6d78508c

Bug: 12913520
Change-Id: Ie15f97d90c142c51089280252b35b5ad1d226e19

No need to say this twice.

Change-Id: Ief7ac425037aa2767ee8f21c9552138a9c46afc8

Bug: 12800726
Bug: 12798403
Change-Id: I6d60f9ad39761757f8a64533f40d6441f3a36410

This constant is better located in SuggestedWords.
Or it could be in Constants, that would be fine too.

Bug: 8636060
Change-Id: I3e721bb1e2559f028dce8929eceadfe0478c5924

How/when did this happen? How was it not noticed?

Change-Id: I352a8dad65f8c27bf5120d567e96d9a12cfa8496

Bug: 8187060
Change-Id: I17be7b77ff89972d3ca6823b087b7bf35105af56

Bug: 8187060
Change-Id: I77775aa50763158d99753c2312fa11fe14267aef

Bug: 8187060
Change-Id: Idba1e708d67c036072b728949d17f8bd98ae0115

Bug: 8187060

Change-Id: Iabe13abcd43b381360f7080b3f4ee0533f246160

Bug: 11757851
Change-Id: I83e484195f036e35cbae21fe63148bc9c22bfad7

The bulk merge from -bayo to klp-dev should not have been merged to master.

Change-Id: I527a03a76f5247e4939a672f27c314dc11cbb854

Change-Id: If7497310485a895dd22b8df29dc13508acaa0ab6

Now, PersonalizationPredictionDictionary can be used not only
for prediction but also for suggestions.
We should rename PersonalizationPredictionDictionary to
PersonalizationDictionary.

Change-Id: Ifcf4459072f3523e3f3dc783f12e15b89cdbb12d

Bug: 11772864
Change-Id: I393352494b1ef81d24622a22fe7556d09945d6ff