- Jul 06, 2023
-
-
abb128 authored
-
- Oct 17, 2022
-
-
Cole Faust authored
This commit is part of a large scale change to fix errorprone errors that have been downgraded to warnings in the android source tree, so that they can be promoted to errors again. The full list of changes include the following, but not all will be present in any one individual commit: BadAnnotationImplementation BadShiftAmount BanJNDI BoxedPrimitiveEquality ComparableType ComplexBooleanConstant CollectionToArraySafeParameter ConditionalExpressionNumericPromotion DangerousLiteralNull DoubleBraceInitialization DurationFrom DurationTemporalUnit EmptyTopLevelDeclaration EqualsNull EqualsReference FormatString FromTemporalAccessor GetClassOnAnnotation GetClassOnClass HashtableContains IdentityBinaryExpression IdentityHashMapBoxing InstantTemporalUnit InvalidTimeZoneID InvalidZoneId IsInstanceIncompatibleType JUnitParameterMethodNotFound LockOnBoxedPrimitive MathRoundIntLong MislabeledAndroidString MisusedDayOfYear MissingSuperCall MisusedWeekYear ModifyingCollectionWithItself NoCanIgnoreReturnValueOnClasses NonRuntimeAnnotation NullableOnContainingClass NullTernary OverridesJavaxInjectableMethod ParcelableCreator PeriodFrom PreconditionsInvalidPlaceholder ProtoBuilderReturnValueIgnored ProtoFieldNullComparison RandomModInteger RectIntersectReturnValueIgnored ReturnValueIgnored SelfAssignment SelfComparison SelfEquals SizeGreaterThanOrEqualsZero StringBuilderInitWithChar TreeToString TryFailThrowable UnnecessaryCheckNotNull UnusedCollectionModifiedInPlace XorPower See https://errorprone.info/bugpatterns for more information on the checks. Bug: 253827323 Test: m RUN_ERROR_PRONE=true javac-check Change-Id: I454a105ae82484a2d19aff1808e8d9dd55ba64f4
-
- Apr 21, 2022
-
-
Ming-Shin Lu authored
Bug: 228766370 Test: manual by using EditorTextVariations tool 1) make and install EditTextVariations 2) Enable "Settings > Display over other apps" for EditTextVariations 3) Launch EditTextVariations from all apps 4) Menu -> Show IME focuable overlay 5) Go to home screen by gesture or pressing home key 6) Launch any app (e.g. Chrome) and tap the editor 7) Expect IME can show up Change-Id: Ib4b72e0a277d8b2fb78837bed5d2e9cccd819a07
-
- Jan 26, 2022
-
-
Wilson Wu authored
From T, apps need POST_NOTIFICATION permission to send the notification. -. Add the permission into Manifest. -. Request runtime permission when it's needed. Bug: 209479751 Test: Manual test as following steps: 1. Open EditTextVariations at T device. 2. Tap direct reply to send notification. 3. Verify the permission dialog show up. 4. Send the notification if permission granted. Change-Id: Iadae00f635ee556d1d1de9abbb9da0498b4070f1
-
- Dec 08, 2021
-
-
Steve Elliott authored
so the package can send notifications on T+ Bug: 194833441 Change-Id: Iafb56ebd788f1dcd98320dc6c250ca8f585fcab3
-
- Jun 10, 2021
-
-
Ming-Shin Lu authored
Also, set the content intent to launch an editorActivity as the message notifiation when tapping the notification. Bug: 190057993 Test: make EditTextVariations, manual test by using EditTextVariations app to simulate the issue step. Change-Id: I1a4463dc44031eaebb286ad2a289870e97a1c475
-
- Feb 17, 2021
-
-
Bob Badour authored
Added SPDX-license-identifier-Apache-2.0 to: Android.bp common/Android.bp java/Android.bp native/dicttoolkit/Android.bp native/jni/Android.bp tests/Android.bp tools/EditTextVariations/Android.bp tools/dicttool/Android.bp tools/make-keyboard-text/Android.bp Bug: 68860345 Bug: 151177513 Bug: 151953481 Test: m all Exempt-From-Owner-Approval: janitorial work Change-Id: I440008bffac5c97a2497970af377a9d03262b6d8
-
- Jul 31, 2020
-
-
Seigo Nonaka authored
See https://source.android.com/setup/contribute/respectful-code for reference Bug: 161896447 Test: tapas LatinIME && m Change-Id: Ic06f948c023a091e1532db826a78dd01031d7205
-
- Mar 23, 2020
-
-
Ashwini Oruganti authored
With b/150232615, we will need an explicit value set for the exported flag when intent filters are present, as the default behavior is changing for S+. This change adds the value reflecting the previous default to the manifest. These changes were made using an automated tool, the xml file may be reformatted slightly creating a larger diff. The only "real" change is the addition of "android:exported" to activities, services, and receivers that have one or more intent-filters. Bug: 150232615 Test: TH Exempt-From-Owner-Approval: mechanical refactoring Change-Id: Idc43e262fd2911e19f0bcd20add29e4c3392d3da
-
- Feb 06, 2019
-
-
Yohei Yukawa authored
This is a follow up CL to my previous CL [1], which enabled us to test Direct-Reply with EditTextVariations. What this CL does are: * Specyfing min_sdk_version to avoid INSTALL_FAILED_OLDER_SDK error when installing on older devices. * Avoiding NoSuchMethodError on pre-O devices where Notification.Builder does not have a constructor that takes notification channel. * Fixing a race condition where notification can be sent before notification channel is created. [1]: Iafffcc7d138b0f502116a5e557f0c3f17e9d0b73 da2486fd Bug: 122957841 Test: Made sure that we can install EditTextVariations on N devices and "Direct-Reply" on EditTextVariations works there. Change-Id: Ib4fbd447608b111e763fde4287226cf7e206e65e
-
- Jan 16, 2019
-
-
Yohei Yukawa authored
With this CL, EditTextVariations is able to send Direct Repply notification so that we can easily test IME behaviors there. You don't need to set up a chat application then let it receive a message from someone else any more just to test IME behaviors on Direct Reply. Fix: 122957841 Test: manually done as follows. 1. tapas EditTextVariations 2. make -j 3. adb install -r \ $ANDROID_TARGET_OUT_TESTCASES/EditTextVariations/EditTextVariations.apk 4. Open EditTextVariations 5. Tap the menu icon. 6. Select "Direct Reply" 7. Make sure that there is a Direct Reply notification. Change-Id: Iafffcc7d138b0f502116a5e557f0c3f17e9d0b73
-
- Nov 01, 2018
-
-
Dan Willemsen authored
See build/soong/README.md for more information. Test: cd packages/inputmethods/LatinIME; mma Change-Id: Ib8867d3b74f09fc1d9f95adc9a49a81ac0f7f054 Merged-In: Ib8867d3b74f09fc1d9f95adc9a49a81ac0f7f054
-
Dan Willemsen authored
See build/soong/README.md for more information. Test: cd packages/inputmethods/LatinIME; mma Change-Id: Ib8867d3b74f09fc1d9f95adc9a49a81ac0f7f054
-
- Oct 29, 2018
-
-
Tadashi G. Takaoka authored
This CL partially reverts - Id88b02b74bdfe4ca05b08181ceb6b34d5652fc0c - I05c7d8429e8d9a26139456763c77997340fea8c2 And followup (remove shortcut support) - I73b7dc008a5acaf75a31a36a2d332b5afabd82d0 Bug: 28255684 Test: make -j10 dicttool_aosp Change-Id: I2e01ed86b9517a1141aee35ea6d8ef39258981d1
-
- May 22, 2018
-
-
Yohei Yukawa authored
This CL opensouces a testing tool called EditTextVariations that has been used internally to test IME behaviors on various EditorInfo#inputType and EditorInfo#imeOptions. Bug: 80039502 Test: Manually verified as follows. 1. tapas EditTextVariations 2. make -j 3. adb install -r $ANDROID_TARGET_OUT_TESTCASES/EditTextVariations/EditTextVariations.apk Change-Id: Ia87e655573c2fd1fc09d56e4af90bfb1dfd65f9b
-
- Jul 26, 2017
-
-
Dan Willemsen authored
This builds on Darwin fine, so remove the non-standard darwin checks. Remove HOST_JDK_IS_64BIT_VERSION, it's always true now, and this is the only user. Test: mmm packages/inputmethods/LatinIME/tools/dicttool:liblatinime-aosp-dicttool-host Change-Id: I750c6baa29cf1d27a885ff064f0daf9d986db0b9
-
- Jan 11, 2017
-
-
Roozbeh Pournader authored
Bug: 26496609 Test: none Change-Id: I3eb7d265cc3c5ebbbc4ef737deb24f099757e821
-
- Nov 30, 2016
-
-
Paul Duffin authored
Use framework/junit-host.jar instead of framework/junit.jar Ran the script before and after making the change and it failed in the same way with a build error but it was not due to a problem with JUnit. Bug: 30188076 Test: make checkbuild and ran the test-dicttool.sh script Change-Id: I4cdd518f38184ff3ade5a06d968d6902770ece6b
-
- Oct 07, 2016
-
-
Elliott Hughes authored
Bug: http://b/32019064 Test: builds Change-Id: I17611b6d9598992bd52cf3dc93509f0f5e0bdcde
-
- Nov 28, 2014
-
-
Tadashi G. Takaoka authored
Change-Id: I256d1c6bf96c07b10d2d063d7935e20e0ab8ea17
-
- Nov 12, 2014
-
-
Adrian Velicu authored
Change-Id: I50a286c115f5bd6e93763bd2f79031676d6fffd8
-
Adrian Velicu authored
Change-Id: I738735186213b3a40eff997ae2fd83069c6445f1
-
- Nov 08, 2014
-
-
Adrian Velicu authored
Change-Id: I4198f6b463711feb4ab78020934cca4d23870fbb
-
- Nov 07, 2014
-
-
Jean Chalard authored
Also why did we have two copies of LocaleUtils >.> Bug: 18108776 Change-Id: I03b4403dfd51934e66b567f2f8b87da419cfb3ab
-
- Nov 06, 2014
-
-
Jean Chalard authored
Also fix a failing test Change-Id: I280aa6b5836c7332da08a88f1258546edeb25a37
-
Jean Chalard authored
Bug: 18108776 Change-Id: I0f57594617f8d5080aea9002b2356d18bfe97043
-
Jean Chalard authored
This will allow to greatly improve the performance of the metadata-generating files, as they won't have to wait for the info command to read the entire dictionary when the header is all we need. Also add tests, and while we're at it, use the seed as intended to enable reproducible tests. Change-Id: I0ba79ef62f0292b23e63aed57ff565bb102281a2
-
Jean Chalard authored
It's still unused as of this change but the next change will use it As a reference point, generating the metadata for Bayo takes 3'02" on my machine with the info command; it's down to 16" if made to use this instead. The gains increases with the number of dictionaries obviously. Change-Id: I0eeea2d8f81bb74b0d1570af658e91b56f7c2b79
-
Jean Chalard authored
This will allow for not copying the whole dictionary when only the header is needed. Change-Id: Ie4a649b507ccd4a430201824ed87b8b8bbf55e9f
-
- Nov 05, 2014
-
-
Jean Chalard authored
That is where the last refactorings were leading. This code is simpler, but it's far more flexible. Importantly, it only makes a single copy instead of making a full disk copy for every intermediate step. Next we're going to make the "copy" part modular for processes that don't need to copy the whole file. Change-Id: Ief32ac665d804b9b20c44f443a9c87452ceb367a
-
- Oct 31, 2014
-
-
Keisuke Kuroyanagi authored
Bug: 10059681 Change-Id: Ib730af8ebc944e08aaada869c0626724a499747c
-
Jean Chalard authored
Bug: 18108776 Change-Id: Ic81c5df2a685160c249021ff4cfe41553dbdeebe
-
Adrian Velicu authored
Bug: 11031090 Change-Id: I5cc0d006ab003656498eb82b0875eb9c051d331e
-
- Oct 29, 2014
-
-
Jean Chalard authored
Bug: 18108776 Change-Id: I9b399a44241e05a7add9bb8094263aa76de37880
-
Jean Chalard authored
Bug: 18108776 Change-Id: Ie5c0430aa41a8d6c58bf510a10173223d7dfe9fe
-
- Oct 28, 2014
-
-
Jean Chalard authored
Bug: 18108776 Change-Id: Ia46a4102a0e86e71118ca5e641f9f531998e166b
-
- Oct 24, 2014
-
-
Tadashi G. Takaoka authored
Change-Id: I538288054a58eb2c81ce3cbe5c9bef900fb653a5
-
- Oct 23, 2014
-
-
Keisuke Kuroyanagi authored
Change-Id: Idc4533e57b7f4ddccd66b1f1a4730153064b1e27
-
Jean Chalard authored
Change-Id: I23fa4e4ed96228406e70aa94d84fd7b8d3f69347
-
Jean Chalard authored
This is a preliminary refactoring change to improve performance in dicttool diagnostic tools. Change-Id: I9a59328af62e336809246be5bebbbf2e154366b3
-