Skip to content
Snippets Groups Projects
Select Git revision
  • master default protected
  • trie-js-dumping protected
  • hitbox-boosting protected
  • model-metadata protected
  • lm-2-finetuning-whisperggml protected
  • lm-2-finetuning protected
  • lm-2 protected
  • language_model_experiments protected
  • 0.1.24.2 protected
  • 0.1.24.2-rc1 protected
  • 0.1.24.1 protected
  • 0.1.24.1-rc1 protected
  • 0.1.24 protected
  • 0.1.24-rc1 protected
  • 0.1.23.2 protected
  • 0.1.23.1 protected
  • 0.1.23 protected
  • 0.1.22 protected
  • 0.1.21 protected
  • 0.1.20 protected
  • 0.1.19 protected
  • 0.1.18 protected
  • 0.1.17 protected
  • 0.1.16 protected
  • 0.1.15 protected
  • 0.1.14.1 protected
  • 0.1.14 protected
  • 0.1.13 protected
28 results
Search by author
  • Any Author
  • Aleksandras Kostarevas Aleksandras Kostarevas alex
  • Dean Dean dean
  • Tom Folbrecht Tom Folbrecht tom
  • sameer sameer sameer
4 authors
  1. Oct 02, 2013
  3. Sep 24, 2013
  5. Sep 19, 2013
  7. Sep 17, 2013
  9. Sep 13, 2013
  11. Sep 12, 2013
  13. Sep 11, 2013
  15. Aug 26, 2013
  17. Aug 23, 2013
  19. Aug 22, 2013
  21. Aug 21, 2013
  23. Aug 20, 2013
  25. Aug 19, 2013
  27. Aug 16, 2013
  29. Aug 15, 2013
  31. Aug 14, 2013
  33. Aug 13, 2013
  35. Jul 19, 2013
  37. Jul 16, 2013
    • Jean Chalard's avatar
      Small debug helper · 15882529
      Jean Chalard authored 
      So that I don't have to find out everything again each time the
test facility finds a case that does not work, and I want to dump
the output to a combined file.

Change-Id: I9f77f86055d1609c2e37747ac47421db1ba2498e
      15882529
  39. Jul 04, 2013
  41. Jun 24, 2013
  43. Jun 20, 2013
  45. Apr 15, 2013
    • Jean Chalard's avatar
      Clean up tests and increase speed · 001884a1
      Jean Chalard authored 
      Conservatively reduce the number of unigrams to test from 1000
to 100.

Bug: 8583091
Change-Id: I48621ec44ff5f0590640d7c6b174ab5a6d267aaf
      001884a1
    • Jean Chalard's avatar
      Fix a typo · c2653d0b
      Jean Chalard authored 
      Change-Id: I27b925be030e9e6ee8ae49dc13f39accec996d7e
      c2653d0b
    • Jean Chalard's avatar
      Fix Binary dict tests · c2e9c511
      Jean Chalard authored 
      There are two problems here. The first one is the tests would send
an invalid unicode character. Although we could want dicttool to
handle this more gracefully, it's fine for now.

The second problem is much more serious. If a node has more than
128 children, then the java code will crash trying to read the
dictionary back because of a bug that this change fixes. In
theory, it's possible that happens when we try to load the user
history dictionary back from the disk - native code is not affected
so there is no other point that may cause a problem.
In the practice, that means you'd need to have 129 words with a
common prefix (including empty string) but all different after
this. It's almost impossible with Google Keyboard since there are
only so many keys on the keyboard that you can make a word out
of, and then again you'd have to do it repeatedly until it
actually enters the user history dictionary, wait for it to get
saved on the disk.
The bad news is, if you manage to get this far, the keyboard will
crash every time and won't be able to get up until you clear
data for the package.
The good news is, the dictionary itself is not corrupted and only
the reading code is wrong. So updating to a newer version would
actually even recover from this situation.

All in all, considering how almost-impossible this is to trigger,
I don't think even a single user actually did hit this bug.

Bug: 8583091
Change-Id: Iabb2a7f47cbd9ed3193d2a3487318d280753e071
      c2e9c511
  47. Apr 01, 2013
    • Jean Chalard's avatar
      Fix two nasty bugs with surrogate pairs. · a411595b
      Jean Chalard authored 
      The important bug is in findWordInTree. The problem, which is
not obvious, is that we were calling codePointAt() with the
code point index in the string, instead of the char index.
The other bug this change fixes was harmless in the practice,
because it's in the iteration which is only used for debug and
pretty printing purposes. It's very similar in that it would
substract a length in code point to a length in chars and
truncate a StringBuilder at that length, so it would fail in a
quite similar manner. This changes the meaning of the "length"
attribute in Position, but it's clearer this way anyway.

Bug: 8450145
Change-Id: If396f883a9e6449de39351553ba83f5be5bd30f0
      a411595b