- Feb 17, 2014
-
-
Jean Chalard authored
Bug: 11447084 Change-Id: I5bd558b9dd85d1505aa918f44e8ac3e52ec42d97
-
- Jan 27, 2014
-
-
Jean Chalard authored
Bug: 8911672 Change-Id: I5d5635949530a67f95e5208986907251b7bce903
-
- Jan 20, 2014
-
-
Tadashi G. Takaoka authored
Change-Id: I4103541d99fe59bfcf12379a1298a0a690497846
-
- Jan 17, 2014
-
-
Tadashi G. Takaoka authored
Change-Id: I866488a47ca04ca587e805663dfd597bb7b1ebce
-
- Jan 10, 2014
-
-
Jean Chalard authored
This just mirrors what InputLogic#tryFixLyingCursorPosition is doing. That method will go away in the next change. Change-Id: Ifa2827dbc1f1d20e2c642d6f2d23514a01ed9203
-
Jean Chalard authored
This test was intended only for cases without a selection, and as a safety net for cases where the app would pretend the cursor is at N but we can get P chars from the editor where P > N. When there is a selection, this is wrong. In the practice it works because these values are not used in this case, but it's still wrong. The case where P > N is arguable, but actually I see little reason to trust the getTextBeforeCursor() method more than the onUpdate selection method. Plus in the practice, I don't think we are aware of any app with this bug, and it's probably not a great idea to be too robust about this as it may encourage wrong values sent to onUpdateSelection. Change-Id: I42f2065d7aee668074e6b8e40b259da7e88e16e1
-
- Jan 09, 2014
-
-
Tadashi G. Takaoka authored
Change-Id: I174c50f509ed6998b755e1a712e7f6c0f82f4425
-
Tadashi G. Takaoka authored
Change-Id: I0b06e8cc75a403f7061864c5b7f3f6a2cacd60eb
-
Jean Chalard authored
Change-Id: I5cfa0d2fccc139bd6c45c5590a68c3e0c90534b8
-
- Jan 08, 2014
-
-
Jean Chalard authored
Don't use absolute cursor positions when making edits, this leads to race conditions. This is a bit ugly and will need to be fixed soon. Plans are underway to clean this up. Bug: 12390573 Change-Id: I69c09fc41b979880d0800c55a710e39373287cff
-
Jean Chalard authored
Conflicts prevent this to be cherry-picked. This reverts commit dd3d697a. Change-Id: Ib97fae2234633b4bb27d611f48a79060db9ab16f
-
Jean Chalard authored
Don't use absolute cursor positions when making edits, this leads to race conditions. This is a bit ugly and will need to be fixed soon. Plans are underway to clean this up. Bug: 12390573 Change-Id: Ib42d4149343c642b1b5c1937b424e8afdbd4cc1f
-
- Dec 27, 2013
-
-
Jean Chalard authored
This old method doesn't even re-read the old suggestions. It used to recompute them without the coordinates. Re-using the recorrection code, which is much more advanced, is the right thing to do here. Also, refining the test. It's no use trying to resume suggestion if we don't have a suggestion strip, since we aren't going to auto-correct anything anyway. Not the motivation for this change, but this also fixes Bug: 11620256 Change-Id: Id49efa32e293c49837c61fdc752c86bbac1d2c88
-
- Dec 13, 2013
-
-
Ken Wakasa authored
The bulk merge from -bayo to klp-dev should not have been merged to master. Change-Id: I527a03a76f5247e4939a672f27c314dc11cbb854
-
- Nov 28, 2013
-
-
Jean Chalard authored
This should take into accounts word connectors. Change-Id: Ic7fa5c837cd65a43ba43d7ae9d299b8d20019892
-
- Nov 27, 2013
-
-
Ken Wakasa authored
Change-Id: I299c7622db291ea411e2b48dfdb622b407912ea6
-
- Nov 25, 2013
-
-
Jean Chalard authored
Bug: 11846748 Change-Id: Ieda55477201c11fb31b0f84e70ecd081211c78fc
-
- Nov 16, 2013
-
-
Kurt Partridge authored
Change-Id: Ie5cffe03b676dcde83896cda139b42f3829eb528
-
- Nov 14, 2013
-
-
Kurt Partridge authored
Change-Id: If23d8bd73fe464f12f473e093dc87ed68756e1ec
-
- Nov 13, 2013
-
-
Jean Chalard authored
...the interaction of which results in a very bad bug. Bug: 11648854 Change-Id: I774489e384388f187e72b9ac091ab387c5e1a79a
-
Jean Chalard authored
...the interaction of which results in a very bad bug. Bug: 11648854 Change-Id: I774489e384388f187e72b9ac091ab387c5e1a79a
-
- Nov 07, 2013
-
-
Kurt Partridge authored
Change-Id: Ibdaa9553cafeded15f800077606378b06af755cb
-
- Oct 22, 2013
-
-
Jean Chalard authored
This returns the wrong string, but since it's used for getting the previous word for bigrams, it only results in slightly worse suggestions quality. Bug: 11273655 Change-Id: I6ce5de2f76effc453ca691a654ab6bf17445b9e7
-
Jean Chalard authored
This returns the wrong string, but since it's used for getting the previous word for bigrams, it only results in slightly worse suggestions quality. Cherry-pick of I6ce5de2f Bug: 11273655 Change-Id: I17fb6d74f18fb31bd8f8518f80456d74ae30a2c3
-
Jean Chalard authored
This returns the wrong string, but since it's used for getting the previous word for bigrams, it only results in slightly worse suggestions quality. Bug: 11273655 Change-Id: I6ce5de2f76effc453ca691a654ab6bf17445b9e7
-
- Oct 08, 2013
-
-
Jean Chalard authored
This will help handing correctly the armenian full stop. Bug: 10082781 Change-Id: Id7bb219ebd89daba203216eab362d1cc26a65a36
-
- Sep 25, 2013
-
-
Ken Wakasa authored
Followup to If4e44eca3cdc5bb02cf2e0c8c44ecd4bf27fae57 bug: 10622489 Change-Id: If98b2c75725f8692f0c2b41c33e448086404479b
-
- Sep 24, 2013
-
-
Jean Chalard authored
The PARAGRAPH type of span is dangerous, as concatenating CharSequences that contain it may crash. We also don't use other spans than SuggestionSpans, so we don't copy them. Bug: 10622489 Change-Id: If4e44eca3cdc5bb02cf2e0c8c44ecd4bf27fae57
-
- Sep 20, 2013
-
-
Jean Chalard authored
...and do a best effort to fix it. Bug: 10323080 Bug: 10252066 Change-Id: Icb3c9fe85005406bdfce0b7bb143ba0a910a0ddb
-
Jean Chalard authored
It's unclear what the concrete effects of this are, but they are not very strong. This only happens in corner cases, when the input connection is not active - while rotating, for example. Change-Id: I1d22459a6e94a8ecccb53cfcbc2d301b1d502204
-
- Aug 22, 2013
-
-
Kurt Partridge authored
InputConnection#finishComposingText() should not change the position of the cursor, so neither should it change its internal expectation of the cursor's position. Change-Id: Ib3d39a5743cd1e8e356f438b04a5c30279430b2a
-
- Aug 08, 2013
-
-
Jean Chalard authored
Bug: 8911898 Change-Id: Ifb4bb63c14dc960d0a53f1511908830093cca012
-
- Jul 31, 2013
-
-
Jean Chalard authored
Change-Id: I4d36a23567415c3a293a588b51b46006256c148f
-
- Jul 26, 2013
-
-
Jean Chalard authored
Bug: 8864306 Change-Id: Ic8eecd64eff6a1150a90b9f5ec9ebbc5f1d2a6a9
-
Jean Chalard authored
Bug: 8864306 Change-Id: Ia146f711f1de4336d7e3363208ab92eba856f5e1
-
Jean Chalard authored
This reverts commit f712dc9a. It turns out this refactoring is not useful after all. Change-Id: I0145c907b3cc5ac9a30a59abcd719cb546c9bd3a
-
Satoshi Kataoka authored
Bug: 9429906 Change-Id: I576a91643bdaf5017cc826ac2e07a74a9a275d60
-
Jean Chalard authored
Bug: 8864306 Change-Id: I5c9b118cb6a8eb59efc52d5534b10fcab93182d6
-
- Jul 22, 2013
-
-
Ken Wakasa authored
Change-Id: Id170dbfe2dcfc93130b7be4a84615940403ec37f
-
- Jul 02, 2013
-
-
Tadashi G. Takaoka authored
This change also eliminates a reference of AudioAndHapticFeedbackManager from KeyboardSwitcher and MainKeyboard. Bug: 6522943 Change-Id: Iac42ec8ff00c66deb76a660ffc07477923a58959
-