Skip to content
Snippets Groups Projects
  1. Feb 17, 2014
  2. Jan 27, 2014
  3. Jan 20, 2014
  4. Jan 17, 2014
  5. Jan 10, 2014
    • Jean Chalard's avatar
      [IL54] Add a mirror method to fix the cursor pos estimate · ecf46df2
      Jean Chalard authored
      This just mirrors what InputLogic#tryFixLyingCursorPosition
      is doing. That method will go away in the next change.
      
      Change-Id: Ifa2827dbc1f1d20e2c642d6f2d23514a01ed9203
      ecf46df2
    • Jean Chalard's avatar
      [IL53] Fix a wrong test. · 6fbe83be
      Jean Chalard authored
      This test was intended only for cases without a selection, and as
      a safety net for cases where the app would pretend the cursor
      is at N but we can get P chars from the editor where P > N.
      
      When there is a selection, this is wrong. In the practice it works
      because these values are not used in this case, but it's still wrong.
      
      The case where P > N is arguable, but actually I see little reason
      to trust the getTextBeforeCursor() method more than the
      onUpdate selection method. Plus in the practice, I don't think
      we are aware of any app with this bug, and it's probably not a
      great idea to be too robust about this as it may encourage wrong
      values sent to onUpdateSelection.
      
      Change-Id: I42f2065d7aee668074e6b8e40b259da7e88e16e1
      6fbe83be
  6. Jan 09, 2014
  7. Jan 08, 2014
    • Jean Chalard's avatar
      Fix a race condition, take 2. · e5cdcaff
      Jean Chalard authored
      Don't use absolute cursor positions when making edits,
      this leads to race conditions.
      This is a bit ugly and will need to be fixed soon. Plans are
      underway to clean this up.
      
      Bug: 12390573
      Change-Id: I69c09fc41b979880d0800c55a710e39373287cff
      e5cdcaff
    • Jean Chalard's avatar
      Revert "Fix a race condition, take 2." · a247264d
      Jean Chalard authored
      Conflicts prevent this to be cherry-picked.
      
      This reverts commit dd3d697a.
      
      Change-Id: Ib97fae2234633b4bb27d611f48a79060db9ab16f
      a247264d
    • Jean Chalard's avatar
      Fix a race condition, take 2. · dd3d697a
      Jean Chalard authored
      Don't use absolute cursor positions when making edits,
      this leads to race conditions.
      This is a bit ugly and will need to be fixed soon. Plans are
      underway to clean this up.
      
      Bug: 12390573
      Change-Id: Ib42d4149343c642b1b5c1937b424e8afdbd4cc1f
      dd3d697a
  8. Dec 27, 2013
    • Jean Chalard's avatar
      [IL52] Remove a useless method. · 1e50c681
      Jean Chalard authored
      This old method doesn't even re-read the old suggestions. It used to
      recompute them without the coordinates.
      Re-using the recorrection code, which is much more advanced, is
      the right thing to do here.
      
      Also, refining the test. It's no use trying to resume suggestion
      if we don't have a suggestion strip, since we aren't going to
      auto-correct anything anyway.
      
      Not the motivation for this change, but this also fixes
      Bug: 11620256
      Change-Id: Id49efa32e293c49837c61fdc752c86bbac1d2c88
      1e50c681
  9. Dec 13, 2013
    • Ken Wakasa's avatar
      Reset to 9bd6dac4 · 2fa3693c
      Ken Wakasa authored
      The bulk merge from -bayo to klp-dev should not have been merged to master.
      
      Change-Id: I527a03a76f5247e4939a672f27c314dc11cbb854
      2fa3693c
  10. Nov 28, 2013
    • Jean Chalard's avatar
      Fix getNthPreviousWord. · da459787
      Jean Chalard authored
      This should take into accounts word connectors.
      
      Change-Id: Ic7fa5c837cd65a43ba43d7ae9d299b8d20019892
      da459787
  11. Nov 27, 2013
  12. Nov 25, 2013
  13. Nov 16, 2013
  14. Nov 14, 2013
  15. Nov 13, 2013
    • Jean Chalard's avatar
      Fix many small nits. · 3a9b2430
      Jean Chalard authored
      ...the interaction of which results in a very bad bug.
      
      Bug: 11648854
      Change-Id: I774489e384388f187e72b9ac091ab387c5e1a79a
      3a9b2430
    • Jean Chalard's avatar
      Fix many small nits. · 5a0bc6ac
      Jean Chalard authored
      ...the interaction of which results in a very bad bug.
      
      Bug: 11648854
      Change-Id: I774489e384388f187e72b9ac091ab387c5e1a79a
      5a0bc6ac
  16. Nov 07, 2013
  17. Oct 22, 2013
    • Jean Chalard's avatar
      Stopgap solution for a crash. · 8a167537
      Jean Chalard authored
      This returns the wrong string, but since it's used for getting the
      previous word for bigrams, it only results in slightly worse
      suggestions quality.
      
      Bug: 11273655
      Change-Id: I6ce5de2f76effc453ca691a654ab6bf17445b9e7
      8a167537
    • Jean Chalard's avatar
      Stopgap solution for a crash. · 1875860d
      Jean Chalard authored
      This returns the wrong string, but since it's used for getting the
      previous word for bigrams, it only results in slightly worse
      suggestions quality.
      Cherry-pick of I6ce5de2f
      
      Bug: 11273655
      Change-Id: I17fb6d74f18fb31bd8f8518f80456d74ae30a2c3
      1875860d
    • Jean Chalard's avatar
      Stopgap solution for a crash. · 729abe63
      Jean Chalard authored
      This returns the wrong string, but since it's used for getting the
      previous word for bigrams, it only results in slightly worse
      suggestions quality.
      
      Bug: 11273655
      Change-Id: I6ce5de2f76effc453ca691a654ab6bf17445b9e7
      729abe63
  18. Oct 08, 2013
  19. Sep 25, 2013
  20. Sep 24, 2013
    • Jean Chalard's avatar
      Copy only the spans we are interested in. · 3d68b066
      Jean Chalard authored
      The PARAGRAPH type of span is dangerous, as concatenating
      CharSequences that contain it may crash. We also don't use
      other spans than SuggestionSpans, so we don't copy them.
      
      Bug: 10622489
      Change-Id: If4e44eca3cdc5bb02cf2e0c8c44ecd4bf27fae57
      3d68b066
  21. Sep 20, 2013
  22. Aug 22, 2013
    • Kurt Partridge's avatar
      Fix cursor state bug · 6c94a18a
      Kurt Partridge authored
      InputConnection#finishComposingText() should not change the position of the cursor,
      so neither should it change its internal expectation of the cursor's position.
      
      Change-Id: Ib3d39a5743cd1e8e356f438b04a5c30279430b2a
      6c94a18a
  23. Aug 08, 2013
  24. Jul 31, 2013
  25. Jul 26, 2013
  26. Jul 22, 2013
  27. Jul 02, 2013
Loading