Commits · d7970ac3c627b9bf39c23c873ca44218b29dc665 · keyboard / LatinIME

Jun 18, 2021

[automerger skipped] Fix Keyboard Theme update when device orientation changed... · d7970ac3

Ming-Shin Lu authored 3 years ago

[automerger skipped] Fix Keyboard Theme update when device orientation changed am: 6ae09365 -s ours

am skip reason: Merged-In I288a31baf04fa2e63d6b4a14ad81b401cb36ece5 with SHA-1 407f8a32 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/15021672

Change-Id: I3d0ca553f117d3d0871930362f68b87df2105b1c

d7970ac3

Fix Keyboard Theme update when device orientation changed · 6ae09365

Ming-Shin Lu authored 3 years ago

As CL[1] introduces diplayContext to address
IME service context's Resources / DisplayMetrics update when
switching IME window to another display after onConfigurationChange.

In LatinIME#onInitializeInterface, we only update keyboard theme context
and displayContent when the displayId is changed, but overlooked even
the displayId is the same, the display context's resource configuration
might changed like the device orientation changd.

It leads getDefaultKeyboardHeight will get wrong config_max_keyboard_height
fraction value when rotating to landcape because the context resources
didn't get updated.

Add a check to update keyboard theme context when the current display
configuation is changed accordingly.

[1]: I0ed6a079af1ed90c75fee1d36d5ce3ef3c41f8ed

Fix: 186507147
Test: manual as issue steps
    1) Turn on auto-rotate
    2) Open Settings
    3) Rotating the device to landscape mode
    4) Tap “Search settings", verify if the soft-keyboard shown and the
       size is expected.
Change-Id: I288a31baf04fa2e63d6b4a14ad81b401cb36ece5
Merged-In: I288a31baf04fa2e63d6b4a14ad81b401cb36ece5

6ae09365

Jun 17, 2021

[automerger skipped] Bump targetSdkVersion to "30" am: -s ours · 516ab1c9

Yohei Yukawa authored 3 years ago

am skip reason: Merged-In I4bf7588c62fb77bf78d4afcb665e9bfbbef53966 with SHA-1 360052f3 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/14985309

Change-Id: Ifc9ea2e2344d5a501e9ff031410cc4f1da99c38c

516ab1c9

Jun 15, 2021

Bump targetSdkVersion to "30" · 07ce283a

Yohei Yukawa authored 3 years ago

With this CL, versionCode, targetSdkVersion and minSdkVersion will be
bumped/set as follows:

       versionCode: 28 -> 30
  targetSdkVersion: 28 -> 30
     minSdkVersion: 21

As far as we know, there should be no user-visible behavior change on
supported OS versions.

Fix: 189558760
Test: manually verified that LatinIME still is functional
Change-Id: I3a7deb452960b370f5290f3d1bac9c79fe935303
Merged-In: I4bf7588c62fb77bf78d4afcb665e9bfbbef53966
(cherry picked from commit 360052f3)

07ce283a

Merge "Bump targetSdkVersion to "30"" am: am: · a6fbccdd

Treehugger Robot authored 3 years ago

Original change: https://android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/1737355

Change-Id: Ie0ef45d6f1171bd3767bd1a26001e9513a0b94fe

a6fbccdd

Merge "Bump targetSdkVersion to "30"" am: · c7fa63d4

Treehugger Robot authored 3 years ago

Original change: https://android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/1737355

Change-Id: I63caa1f35eeda340064f05c0310d3a5eccbb1690

c7fa63d4

Merge "Bump targetSdkVersion to "30"" · c880212a
Treehugger Robot authored 3 years ago

c880212a

Bump targetSdkVersion to "30" · 360052f3

Yohei Yukawa authored 3 years ago

With this CL, versionCode, targetSdkVersion and minSdkVersion will be
bumped/set as follows:

       versionCode: 28 -> 30
  targetSdkVersion: 28 -> 30
     minSdkVersion: 21

As far as we know, there should be no user-visible behavior change on
supported OS versions.

Fix: 189558760
Test: manually verified that LatinIME still is functional
Change-Id: I4bf7588c62fb77bf78d4afcb665e9bfbbef53966

360052f3

May 28, 2021

Merge "Fix Keyboard Theme update when device orientation changed" am: am: · 9d1ee4ae

Treehugger Robot authored 3 years ago

Original change: https://android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/1721930

Change-Id: Ic168a7cbb656a3939061ad58bd0cc7991c0ceff1

9d1ee4ae

Merge "Fix Keyboard Theme update when device orientation changed" am: · 16a01e7c

Treehugger Robot authored 3 years ago

Original change: https://android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/1721930

Change-Id: I1d756d3f5a24e21b791ec0cd4726dadc1daa0759

16a01e7c

Merge "Fix Keyboard Theme update when device orientation changed" · 7ae00baa
Treehugger Robot authored 3 years ago

7ae00baa

Fix Keyboard Theme update when device orientation changed · 407f8a32

Ming-Shin Lu authored 3 years ago

As CL[1] introduces diplayContext to address
IME service context's Resources / DisplayMetrics update when
switching IME window to another display after onConfigurationChange.

In LatinIME#onInitializeInterface, we only update keyboard theme context
and displayContent when the displayId is changed, but overlooked even
the displayId is the same, the display context's resource configuration
might changed like the device orientation changd.

It leads getDefaultKeyboardHeight will get wrong config_max_keyboard_height
fraction value when rotating to landcape because the context resources
didn't get updated.

Add a check to update keyboard theme context when the current display
configuation is changed accordingly.

[1]: I0ed6a079af1ed90c75fee1d36d5ce3ef3c41f8ed

Fix: 186507147
Test: manual as issue steps
    1) Turn on auto-rotate
    2) Open Settings
    3) Rotating the device to landscape mode
    4) Tap “Search settings", verify if the soft-keyboard shown and the
       size is expected.
Change-Id: I288a31baf04fa2e63d6b4a14ad81b401cb36ece5

407f8a32

Apr 15, 2021

[automerger skipped] Merge "Add lint baseline to address NewApi errors" am:... · e03eca7c

Pedro Loureiro authored 3 years ago

[automerger skipped] Merge "Add lint baseline to address NewApi errors" am: 685abcb9 am: 0605aae4 am: 7e35eb12 -s ours

am skip reason: skip tag Change-Id Ic37bd8c531af7e68c939ce9c05614c37e6699b03 with SHA-1 b47de75a is already in history

Original change: https://android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/1675572

Change-Id: Ibc1f110c41ad148391c842766732892c31340e03

e03eca7c

Merge "Add lint baseline to address NewApi errors" am: am: · 7e35eb12

Pedro Loureiro authored 3 years ago

Original change: https://android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/1675572

Change-Id: I1dca662027a09c4377349f1cc59e7bd5317d1e2a

7e35eb12

Merge "Add lint baseline to address NewApi errors" am: · 0605aae4

Pedro Loureiro authored 3 years ago

Original change: https://android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/1675572

Change-Id: I7d81740175550e0be44ac9069bfa6e2f1fb8716d

0605aae4

Merge "Add lint baseline to address NewApi errors" · 685abcb9
Pedro Loureiro authored 3 years ago

685abcb9

Apr 13, 2021

Add lint baseline to address NewApi errors · 57d4aef2

Pedro Loureiro authored 4 years ago

We are enabling a new lint check where the min sdk != compile sdk.
It has produced a lot of errors and adding the baseline file(s)
allows us to continue work without introducing more problems.

Bug: 150847901

Test: m lint-check
Change-Id: Ic37bd8c531af7e68c939ce9c05614c37e6699b03
Merged-In: Ic37bd8c531af7e68c939ce9c05614c37e6699b03

57d4aef2

Apr 12, 2021

Add lint baseline to address NewApi errors · b47de75a

Pedro Loureiro authored 4 years ago

We are enabling a new lint check where the min sdk != compile sdk.
It has produced a lot of errors and adding the baseline file(s)
allows us to continue work without introducing more problems.

Bug: 150847901

Test: m lint-check
Change-Id: Ic37bd8c531af7e68c939ce9c05614c37e6699b03

b47de75a

Feb 21, 2021

[automerger skipped] Mark ab/7061308 as merged in stage. am: -s... · 86bf93cd

Xin Li authored 4 years ago

[automerger skipped] Mark ab/7061308 as merged in stage. am: b7027a66 -s ours am: 8a739fb0 -s ours

am skip reason: Change-Id Ie1a0307f3c8f3fc4013b4395cb843f1a96d32b6d with SHA-1 644c0062 is in history

Original change: undetermined

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I9ad294a9e69b8745bfee510271ab83e3ef1e8d2d

86bf93cd

Merge "[LSC] Add LOCAL_LICENSE_KINDS to packages/inputmethods/LatinIME" am:... · a2330e5f

Bob Badour authored 4 years ago

Merge "[LSC] Add LOCAL_LICENSE_KINDS to packages/inputmethods/LatinIME" am: 27f85439 am: 155f6bbb am: 4fd407ab

Original change: https://android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/1588514

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I154b31a133b0b6b756a536f1c5a6c6e1b62ef1b9

a2330e5f

Feb 20, 2021

[automerger skipped] Mark ab/7061308 as merged in stage. am: -s ours · 8a739fb0

Xin Li authored 4 years ago

am skip reason: Change-Id Ie1a0307f3c8f3fc4013b4395cb843f1a96d32b6d with SHA-1 644c0062 is in history

Original change: undetermined

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: Ieabf19901256253b47b767a3639b14fd3ece89a5

8a739fb0

Mark ab/7061308 as merged in stage. · b7027a66

Xin Li authored 4 years ago

Bug: 180401296
Merged-In: Ie1a0307f3c8f3fc4013b4395cb843f1a96d32b6d
Change-Id: I833ab148ad9f4632a639c45b97d0b6aebd7471f1

b7027a66

Feb 19, 2021

Merge "[LSC] Add LOCAL_LICENSE_KINDS to packages/inputmethods/LatinIME" am:... · 4fd407ab

Bob Badour authored 4 years ago

Merge "[LSC] Add LOCAL_LICENSE_KINDS to packages/inputmethods/LatinIME" am: 27f85439 am: 155f6bbb

Original change: https://android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/1588514

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I8ff8434dbc8097b1b1c6d36b9e652166ac19c326

4fd407ab

Merge "[LSC] Add LOCAL_LICENSE_KINDS to packages/inputmethods/LatinIME" am: · 155f6bbb

Bob Badour authored 4 years ago

Original change: https://android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/1588514

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I5d0e72a1db85341c5c0139b7db54862c074d6bbd

155f6bbb

Merge "[LSC] Add LOCAL_LICENSE_KINDS to packages/inputmethods/LatinIME" · 27f85439
Bob Badour authored 4 years ago

27f85439

Feb 17, 2021

[LSC] Add LOCAL_LICENSE_KINDS to packages/inputmethods/LatinIME · f3d9532a

Bob Badour authored 4 years ago

Added SPDX-license-identifier-Apache-2.0 to:
  Android.bp
  common/Android.bp
  java/Android.bp
  native/dicttoolkit/Android.bp
  native/jni/Android.bp
  tests/Android.bp
  tools/EditTextVariations/Android.bp
  tools/dicttool/Android.bp
  tools/make-keyboard-text/Android.bp

Bug: 68860345
Bug: 151177513
Bug: 151953481

Test: m all

Exempt-From-Owner-Approval: janitorial work
Change-Id: I440008bffac5c97a2497970af377a9d03262b6d8

f3d9532a

Merge "Mark liblatinime_unittests as unit_test:true to run in presubmit in CI"... · 936ca12a

Treehugger Robot authored 4 years ago

Merge "Mark liblatinime_unittests as unit_test:true to run in presubmit in CI" am: e04480b6 am: 7471a535 am: ecd2dab2

Original change: https://android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/1589854

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I8458c3d58fe2efc428a69c4591c5b87bfcbd1035

936ca12a

Merge "Mark liblatinime_unittests as unit_test:true to run in presubmit in CI"... · ecd2dab2

Treehugger Robot authored 4 years ago

Merge "Mark liblatinime_unittests as unit_test:true to run in presubmit in CI" am: e04480b6 am: 7471a535

Original change: https://android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/1589854

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I4dc6006500214b819d459dc514541a06ca8cd33a

ecd2dab2

Merge "Mark liblatinime_unittests as unit_test:true to run in presubmit in CI" am: · 7471a535

Treehugger Robot authored 4 years ago

Original change: https://android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/1589854

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: Idd588629cd634ebf3772d16bce882bc5b1732362

7471a535

Merge "Mark liblatinime_unittests as unit_test:true to run in presubmit in CI" · e04480b6
Treehugger Robot authored 4 years ago

e04480b6

Feb 16, 2021

Merge "Fix broken liblatinime_unittests" am: am: am: · 8d3ca331

Treehugger Robot authored 4 years ago

Original change: https://android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/1589747

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I942d720895724ae24a241a59c3feaf71b5d2cba2

8d3ca331

Merge "Fix broken liblatinime_unittests" am: am: · 326ff853

Treehugger Robot authored 4 years ago

Original change: https://android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/1589747

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I6dd60fb5d01feed612f81fbb33adf07b1abec0cc

326ff853

Merge "Fix broken liblatinime_unittests" am: · 5e1756c5

Treehugger Robot authored 4 years ago

Original change: https://android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/1589747

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I15fc9d572d67f9d8aabb699636d18f642f30cd02

5e1756c5

Merge "Fix broken liblatinime_unittests" · 62013c4f
Treehugger Robot authored 4 years ago

62013c4f

Mark liblatinime_unittests as unit_test:true to run in presubmit in CI · b19114e9

Julien Desprez authored 4 years ago

This will ensure that the target stays green.
Note: we will clean up the explicit unit_tests:true once cc_test default is changed.

Change-Id: I5153ca918e94b370b1f08289118877d209385ba2
Test: presubmit
Bug: 180014759

b19114e9

Fix broken liblatinime_unittests · 8b3d8f48

Adrian Roos authored 4 years ago

Change-Id: I95021965ecc2699fbce01ed0552dd28fed7f8fe4
Merged-In: I95021965ecc2699fbce01ed0552dd28fed7f8fe4
Fixes: 180014759
Test: atest liblatinime_unittests --host

8b3d8f48

Nov 23, 2020

Mark ab/6881855 as merged am: am: · a9bbf1d3

Xin Li authored 4 years ago

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/13112993

Change-Id: I6c52501a762dee138a8d24b7b7ad30e1c64d5c1f

a9bbf1d3

Mark ab/6881855 as merged am: · 644c0062

Xin Li authored 4 years ago

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/13112993

Change-Id: Ie1a0307f3c8f3fc4013b4395cb843f1a96d32b6d

644c0062

Mark ab/6881855 as merged · 478d45fd
Xin Li authored 4 years ago
```
Bug: 172690556
Change-Id: If9cf64206ba6c851ac2d72a5682a5481b25f4764
```
478d45fd

Oct 09, 2020

[automerger skipped] Skip ab/6749736 in stage. am: -s ours am:... · b448164a

Xin Li authored 4 years ago

[automerger skipped] Skip ab/6749736 in stage. am: 587c1724 -s ours am: 962c1dd4 -s ours am: 99b23497 -s ours

am skip reason: Change-Id Idac165021a2a4835aaefeff5dc4aa9086f91015b with SHA-1 ccfef108 is in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/12797210

Change-Id: I1a8305513cb63b218647942567bbffcd1d1a2041

b448164a