Skip to content
Snippets Groups Projects
Select Git revision
  • master default protected
  • trie-js-dumping protected
  • hitbox-boosting protected
  • model-metadata protected
  • lm-2-finetuning-whisperggml protected
  • lm-2-finetuning protected
  • lm-2 protected
  • language_model_experiments protected
  • 0.1.24.2 protected
  • 0.1.24.2-rc1 protected
  • 0.1.24.1 protected
  • 0.1.24.1-rc1 protected
  • 0.1.24 protected
  • 0.1.24-rc1 protected
  • 0.1.23.2 protected
  • 0.1.23.1 protected
  • 0.1.23 protected
  • 0.1.22 protected
  • 0.1.21 protected
  • 0.1.20 protected
  • 0.1.19 protected
  • 0.1.18 protected
  • 0.1.17 protected
  • 0.1.16 protected
  • 0.1.15 protected
  • 0.1.14.1 protected
  • 0.1.14 protected
  • 0.1.13 protected
28 results
Search by author
  • Any Author
0 authors
  1. Apr 25, 2012
  3. Apr 24, 2012
    • Tom Ouyang's avatar
      Change expandable binary dict write to a temp file first. · a9b2be8a
      Tom Ouyang authored 
      Bug: 6380724
Change-Id: Ic1d0d902dc45ecb41a1792f33a60ab85e606fcef
      a9b2be8a
    • Tadashi G. Takaoka's avatar
      Revert keyHintLetterPadding only to apply horizontally · ab771b01
      Tadashi G. Takaoka authored 
      Partially reverts the Ia3680d84.

Bug: 6356125
Change-Id: I8faa810b833cb98ce6f0f760aa1722e63475cd45
      ab771b01
    • Tadashi G. Takaoka's avatar
      Add header commnets of KeyboardTextsSet.tmpl · aaac9a52
      Tadashi G. Takaoka authored 
      Bug: 6371604
Change-Id: I1054685b9985b6923e3176679b3d95424d8114e0
      aaac9a52
    • Jean Chalard's avatar
      Fix binary reading code performance. · 1d80a7f3
      Jean Chalard authored 
      This is not the Right fix ; the Right fix would be to read
the file in a buffered way. However this delivers tolerable
performance for a minimal amount of code changes.
We may want to skip submitting this patch, but keep it around
in case we need to use the functionality until we have a good
patch.

Change-Id: I1ba938f82acfd9436c3701d1078ff981afdbea60
      1d80a7f3
    • Jean Chalard's avatar
      Fix a bug where a node size would be seen as increasing. · a64a1a46
      Jean Chalard authored 
      The core reason for this is quite shrewd. When a word is a bigram
of itself, the corresponding chargroup will have a bigram referring
to itself. When computing bigram offsets, we use cached addresses of
chargroups, but we compute the size of the node as we go. Hence, a
discrepancy may happen between the base offset as seen by the bigram
(which uses the recomputed value) and the target offset (which uses
the cached value).
When this happens, the cached node address is too large. The relative
offset is negative, which is expected, since it points to this very
charnode whose start is a few bytes earlier. But since the cached
address is too large, the offset is computed as smaller than it should
be.
On the next pass, the cache has been refreshed with the newly computed
size and the seen offset is now correct (or at least, much closer to
correct). The correct value is larger than the previously computed
offset, which was too small. If it happens that it crosses the -255 or
-65335 boundary, the address will be seen as needing 1 more byte than
previously computed. If this is the only change in size of this node,
the node will be seen as having a larger size than previously, which
is unexpected. Debug code was catching this and crashing the program.

So this case is very rare, but in an even rarer occurence, it may
happen that in the same node, another chargroup happens to decrease
it size by the same amount. In this case, the node may be seen as
having not been modified. This is probably extremely rare. If on
top of this, it happens that no other node has been modified, then
the file may be seen as complete, and the discrepancy left as is
in the file, leading to a broken file. The probability that this
happens is abyssally low, but the bug exists, and the current debug
code would not have caught this.
To further catch similar bugs, this change also modifies the test
that  decides if the node has changed. On grounds that all components
of a node may only decrease in size with each successive pass, it's
theoritically safe to assume that the same size means the node
contents have not changed, but in case of a bug like the bug above
where a component wrongly grows while another shrinks and both cancel
each other out, the new code will catch this. Also, this change adds
a check against the number of passses, to avoid infinite loops in
case of a bug in the computation code.

This change fixes this bug by updating the cached address of each
chargroup as we go. This eliminates the discrepancy and fixes the
bug.

Bug: 6383103
Change-Id: Ia3f450e22c87c4c193cea8ddb157aebd5f224f01
      a64a1a46
    • Tadashi G. Takaoka's avatar
      Make the "Touch again to save" hint text touchable. · 9f763d14
      Tadashi G. Takaoka authored 
      Bug: 6355346
Change-Id: I96933719cc94f25e6c7ecb1d6345c11b6acc4134
      9f763d14
    • Tadashi G. Takaoka's avatar
      Fix NPE in AdditionalSubtypeSettings · 3e3bb36f
      Tadashi G. Takaoka authored 
      Bug: 6384416
Change-Id: I878071b8b78acce51649f9637b59830ab681c696
      3e3bb36f
  5. Apr 23, 2012
  7. Apr 22, 2012
  9. Apr 20, 2012
  11. Apr 19, 2012