Skip to content
Snippets Groups Projects
Select Git revision
  • master default protected
  • trie-js-dumping protected
  • hitbox-boosting protected
  • model-metadata protected
  • lm-2-finetuning-whisperggml protected
  • lm-2-finetuning protected
  • lm-2 protected
  • language_model_experiments protected
  • 0.1.24.2 protected
  • 0.1.24.2-rc1 protected
  • 0.1.24.1 protected
  • 0.1.24.1-rc1 protected
  • 0.1.24 protected
  • 0.1.24-rc1 protected
  • 0.1.23.2 protected
  • 0.1.23.1 protected
  • 0.1.23 protected
  • 0.1.22 protected
  • 0.1.21 protected
  • 0.1.20 protected
  • 0.1.19 protected
  • 0.1.18 protected
  • 0.1.17 protected
  • 0.1.16 protected
  • 0.1.15 protected
  • 0.1.14.1 protected
  • 0.1.14 protected
  • 0.1.13 protected
28 results
Search by author
  • Any Author
  • Aleksandras Kostarevas Aleksandras Kostarevas alex
  • Dean Dean dean
  • Tom Folbrecht Tom Folbrecht tom
  • sameer sameer sameer
4 authors
  1. Nov 13, 2013
    • Jean Chalard's avatar
      Fix many small nits. · 5a0bc6ac
      Jean Chalard authored 
      ...the interaction of which results in a very bad bug.

Bug: 11648854
Change-Id: I774489e384388f187e72b9ac091ab387c5e1a79a
      5a0bc6ac
  3. Nov 08, 2013
  5. Nov 07, 2013
  7. Nov 06, 2013
  9. Nov 05, 2013
  11. Oct 29, 2013
  13. Oct 28, 2013
  15. Oct 25, 2013
  17. Oct 22, 2013
  19. Oct 21, 2013
  21. Oct 18, 2013
  23. Oct 17, 2013
  25. Oct 16, 2013
    • Jean Chalard's avatar
      Remove useless code. · 548716d6
      Jean Chalard authored 
      The only use of mDeleteCount is to implement delete
acceleration. It's reset at each non-delete code point, and
is guarded by a timer.
Plus, ultimately we want to remove this completely :
acceleration should be implemented by actually deleting
stuff faster, not by deleting several code points at a time.

Change-Id: Ia3144860b3aa2499034f2a2a7c81f32087af9598
      548716d6
    • Jean Chalard's avatar
      Remove mIsExpectingUpdateSelection. · 1194b2b2
      Jean Chalard authored 
      Bug: 11226045
Change-Id: I043f90ba92989bd8307c978eb32630439f63a0b9
      1194b2b2
    • Jean Chalard's avatar
      Remove unneeded code. · 497976e0
      Jean Chalard authored 
      We don't support LOG_FULL_TEXTVIEW_CONTENTS any more, nor do
we have any plans to support it again in the future.

This also is a prelude to removing mIsExpectingUpdateSelection.

Bug: 11226045
Change-Id: Ib68c6daf52993b87225a7ea9e71a414caaecfdb7
      497976e0
    • Yuichiro Hanada's avatar
      Add SparseContentTableReader. · 098639d9
      Yuichiro Hanada authored 
      Change-Id: I976afc5d320bc65835d659bae1d10d2cdc68262b
      098639d9
    • Yuichiro Hanada's avatar
      Fix Ver4DictDecoder.readAndFollowForwardLink(). · 7b5f2b71
      Yuichiro Hanada authored 
      Change-Id: Ib527a376b693be21aebd4920ac804ee9b161eb96
      7b5f2b71
    • Yuichiro Hanada's avatar
      Extract SparseTableContentWriter. · ed831f38
      Yuichiro Hanada authored 
      Change-Id: I9a58e53317654f8a09fbe79044214de3e9c59eb7
      ed831f38
  27. Oct 15, 2013
    • Yuichiro Hanada's avatar
      Consolidate CharEncoding.writeString and BinaryDictIOUtils.writeString. · 1557de7a
      Yuichiro Hanada authored 
      Change-Id: I6f990fd84e7f08fd1149198c33d8bbf1cac8e078
      1557de7a
    • Yuichiro Hanada's avatar
      Fix readAndFollowForwardLink. · 522dc0d8
      Yuichiro Hanada authored 
      Change-Id: Ifda44e6139a4a1bd065468a7f74cd9483b343644
      522dc0d8
    • Ken Wakasa's avatar
      mExpectingUpdateSelection was out of sync when nothing to delete. · b0440472
      Ken Wakasa authored 
      cherripick of I9c6a948331726a821bd3ccec9c1d02dec2c4703a
(forward cherrypicking this because the automerger is stuck now.)

This bug was leading to corrupted rendering of surrogate pairs in the following
scenario.

1. Type some emojis
2. Move the cursor at the beginning of the text field
3. Hit backspace even though there's nothing to delete
4. Move the cursor after some emoji
5. Hit backspace

The root cause of this issue was the out-of-sync mExpectingUpdateSelection if
handleBackspace() gets called when the cursor reaches at the beginning of the
TextView. In such case, mExpectingUpdateSelection shouldn't be set true because
there's nothing to delete, so there will be no onUpdateSelection() calls associated
with it. Due to this bug, the cache in RichInputConnection could get stale at step 4
described above. Then the following handleBackspace() that should delete a surrogate
pair was not working correctly because of the stale cache.

bug: 11181913
Change-Id: I1cbf444d8d105416e7de75c16d80b3797f470495
      b0440472
  29. Oct 14, 2013
    • Ken Wakasa's avatar
      mExpectingUpdateSelection was out of sync when nothing to delete. · b9ce8421
      Ken Wakasa authored 
      This bug was leading to corrupted rendering of surrogate pairs in the following
scenario.

1. Type some emojis
2. Move the cursor at the beginning of the text field
3. Hit backspace even though there's nothing to delete
4. Move the cursor after some emoji
5. Hit backspace

The root cause of this issue was the out-of-sync mExpectingUpdateSelection if
handleBackspace() gets called when the cursor reaches at the beginning of the
TextView. In such case, mExpectingUpdateSelection shouldn't be set true because
there's nothing to delete, so there will be no onUpdateSelection() calls associated
with it. Due to this bug, the cache in RichInputConnection could get stale at step 4
described above. Then the following handleBackspace() that should delete a surrogate
pair was not working correctly because of the stale cache.

bug: 11181913
Change-Id: I9c6a948331726a821bd3ccec9c1d02dec2c4703a
      b9ce8421
  31. Oct 13, 2013
  33. Oct 11, 2013