A lot of things don't really make sense in the old code.
Let's streamline it for now so that we have a cleaner interface
to work with. This is preliminary work for bug 4192129.

Change-Id: If01a5974cfadc43afced610c57fcf7fde67c1346

Change-Id: I128134e201273b00478beb3d091952dd5530230c

* commit 'f87df70c':
  Fix centering more suggestions panel on tablet (DO NOT MERGE)

KeyDetector should use the distance from the hit box to detect the
key.

Bug: 6174250
Change-Id: Id1745d90222d1d1a10467f194b45307c12449944

Change-Id: I78f22bb38222fea54a55e460fcf728bf941d15e9

Bug: 6174065
Change-Id: I702760d44ead0eeb60d06360aa3bb03c2ec73325

Exit-fast, update comment, make a method private

Change-Id: Id103bf03aeef43a1a4d064ecabb819490dc5d39a

I tracked all the calls to the constructor, and the passed
list is never null. It's also final, so it's safe.

Change-Id: I320f907acee0b237bb286a9a183c18106809174a

Change-Id: Ia1c80eeff00a55573bb311f07e1275da23bdcf98

Change-Id: I58de87c1ba4cd1130419191f63ff83b685604356

All calls to this methods are made with an actual String. No sense
beating ourselves with an interface stick.

Change-Id: I6ef98286be6f81f73864b04f3a17e68f36a6e542

Change-Id: I6950897d262f610d502b7f8293b9dd8d2b53e6e8

This has been moved to the SuggestedWords object and is now
represented by a single flag instead of a flag in each suggestion.

Change-Id: I6e9a7cff5a7701de7e61b4de13baac25c9a87b1b

Also, the first word in a sugestions list can never be
obsolete.

Change-Id: Ib21439aac8db4e6ce5b15b7a2aabe4222bc354db

Change-Id: I9684c7b08244b34853ce8a99b6e9d885389f6687

Change-Id: I43dae30774c40a9d6e7396f8fa73ed4b82a7c777

Change-Id: I5aee4c36ceaacbb1dbfc47c011f1e4aec4b9dca6

Change-Id: I792cacc137b1b782c28b258bf91bf475bd0ced89

Bug: 4343280

Test:  I11f8518d9ee

Change-Id: I4b90bdffffed9736af223ac83c1a54019add70bb

Bug: 6128215
Change-Id: I81e9980f8ffa5c5eaba30676c8433f542645de1d

Bug: 6128215
Change-Id: Ie9c13d9d38aad6e92cc465e22f3ef20c80e0a36a

Change-Id: Ide3f605ce40e8c230f217bbf37ab016457ee91f1

Bug: 4343280
Change-Id: Id24935f9f0f66ebaa799bb92537d842033427c4c

This partially reverts Ie0554362.

Change-Id: I0de971c5efb4e8eb093be2a0793a08bd79baee22

In-place replacements of visibly identical things.

Change-Id: I02b51bd7f63597e3428f0650b239e9a39ef5a7c7

Change-Id: I791700890338e023bd86b8794dbc90379b91dc7d

We know the size in advance, this may save a few allocations

Change-Id: I2fb9a725f34ba2da4f34ed335652f10447d5d166

Just write the same thing in a more succint manner

Change-Id: I08a2c5edd52a3502914541061fd5b6ee7a92ebc4

Renaming some variables, and obvious optimizations.

Change-Id: Ib716748e9f3d602cf276dcd4e73f3bcfb819585e

Change-Id: I03005240238fb004c20b2df0d836796e2e8b307f