Skip to content
Snippets Groups Projects
  1. Aug 26, 2023
  2. Aug 22, 2023
  3. Aug 19, 2023
  4. Aug 18, 2023
  5. Aug 15, 2023
  6. Aug 14, 2023
  7. Aug 11, 2023
  8. Jul 06, 2023
  9. Mar 20, 2023
  10. Mar 19, 2023
    • Jing Mike's avatar
      Remove unused variables · 03eef94a
      Jing Mike authored
      
      Since some variables with module LatinIME are defined but not used,
      when compiled with build combination "sdk_pc_x86_64-userdebug" and
      build command "mmm packages/inputmethods/LatinIME", the following
      code lines will be reported that "variable 'XXX' set but not used".
      (should be similar for all the other build combinations)
      
      Repeated 10 times for each:
      terminal_position_lookup_table.cpp:74:9 removedEntryCount
      terminal_position_lookup_table.cpp:85:9 removedEntryCount
      proximity_info_state_utils.cpp:493:9 tempTime
      trie_map.cpp:56:9 unusedRegionSize
      suggestion_results.cpp:100:9 index
      
      Repeated 80+ times:
      proximity_info_utils.h:75:25 proximityChar
      
      With this patch we are removing some of the unused variables and
      putting the C++ 17 attribute [[maybe_unused]] to the others which
      are used for logging. Then all the related build warnings have been
      eliminated.
      
      Test: mmm packages/inputmethods/LatinIME, presubmit check.
      
      Change-Id: Ia66766322d6ae8a010b1cb55cc22993fbc6d012c
      Signed-off-by: default avatarJing Mike <jingyangliu@eswincomputing.com>
      03eef94a
  11. Oct 17, 2022
  12. Aug 24, 2022
Loading