Skip to content
Snippets Groups Projects
  1. Jan 09, 2014
  2. Jan 08, 2014
  3. Jan 07, 2014
  4. Jan 06, 2014
  5. Dec 27, 2013
    • Jean Chalard's avatar
      [IL52] Remove a useless method. · 1e50c681
      Jean Chalard authored
      This old method doesn't even re-read the old suggestions. It used to
      recompute them without the coordinates.
      Re-using the recorrection code, which is much more advanced, is
      the right thing to do here.
      
      Also, refining the test. It's no use trying to resume suggestion
      if we don't have a suggestion strip, since we aren't going to
      auto-correct anything anyway.
      
      Not the motivation for this change, but this also fixes
      Bug: 11620256
      Change-Id: Id49efa32e293c49837c61fdc752c86bbac1d2c88
      1e50c681
    • Jean Chalard's avatar
      [IL51] Make private what can be made private · 8ce921dd
      Jean Chalard authored
      Bug: 8636060
      Change-Id: Ifa027de465a421b67897d51e9ad47666dda117ad
      8ce921dd
    • Jean Chalard's avatar
      [IL50] Move the InputUpdater out of LatinIME. · 53c320e2
      Jean Chalard authored
      ...at last
      
      Bug: 8636060
      Change-Id: If5e27a9d28ff64d318dd76792f55edfc8a78d2d7
      53c320e2
    • Jean Chalard's avatar
      [IL49] Move InputLogic-related init code to InputLogic. · 81e0ca5f
      Jean Chalard authored
      Bug: 8636060
      Change-Id: Ie5027512f066d9c530a686ac559e4649a39bf439
      81e0ca5f
    • Jean Chalard's avatar
      Fix a failing test · 4970eda2
      Jean Chalard authored
      How/when did this happen? How was it not noticed?
      
      Change-Id: I352a8dad65f8c27bf5120d567e96d9a12cfa8496
      4970eda2
    • Jean Chalard's avatar
      [IL48] Move onEndBatchInputAsyncInternal to InputLogic. · c654fe57
      Jean Chalard authored
      Bug: 8636060
      Change-Id: Idfabf7231a80e21786ce1910b5140bb3dddcac7d
      c654fe57
    • Jean Chalard's avatar
      [IL47] Inline getSuggestedWordsGestureLocked · 4a144b9b
      Jean Chalard authored
      This method is confusing with the *Locked convention, and
      the two-step call creates a useless callback object. This is
      better inlined both for readability and for performance.
      
      Bug: 8636060
      Change-Id: I7c427c3ca4e831388a6d54de6728b32206a45d80
      4a144b9b
    • Jean Chalard's avatar
      [IL46] Remove a useless message passing. · 71a3e963
      Jean Chalard authored
      The only point of this message is to send the processing on another
      thread. However, this will be accomplished later.
      Here is the exact call graph:
      0. onUpdateBatchInput
      1. -> MSG_UPDATE_GESTURE_PREVIEW_AND_SUGGESTION_STRIP
      2. -> updateBatchInputSync
      3. -> getSuggestedWordsGestureLocked
      4. -> MSG_GET_SUGGESTED_WORDS
      5. -> LatinIME#getSuggestedWords
      
      The point of both step 1. and step 4. is to make sure the processing
      is happening on the InputUpdater thread. Thus, it's useless to do
      it twice.
      
      Bug: 11326092
      Bug: 8636060
      Change-Id: Iceebb9e8879a8f15b73c987f5fd3489f27699be4
      71a3e963
    • Jean Chalard's avatar
      [IL45] Remove lingering messages · 31ff2a43
      Jean Chalard authored
      Bug: 8636060
      And possibly bug: 12085864
      
      Change-Id: I867036bc3d8bd255dc8ceebdd30e28b4b3dc4b2d
      31ff2a43
    • Jean Chalard's avatar
      [IL44] Some factorization · 69e7a0d2
      Jean Chalard authored
      This sheds some light on what's happening here. Some
      comments were at least misleading, maybe indicating something
      is not sequenced as intended.
      
      Bug: 8636060
      Change-Id: Ia74feb457a39fe4a672c27fe4203264fda940f04
      69e7a0d2
    • Keisuke Kuroyanagi's avatar
      Fix possible NPE in FileUtils. · 86da47e8
      Keisuke Kuroyanagi authored
      Change-Id: I503f91e266c71e2370a5807d171e2254c334f7cb
      86da47e8
    • Keisuke Kuroyanagi's avatar
      Make setAdditionalDictionaries private. · abc3d0eb
      Keisuke Kuroyanagi authored
      Bug: 8187060
      Change-Id: I17be7b77ff89972d3ca6823b087b7bf35105af56
      abc3d0eb
  6. Dec 26, 2013
  7. Dec 25, 2013
Loading