- Jul 10, 2012
-
-
Jean Chalard authored
Use the word the same way for suggestion and prediction. It makes little logical sense that the trailing single quotes be removed for suggestion lookup but not for prediction lookup. Change-Id: I0de4b5f7c5b4c1b4ba1817ff9653d7c03967146d
-
Jean Chalard authored
Avoid special casing the whitelist dictionary by having it implement the interface it pretends it implements Change-Id: I8b873cb0f3fe13cefd32c8cb756a25c8ae16a2b4
-
Jean Chalard authored
The user history dictionary should be the one knowing it does not suggest words beyond 2 characters, not Suggest. Change-Id: Ie85ec6116eb495e0c7f51108e4620c5ae536f4bf
-
Jean Chalard authored
Bug: 6788235 Change-Id: I5a4212872e0fd3f9e80168fd3abd5c2b3bc4110f
-
- Jul 04, 2012
-
-
Jean Chalard authored
...if there aren't any for the exact case version. Bug: 6752830 Change-Id: I2737148b01ba04a64febe009ceb2ef53c265d224
-
Jean Chalard authored
It's simpler to check the safety net directly inside the function that checks for auto-correction threshold. This introduces one very slight change in behavior. The value checked by the safety net is not any more the "typed word" but the "considered word", the difference being any possibly appended single quotes. E.g. the user types "this'''" : the typed word is "this'''" but the considered word is "this". This change in behavior can be considered a bugfix. Change-Id: Ia7ab4bc933183dfbd41bb00328e4c0b5ab76bc63
-
Jean Chalard authored
Change-Id: Iec791d061f237f60992dd6048c4a37b46f4cb9aa
-
- Jul 02, 2012
-
-
Jean Chalard authored
Change-Id: Ib0b6f36999518096819ada2f19365767cb5f9931
-
Jean Chalard authored
If allowsAutoCorrected is false, there is no point in making hasAutoCorrection true, since in the only place where we use it again, it's &&'ed with allowsAutoCorrected ! Well that was extremely obscure, good thing refactoring allowed to realize this was useless >.> Change-Id: I34936d445f1ced17c7bd04a9524bf608f9e8b9c8
-
Jean Chalard authored
The test against hasMainDictionary is a test to know if we should auto-correct or not. Its result should be recorded in hasAutoCorrection, not in allowsToBeAutoCorrected. Actually, this value being inserted in allowsToBeAutoCorrected was causing a bug that nobody noticed: when typing in a language with no dictionary, the word in the middle of the suggestion strip would always be bold, as if it was going to auto-correct to itself ! This change fixes this bug. Change-Id: Ia1f08efd7089b9c5cbede910c5b0951d83e698d2
-
Jean Chalard authored
Change-Id: I3c45b5a6571f986acc7adb3a8fe17b210303f7ea
-
Jean Chalard authored
Change-Id: I2b2ab99e801fa8b4b30eab16a8aefb8cfe104ba9
-
Jean Chalard authored
Change-Id: I4833ca7e057b8c1f1f22390673cbca0d2433b1bd
-
- Jun 29, 2012
-
-
Jean Chalard authored
Change-Id: I35c2ba4caf6be4ba0449e11c0597ae8e468c0e6e
-
Jean Chalard authored
Change-Id: I9e4d030974ccec1a6256de6ca87610870e404149
-
Jean Chalard authored
Change-Id: I41b413986a3c5bb6697bb7bbced17ed1e361913c
-
Jean Chalard authored
Change-Id: I1d7790289635729645995fb8c38868259ab1b3be
-
Jean Chalard authored
Change-Id: I52625e707abf61da9b95e542f0814c66b532f483
-
Jean Chalard authored
isWhitelistedOrNotAWord takes an 'ignoreCase' argument. By looking at the contents of the wordcomposer here, there is only one case where its output will be different : when the word is typed with a capital, but the lower case version exists in the dictionary. E.g. the user typed "This". In this case, isWhitelistedOrNotAWord in line 235 will return false instead of true, so the test will score a true instead of a false, so hasAutoCorrection may be true instead of false in this specific case and that's the only case where it's different. But in this case, allowsToBeAutoCorrected is certain to be false, which means the result will not have changed if hasAutoCorrection was true in the first place. So in the end this change is sure not to change the behavior. Change-Id: Ic41cf959c20c19165f84d9b8ff006731fa595d84
-
Jean Chalard authored
Change-Id: Ia356130b8a95ec9cf676bc6be05d801c13f14b64
-
Jean Chalard authored
Change-Id: I6f569322e645d36bc82fddf4ec2fd621972e3b47
-
Jean Chalard authored
Change-Id: I1df4cef5ae2736a22273843dce67f0012181bfd3
-
Jean Chalard authored
Change-Id: I901e6b0e2b994128da19d68233b9f68bb308cb95
-
Jean Chalard authored
Change-Id: Ifc37462f5243563693c8cd7cbeb401ff054daa52
-
Jean Chalard authored
Change-Id: I0b8c06d1fd0bfb3caf363c048acc7048abed1752
-
Jean Chalard authored
allowsToBeAutoCorrected always returns false if the word is empty. This is because the whitelist never contains an empty string, and isValidWord returns false if the word is empty. Change-Id: I34ecc2a1563aea6db5b2f12796f251f6598576a2
-
Jean Chalard authored
This will allow us to remove unnecessary processing Change-Id: I251dfdaffb077906186686ebe65fd82e1e360bd2
-
Jean Chalard authored
Change-Id: Ib74fcbf33c680bf02c39a9896e30e3afbcfd149a
-
Jean Chalard authored
The new code is worse than the old one, but this is a necessary step to make things prettier. Change-Id: If6e8a139bb85e6920c749743c78792a22a8acb45
-
Jean Chalard authored
Change-Id: Iba326921711e1c4eab38264e66b6b44a64fec398
-
Jean Chalard authored
Change-Id: I2b9e8cc6a13fd9af84a5189e4d3fbb2b05c68d46
-
- Jun 28, 2012
-
-
Jean Chalard authored
Change-Id: Iba97e0062b702c005ab3ff9ce59f181d19ab7c98
-
Jean Chalard authored
Treat it like the others Change-Id: Ic24e40ada0e75773c3ece9470ab61c350697be5d
-
Jean Chalard authored
Change-Id: I06134145b47c46bbc6c340ca539f34a01e2ca163
-
Jean Chalard authored
...instead of having a different code path Change-Id: Icd177e2151e45d25300000d4b63d4fba1f52b6a8
-
Jean Chalard authored
This will help make upcoming changes clearer Change-Id: Ida8d4935f7315e5da6007ad364124694da3112d0
-
Jean Chalard authored
Change-Id: Ic367836202ab8071c1a9a02eaf0651b0da947d51
-
Jean Chalard authored
Change-Id: I16ba39321107e87ad48a99c2410a15995a66f23c
-
- Jun 27, 2012
-
-
Jean Chalard authored
Change-Id: I852787986c79502a4de7effe9c8281a4cf2d519d
-
Jean Chalard authored
It's useless to do this for all suggestions including those that will be ousted from the list. Change-Id: I7bd63d783e21984a269e4b1ae17e9b9d8c0859e3
-