Change-Id: I6009b3c1950ba32b7f1e205a3db2307fe0cd688e

Change-Id: Ia0f0e38086b0be70cf2d04fc6fae48358f16e74f

Bug: 7149248
Change-Id: Icba2db73508b89a85828ae9e196ab618e5e6c280

Bug: 7134017
Change-Id: I75cf474dedafda3e1683dd8f7740c13aafdcf5ab

Change-Id: I6b4de9187e122298e5e9cd8ddc9070d062df6a89

Bug: 6950087
Change-Id: I9f2271780600572c9befa96c7ad98494c554dd2b

Bug: 6950087
Change-Id: Ifab9d6d075af398c6468d081216488712f8a53fb

The functionality now lives in the binary dictionary.

This finalizes work on
Bug: 6906525

Change-Id: Id106d871e8afdf9afa886d2a30bea87ff89f2d24

...which becomes useless. It will be entirely removed in an
upcoming change.

Change-Id: I2f1d27f1eceda79454b01f21e057b98f2953131a

Change-Id: I39d9bf1a7c272eb16d6ed4698f52457579b40f10

...not only the WhitelistDictionary.

Bug: 6906525
Change-Id: I7f181eb6936ec17bbccdc4e736fd09292af24e9c

It's useless to do the whitelist lookup twice. Also, putting
this test out of this method will allow whitelist entries to
come from other sources.

Bug: 6906525
Change-Id: I4afe678cae6556d16642d155ce770fbf4e61ad49

Change-Id: I4c01f172ddb2ca60fa6e604384610c90b76e5457

Bug: 6667462
Change-Id: I796655f57c71c9f50ae6e38dd08b71df3998dbcf

Bug: 6860204
Change-Id: I1e4c03c99415cd9bdea5a8556ff4093c33f0f508

Change-Id: Iee6ae48bb6309c2867b5d2e344fe7d86dfabd654

Change-Id: I6f8bb05a23edb40a079da60b7136170ec9043282

Change-Id: I97cf92a7b0dabc251dd241b24978ea00d1e5f047

This improves locality, it's better for readability/performance

Change-Id: Ibb1efaf86e362dd2c9398722d0da2144df96b333

Change-Id: I7e24e0aeae7c004cae310ae9f46cf90dac2d4d14

If not composing a word, then consideredWord is always the empty
string.
Hence, it's never whitelisted, but it's also always "NotAWord",
so isWhitelistedOrNotAWord returns always true, so
allowsToBeAutoCorrected is always true. Which means that
isPrediction implies allowsToBeAutoCorrected == true.
Thus, !isPrediction && !allowsToBeAutoCorrected is strictly
equivalent to !allowsToBeAutocorrected.

Change-Id: I4ad7a7c3447851c539646d97cf55ff065e6ee115

If we are not composing a word, that isFirstCharCapitalized
and isAllUpperCase are guaranteed to return false.

Change-Id: Ic4a0be9574acf4653c729a9594f963f5bcf0c757

Change-Id: I7c76613df8f148feb02765f187db3ca6dc577977

The fact that prediction does not accept a null argument is an
implementation detail, it should not be visible to Java code.

Change-Id: I3a156b323b6db9353de898d33f3f7c81751cecb1

Change-Id: I4da3c976838e8eb56c9ec80aafaaf54d759b7981

Change-Id: I1d1758048649ef337875a5141d825569af7ad38c

Change-Id: I5d79021e69cc738e3013e31764ab0a59e15decdf

Use the word the same way for suggestion and prediction. It makes
little logical sense that the trailing single quotes be removed
for suggestion lookup but not for prediction lookup.

Change-Id: I0de4b5f7c5b4c1b4ba1817ff9653d7c03967146d

Avoid special casing the whitelist dictionary by having it implement
the interface it pretends it implements

Change-Id: I8b873cb0f3fe13cefd32c8cb756a25c8ae16a2b4

The user history dictionary should be the one knowing it does not suggest words
beyond 2 characters, not Suggest.

Change-Id: Ie85ec6116eb495e0c7f51108e4620c5ae536f4bf

Bug: 6788235
Change-Id: I5a4212872e0fd3f9e80168fd3abd5c2b3bc4110f

...if there aren't any for the exact case version.

Bug: 6752830
Change-Id: I2737148b01ba04a64febe009ceb2ef53c265d224

It's simpler to check the safety net directly inside the
function that checks for auto-correction threshold.

This introduces one very slight change in behavior. The value
checked by the safety net is not any more the "typed word" but the
"considered word", the difference being any possibly appended
single quotes.
E.g. the user types "this'''" : the typed word is "this'''" but
the considered word is "this".
This change in behavior can be considered a bugfix.

Change-Id: Ia7ab4bc933183dfbd41bb00328e4c0b5ab76bc63

Change-Id: Iec791d061f237f60992dd6048c4a37b46f4cb9aa

Change-Id: Ib0b6f36999518096819ada2f19365767cb5f9931

If allowsAutoCorrected is false, there is no point in making
hasAutoCorrection true, since in the only place where we use
it again, it's &&'ed with allowsAutoCorrected !

Well that was extremely obscure, good thing refactoring allowed
to realize this was useless >.>

Change-Id: I34936d445f1ced17c7bd04a9524bf608f9e8b9c8

The test against hasMainDictionary is a test to know if we should
auto-correct or not. Its result should be recorded in
hasAutoCorrection, not in allowsToBeAutoCorrected.

Actually, this value being inserted in allowsToBeAutoCorrected was
causing a bug that nobody noticed: when typing in a language with
no dictionary, the word in the middle of the suggestion strip would
always be bold, as if it was going to auto-correct to itself !
This change fixes this bug.

Change-Id: Ia1f08efd7089b9c5cbede910c5b0951d83e698d2

Change-Id: I3c45b5a6571f986acc7adb3a8fe17b210303f7ea

Change-Id: I2b2ab99e801fa8b4b30eab16a8aefb8cfe104ba9

Change-Id: I4833ca7e057b8c1f1f22390673cbca0d2433b1bd