- Jan 23, 2014
-
-
Jean Chalard authored
This constant is better located in SuggestedWords. Or it could be in Constants, that would be fine too. Bug: 8636060 Change-Id: I3e721bb1e2559f028dce8929eceadfe0478c5924
-
Jean Chalard authored
Bug: 8636060 Change-Id: Iec56bce362ebfc52fedab02b127978abb4f3c7f9
-
Jean Chalard authored
Bug: 8636060 Change-Id: I624a45500603dfad355ee3b8b794b2d895219c0b
-
Jean Chalard authored
Bug: 8636060 Change-Id: I242b7c264abf380bcd6b6b3c848238921f988e54
-
Jean Chalard authored
This is necessary for tests Bug: 8636060 Change-Id: I50ea401a22e4df72333eda61ca39aa180966ee4b
-
Jean Chalard authored
Bug: 8636060 Change-Id: Ib13a54854e30afb79217a0a1f2aeca50a95ba155
-
Jean Chalard authored
Bug: 8636060 Change-Id: I3b144993e2bcd552f9b292b8f057c9db4216125c
-
- Jan 22, 2014
-
-
Jean Chalard authored
This works because getKey{X,Y} is a no-op on Constants.NOT_A_COORDINATE. Bug: 8636060 Change-Id: I2f7dd96b6011f094110f7978f8ff24ef2a6e2585
-
Jean Chalard authored
Bug: 8636060 Change-Id: Ic051e5d5514d270101b0571a2d30e2caa8f85bc1
-
Jean Chalard authored
This also fixes the coordinates passed to logOnDelete and log onSeparator. Bug: 8636060 Change-Id: I4703d61ad7de76b501adca18df3a69e06450c9a1
-
Jean Chalard authored
This is fine because getKey{X,Y} is idempotent for any non-keyboard coordinate value. However this makes a net change : the x,y values passed to LatinImeLoggerUtils.onNonSeparator are now different. The point is however that they used to be wrong. The logged values used not to account for the keyboard padding that is present on tablets, and in the simulating tools we don't know about that padding so we couldn't use the coordinates. The catch here is that other calls like LoggerUtils.onSeparator should follow suit, but this is too big a change to do it at once. Follow-up changes will fix them too. Bug: 8636060 Change-Id: If4b3d3cb1ed4b44c35f23e66aba3b5797236bba7
-
- Jan 20, 2014
-
-
Tadashi G. Takaoka authored
Change-Id: I4103541d99fe59bfcf12379a1298a0a690497846
-
Tadashi G. Takaoka authored
Change-Id: I78d488ad84a11af809ee1f8d3d2fa01a89fbfa28
-
Tadashi G. Takaoka authored
Change-Id: Ic7d2cbb2c1b2deaa4e735484bdc7413c0b3b1939
-
- Jan 19, 2014
-
-
Keisuke Kuroyanagi authored
Change-Id: I2d2d226e21a46239077394ab09db88a4bd563460
-
- Jan 17, 2014
-
-
Keisuke Kuroyanagi authored
Bug: 12515251 Change-Id: I0b332e03b9102957bffaea56d4de17b9ee3cef23
-
Tadashi G. Takaoka authored
Change-Id: I866488a47ca04ca587e805663dfd597bb7b1ebce
-
- Jan 16, 2014
-
-
Jean Chalard authored
Bug: 8636060 Change-Id: Id87b0ac4a99ec6a26db6e250d6cd22defc02a23d
-
Jean Chalard authored
Yay Bug: 8636060 Change-Id: Iad9c3804504635094e861999198f4baf70e61955
-
Jean Chalard authored
Um... this is not async ? Remove that from the name Bug: 8636060 Change-Id: Ida5f9bd6929eae75103eb2e3fb866ed7468af806
-
Jean Chalard authored
No need to test multiple times for this. Let's just never do useless stuff, and only test for that once. Bug: 8636060 Change-Id: I50a9e4da769fbec44fbb12eedfed03aad924cc2c
-
Jean Chalard authored
Bug: 9663105 Change-Id: Ib68ee4edb135e96dfca229c1ccce308e7e638bdd
-
Keisuke Kuroyanagi authored
Change-Id: I512c41e12d8d31f03b5df6ad03bf7711611c80f5
-
- Jan 15, 2014
-
-
Keisuke Kuroyanagi authored
Bug: 12443085 Change-Id: I41a5cf6c895cb59e54af98b40efded36afcd3247
-
Jean Chalard authored
Bug: 12297051 Change-Id: Iffa1c98b8fe2b816c3ac6bc171037288107f637d
-
Tadashi G. Takaoka authored
Change-Id: Ia2d566f162f746c6b2b2b874f7278d86abd9e839
-
Tadashi G. Takaoka authored
This change must be checked in together with I9ecfd1adc1. Change-Id: I26f8c17d6347b75dba6abb3d73239f4052327dae
-
Tadashi G. Takaoka authored
This change must be checked in together with Id9382498a8. Change-Id: I804d78969bccf8bdc224477bd64c8ac12c1ab0d6
-
Tadashi G. Takaoka authored
Change-Id: I142651d1f268456a5901da524cbe55d315f76d28
-
Tadashi G. Takaoka authored
This change must be checked in together with Ic82d951237. Change-Id: I2ab451330f85a0147563b805682f26edecb71a29
-
Keisuke Kuroyanagi authored
Change-Id: I8df0f9a0398b29f679844f256ad84f09ebcea8ee
-
- Jan 14, 2014
-
-
Tadashi G. Takaoka authored
Bug: 12179576 Change-Id: I93037ee2aa7c0432400fe2f93fb60d2e60f70f5f
-
- Jan 10, 2014
-
-
Keisuke Kuroyanagi authored
Change-Id: I57792b7417b5f1acbb99e6ea60250eb44b193785
-
Jean Chalard authored
Change-Id: I0b3a6cdf49038c32194413c21da824784a53f581
-
Keisuke Kuroyanagi authored
Bug: 12479792 Change-Id: I62fd75d4bebd28afebd9631e865f5d59385511e7
-
Jean Chalard authored
For edit tasks, the estimate is actually the right thing to use. This is really dangerous, but it will get rid of pretty much all race conditions. Change-Id: I2d5ca3ce45e32f1bd9c8b778421fd54b9c1f6f63
-
Keisuke Kuroyanagi authored
Bug: 12216453 Change-Id: Ie59dd19c044e9b1eb9b8bd805366200737ea506a
-
Jean Chalard authored
This just mirrors what InputLogic#tryFixLyingCursorPosition is doing. That method will go away in the next change. Change-Id: Ifa2827dbc1f1d20e2c642d6f2d23514a01ed9203
-
Jean Chalard authored
This test was intended only for cases without a selection, and as a safety net for cases where the app would pretend the cursor is at N but we can get P chars from the editor where P > N. When there is a selection, this is wrong. In the practice it works because these values are not used in this case, but it's still wrong. The case where P > N is arguable, but actually I see little reason to trust the getTextBeforeCursor() method more than the onUpdate selection method. Plus in the practice, I don't think we are aware of any app with this bug, and it's probably not a great idea to be too robust about this as it may encourage wrong values sent to onUpdateSelection. Change-Id: I42f2065d7aee668074e6b8e40b259da7e88e16e1
-
Jean Chalard authored
Bug: 12397228 Change-Id: I7632931f0685fc8f0558946be66025b2bb2b5a3d
-