Skip to content
Snippets Groups Projects
  1. May 08, 2013
    • Jean Chalard's avatar
      Optimizations and safeguards. · 9f9cc032
      Jean Chalard authored
      - Don't call finishComposingText when useless.
      - Add safeguards against calling setComposingRegion when the
        data returned by the editor is inconsistent.
      - Cancel pending recorrection messages when new messages arrive.
      
      Bug: 8842941
      Bug: 8845001
      Change-Id: I939701033cf5c2bbd85871ecf83e329021ddeb91
      9f9cc032
  2. Apr 16, 2013
    • Jean Chalard's avatar
      Don't insert automatic spaces when text looks like a URL · 73ec85b8
      Jean Chalard authored
      This is about as ad-hoc as it gets, but then again, what we want
      is probably as ad-hoc as it gets.
      All URL boxes I know of double as search bars, and not adding
      automatic spaces there sucks (e.g. in Chrome URL bar).
      And in other boxes actually you don't want to add a space if
      it looks like a URL. QSB isn't even a search box, and it behaves
      like this.
      
      So I think this is actually the right answer to the problem.
      
      Bug: 7062925
      Change-Id: Ib09472b34644fd5bf2dc84bb97cedeeba28bcd02
      73ec85b8
  3. Apr 15, 2013
    • Jean Chalard's avatar
      Have Latin IME re-capitalize a selected string · 2995abe7
      Jean Chalard authored
      Upon pressing Shift, if there is currently a selected string, have
      Latin IME change its capitalization.
      This does not yet have the keyboard mode follow the mode - the change
      is complicated enough as is.
      
      Bug: 7657025
      Change-Id: I54fe8485f44e04efd72c71ac9feee5ce21ba06f2
      2995abe7
  4. Apr 12, 2013
    • Jean Chalard's avatar
      Fix a bug with bad application completions · 02ce3dc2
      Jean Chalard authored
      Bug: 8561056
      Change-Id: I91fb0ac76dabfc841bafc0e2c0ea9f63e6f604f9
      02ce3dc2
    • Jean Chalard's avatar
      Restart suggestions when the cursor moves. · 6a114fa7
      Jean Chalard authored
      This uses the old suggestions. It does not try to recompute
      new suggestions if there are no old suggestions yet: this is
      coming in a later change.
      If there are no suggestions, this shows the word itself
      as a suggestion.
      
      Bug: 8084810
      Change-Id: I4c2e25df0ff3673be1825f57a0c19a9d23d47a48
      6a114fa7
  5. Mar 29, 2013
    • Jean Chalard's avatar
      Fix an NPE · 740da0d8
      Jean Chalard authored
      Also remove an unused method and make 2 private variables
      final.
      
      Bug: 8461093
      Change-Id: I676d93fda28e82eb5a6978f2e7ad5a0add2cbecf
      740da0d8
  6. Mar 18, 2013
  7. Feb 12, 2013
  8. Jan 21, 2013
  9. Jan 17, 2013
  10. Jan 10, 2013
  11. Jan 08, 2013
  12. Jan 07, 2013
    • Ken Wakasa's avatar
      Small code cleanups · b6ca3544
      Ken Wakasa authored
      Multi-project commit with I249d5fbe
      
      Change-Id: Ia28c4e970992aa1299a30e604eaa5d096655c3a5
      b6ca3544
  13. Dec 27, 2012
    • Jean Chalard's avatar
      Rename some confusing variables · 0abc4821
      Jean Chalard authored
      Change-Id: Ib0de800599ae7f12c86270a627616d5b52366414
      0abc4821
    • Jean Chalard's avatar
      Fix an old bug in getting a word from the connected view. · 5bde3a61
      Jean Chalard authored
      In this test, it's impossible that start < 0 so the test is useless.
      I'm not sure what the cursor test was for, but it's very old code, and
      it seems the assumption was either misled or doesn't hold any more:
      testing for the absolute cursor position against the length of the
      word against the cursor makes no sense.
      
      The net result of this was that when the cursor index got large
      enough, resuming suggestion would not work any more.
      
      Bug: 7586467
      Change-Id: I3462082374fe9579bec7698f4d424de6ff5f2ded
      5bde3a61
  14. Dec 23, 2012
  15. Dec 17, 2012
  16. Dec 14, 2012
    • Jean Chalard's avatar
      Use the amended user dictionary word for insertion · 18d688c9
      Jean Chalard authored
      When the user edits a word before adding it to the user
      dictionary, the keyboard should replace whatever was
      committed before with the amended version.
      
      Bug: 7725834
      Change-Id: I1a417be6c5a86d6a96bc2c76aca314ad8f1202a9
      18d688c9
  17. Dec 06, 2012
  18. Nov 14, 2012
    • Jean Chalard's avatar
      Fix a bug with some text fields · 00c0010c
      Jean Chalard authored
      Not sure when this happens exactly, but it is possible that
      InputConnection#getTextBeforeCursor returns null. This
      happens for example upon rotating the screen with the
      composing field empty in Gmail.
      In this case, StringBuilder#append will convert the null
      pointer into the string "null", which is sure better than a
      crash, but can have a number of bad side-effects, like
      auto-caps not working.
      
      Bug: 7533034
      Change-Id: Ia1cfab432c13a12ff1c2f013c59bac05a587f553
      00c0010c
  19. Nov 06, 2012
  20. Oct 29, 2012
  21. Oct 22, 2012
  22. Oct 17, 2012
  23. Oct 01, 2012
  24. Sep 27, 2012
  25. Sep 18, 2012
  26. Sep 14, 2012
  27. Sep 13, 2012
    • Jean Chalard's avatar
      Simplify a call, and add comments (A2) · 3d54e1c1
      Jean Chalard authored
      Since the function has to be modified heavily but does a lot
      of non-trivial work, add a wealth of comments explaining what
      it does and why so as to facilitate understanding the changes
      to come.
      
      Bug: 4967874
      Change-Id: I6c21aea15f161d807035f279dfb7d1b98b3e9144
      3d54e1c1
    • Jean Chalard's avatar
      Import TextUtils.getCapsMode to fix it internally (A1) · 9d1c73ff
      Jean Chalard authored
      This should have on effect at all on behavior,
      except an increase in performance.
      
      Bug: 4967874
      Bug: 6950087
      Change-Id: Ie2b51efefe84ca767f5dc8e3b80bfef7e1faab3d
      9d1c73ff
    • Jean Chalard's avatar
      Make onUpdateSelection much more resilient to race conditions. · 5ed88457
      Jean Chalard authored
      This is pretty much as strong as it gets. It should be
      impossible to get false positives and nearly impossible to
      get true negatives with this new code.
      
      Bug: 6981089
      Change-Id: Ia32ab62f89c5943f0be169b979abab652e67bf5b
      5ed88457
  28. Sep 12, 2012
  29. Aug 22, 2012
    • Kurt Partridge's avatar
      ResearchLogger log RichInputConnection · 94e7f4be
      Kurt Partridge authored
      Move many ResearchLogger data collection points to RichInputConnection.
      By collecting data here, developers do not have to remember to keep the
      ResearchLog consistent with calls to the RichInputConnection.
      
      In addition, some unnecessary log points were removed, and the ResearchLogger
      is now independent of LatinImeLogger.
      
      multi-project change with I05496cfd762e9a41c42c50099143f1efc0a3d8a2
      
      Bug: 6188932
      Change-Id: I424abb2e437901262a9620255493916b7c3ff74b
      94e7f4be
    • Kurt Partridge's avatar
      Revert "ResearchLogger log RichInputConnection" · 97d3dd58
      Kurt Partridge authored
      This reverts commit d0c41e0c
      
      Change-Id: I5fd8a67a9fdadb7e6532cafecd00c8f33a00ec72
      97d3dd58
  30. Aug 21, 2012
    • Kurt Partridge's avatar
      ResearchLogger log RichInputConnection · d0c41e0c
      Kurt Partridge authored
      Move many ResearchLogger data collection points to RichInputConnection.
      By collecting data here, developers do not have to remember to keep the
      ResearchLog consistent with calls to the RichInputConnection.
      
      In addition, some unnecessary log points were removed, and the ResearchLogger
      is now independent of LatinImeLogger.
      
      multi-project change with Ifbabefc008d32d99f89e8289e504188e7232ebd4
      
      Bug: 6188932
      Change-Id: I4a42d963ba952e703d425acd3a9871d5fca1f03a
      d0c41e0c
    • Ken Wakasa's avatar
      Make master LatinIME identical to JB MR1 LatinIME as of now. · b2b54583
      Ken Wakasa authored
      Change-Id: Id79c70310dd774dd5e7ccda6d4b8c36b88c67744
      b2b54583
  31. Aug 20, 2012
  32. Aug 18, 2012
    • Kurt Partridge's avatar
      ResearchLogger log RichInputConnection · 1964ffb3
      Kurt Partridge authored
      Move many ResearchLogger data collection points to RichInputConnection.
      By collecting data here, developers do not have to remember to keep the
      ResearchLog consistent with calls to the RichInputConnection.
      
      In addition, some unnecessary log points were removed, and the ResearchLogger
      is now independent of LatinImeLogger.
      
      multi-project change with Ib71f841044ec1072610ab5638a5edfce29b7c05b
      
      DO NOT MERGE
      
      Bug: 6188932
      Change-Id: I9ec7500a5b18bfe1a5a5bb1e5bf21c43351fc59e
      1964ffb3
Loading