Skip to content
Snippets Groups Projects
  1. May 28, 2013
  2. May 24, 2013
  3. May 23, 2013
  4. May 22, 2013
  5. May 21, 2013
  6. May 20, 2013
  7. May 17, 2013
    • Kurt Partridge's avatar
      Fix punctuation logging · 500dea6a
      Kurt Partridge authored
      Punctuation is currently put into the same LogUnit as the
      following word.  This is counter-intuitive and makes
      post-processing more complicated.
      
      This change causes punctuation to be put into its own
      LogUnit.
      
      A tricky case is the phantom space.  A phantom space is
      inserted right before other text, whose MotionEvents have
      already been collected and inserted into mCurrentLogBuffer.
      Phantom spaces are handled by creating their own LogUnit and
      inserting it into the LogBuffer right before
      mCurrentLogBuffer is shifted in.
      
      Change-Id: I102d7cd93982ad37ba0abb6c1ac0f66b85b5f95d
      500dea6a
  8. May 15, 2013
  9. May 14, 2013
    • Kurt Partridge's avatar
      Remove unnecessary commit/uncommit · 993acbaa
      Kurt Partridge authored
      When the user reverts a commit, this causes the committed
      word to be changed. The user usually then goes back to edit
      that word.  Going back to edit causes an uncommit, so that
      the editing actions are added onto the LogUnit containing
      the operations used to construct the word.
      
      But currently, reverting also involves its own
      commit/uncommit pair, with the caller performing the
      uncommit, and the commit happening inside the revert
      command.  This may have been necessary in the past, when
      revert was called in different situations, but is
      unnecessary now.  Furthermore, the guarding conditions are
      currently such that the uncommit doesn't always undo the
      effects of the commit, corrupting the log output.
      
      Change-Id: I74af41f4f1db2fcabfa496dcc4a2d7bd0af19b3a
      993acbaa
    • Kurt Partridge's avatar
      Add claifying comment · 3e8df13c
      Kurt Partridge authored
      This is a follow-up to I7c01c3dd3ac33d7e96c00836256bae9c14b124ed
      
      Change-Id: I9e3f8968c4bbf9525d5dfe101f71373c42f88361
      3e8df13c
    • Tadashi G. Takaoka's avatar
      Revise welcome screen video and still image · 7348d9fb
      Tadashi G. Takaoka authored
      Bug: 8159728
      Change-Id: Ief8d7197879d24ccef529e975c23d6f11c7aa458
      7348d9fb
    • Ken Wakasa's avatar
      Revert "Fix isSuggestionsStripVisible when keyboard hidden" · 3efa36f6
      Ken Wakasa authored
      This reverts commit cb0d1c4c
      
      Change-Id: Ie2c8e01c25bd051b6157e8f32ab84392a0c7252a
      bug: 8954116
      3efa36f6
    • Tadashi G. Takaoka's avatar
      Back to previous keyboard layout by canceling sliding input · 41016aca
      Tadashi G. Takaoka authored
      Bug: 8915171
      Change-Id: Iabdeb7920f67f89246087c3ee06240406ecfbc3d
      41016aca
    • Tadashi G. Takaoka's avatar
      Fix PointerTrackerQueue.releaseAllPointerOlderThan · 979fb741
      Tadashi G. Takaoka authored
      Change-Id: If353869720895ee5355079c15c724132762dd70c
      979fb741
    • Jean Chalard's avatar
      Fix isSuggestionsStripVisible when keyboard hidden · cb0d1c4c
      Jean Chalard authored
      When the keyboard is hidden, the suggestion strip is
      never visible.
      
      Bug: 8954116
      Change-Id: I9f242d07b49ad60b625a22429bb013251e814905
      cb0d1c4c
    • Kurt Partridge's avatar
      Remove FeedbackLog instance variables. · 6fefc142
      Kurt Partridge authored
      For a while, the ResearchLogger supported comprehensive recording of the
      last few words in case the user wished to upload this data to give
      developers feedback.  However, this mechanism was not implemented well
      (keeping a separate copy of the data), did not make the collected data
      clear to the user, and was not working properly in the latest build (NPEs).
      The mechanism in fact was deprecated in favor of the "userRecording"
      mechanism in which the user explicitly turned on comprehensive recording,
      demonstrated the issue they were experiencing, and then turned it off.
      
      This change removes the vestiges of the FeedbackLogging mechanism.
      A feedback log is still used to hold the user's message, but it is created
      in a local variable as-needed, and not persisted in ResearchLogger.
      
      Change-Id: I6a09d0ed36e1eddb6e57895e7428d22107f75f49
      6fefc142
    • Kurt Partridge's avatar
      Rename a var to match semantics · b5c39f45
      Kurt Partridge authored
      The IS_INHIBITING_AUTO_UPLOAD flag is tested in isPossibleToUpload, so it inhibits all uploads, not
      just automatic ones.  Renaming to IS_INHIBITING_UPLOAD.
      
      Change-Id: Iceed79260d4b062147f40c09f0c5bb06b2519b1b
      b5c39f45
  10. May 13, 2013
Loading