Skip to content
Snippets Groups Projects
Select Git revision
20 results
Search by author
  • Any Author
0 authors
  1. Jan 12, 2022
    • Ming-Shin Lu's avatar
      Using IME context to inflate layout from S_V2 · 6c752d8e
      Ming-Shin Lu authored 
      With CL[1],[2] to migrate InputMethodService as the subclass of the new
introduced class WindowProviderService in S_V2, IME context resources
can be managed by associating the window container of IME window when
its display/window configuration changed.

So we can get rid of createDisplayContext logic from S_V2 with gated
by SDK version and refining the method of get IME context with
documentation to make it clear.

[1]: Ie565e30ed5dd3f2cfe27355a6dded76dc3adc14b
[2]: I64a1614f32d097785915f6105b1813a929e0fe32

Bug: 213118079
Bug: 133825283
Test: manual with below steps
 1) adb install -r EditTextVariations.apk
 2) tapas LatinIME
 3) make
 4) adb install -r out/target/product/generic/system/app/LatinIME/\
        LatinIME.apk
 5) adb shell ime enable com.android.inputmethod.latin/.LatinIME
 6) adb shell ime set com.android.inputmethod.latin/.LatinIME
 5) Enable screen auto-rotation
 7) Launch EditTextVariations from launcher's shortcut
 8) Tap the first EditText field to show IME
 9) Rotate the device to the landscape mode
 10) Expect the IME should not be shrunk

Change-Id: If2cc1c5bdb257a9c0af653fa7157cf781a90bf1d
      6c752d8e
  3. Jun 18, 2021
    • Ming-Shin Lu's avatar
      Fix Keyboard Theme update when device orientation changed am: 6ae09365 · 7f3bcefd
      Ming-Shin Lu authored 
      Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/inputmethods/LatinIME/+/15021672

Change-Id: I33a6fa7093b4633fc5bbd535b2c3d9d287022bc8
      7f3bcefd
    • Ming-Shin Lu's avatar
      Fix Keyboard Theme update when device orientation changed · 6ae09365
      Ming-Shin Lu authored 
      As CL[1] introduces diplayContext to address
IME service context's Resources / DisplayMetrics update when
switching IME window to another display after onConfigurationChange.

In LatinIME#onInitializeInterface, we only update keyboard theme context
and displayContent when the displayId is changed, but overlooked even
the displayId is the same, the display context's resource configuration
might changed like the device orientation changd.

It leads getDefaultKeyboardHeight will get wrong config_max_keyboard_height
fraction value when rotating to landcape because the context resources
didn't get updated.

Add a check to update keyboard theme context when the current display
configuation is changed accordingly.

[1]: I0ed6a079af1ed90c75fee1d36d5ce3ef3c41f8ed

Fix: 186507147
Test: manual as issue steps
    1) Turn on auto-rotate
    2) Open Settings
    3) Rotating the device to landscape mode
    4) Tap “Search settings", verify if the soft-keyboard shown and the
       size is expected.
Change-Id: I288a31baf04fa2e63d6b4a14ad81b401cb36ece5
Merged-In: I288a31baf04fa2e63d6b4a14ad81b401cb36ece5
      6ae09365
  5. Jun 17, 2021
  7. Jun 15, 2021
    • Yohei Yukawa's avatar
      Bump targetSdkVersion to "30" · 07ce283a
      Yohei Yukawa authored 
      With this CL, versionCode, targetSdkVersion and minSdkVersion will be
bumped/set as follows:

       versionCode: 28 -> 30
  targetSdkVersion: 28 -> 30
     minSdkVersion: 21

As far as we know, there should be no user-visible behavior change on
supported OS versions.

Fix: 189558760
Test: manually verified that LatinIME still is functional
Change-Id: I3a7deb452960b370f5290f3d1bac9c79fe935303
Merged-In: I4bf7588c62fb77bf78d4afcb665e9bfbbef53966
(cherry picked from commit 360052f3)
      07ce283a
  9. Apr 15, 2021
  11. Apr 13, 2021
    • Pedro Loureiro's avatar
      Add lint baseline to address NewApi errors · 57d4aef2
      Pedro Loureiro authored 
      We are enabling a new lint check where the min sdk != compile sdk.
It has produced a lot of errors and adding the baseline file(s)
allows us to continue work without introducing more problems.

Bug: 150847901

Test: m lint-check
Change-Id: Ic37bd8c531af7e68c939ce9c05614c37e6699b03
Merged-In: Ic37bd8c531af7e68c939ce9c05614c37e6699b03
      57d4aef2
  13. Apr 12, 2021
    • Pedro Loureiro's avatar
      Add lint baseline to address NewApi errors · b47de75a
      Pedro Loureiro authored 
      We are enabling a new lint check where the min sdk != compile sdk.
It has produced a lot of errors and adding the baseline file(s)
allows us to continue work without introducing more problems.

Bug: 150847901

Test: m lint-check
Change-Id: Ic37bd8c531af7e68c939ce9c05614c37e6699b03
      b47de75a
  15. Feb 21, 2021
  17. Feb 20, 2021
  19. Feb 19, 2021
  21. Feb 17, 2021
  23. Feb 16, 2021
  25. Nov 23, 2020
  27. Oct 09, 2020
  29. Sep 11, 2020