Skip to content
Snippets Groups Projects
  1. Jul 06, 2023
  2. Oct 17, 2022
    • Cole Faust's avatar
      Fix errorprone warnings that should be errors · 91cb9a6a
      Cole Faust authored
      This commit is part of a large scale change to fix errorprone
      errors that have been downgraded to warnings in the android
      source tree, so that they can be promoted to errors again.
      The full list of changes include the following, but not all
      will be present in any one individual commit:
      
      BadAnnotationImplementation
      BadShiftAmount
      BanJNDI
      BoxedPrimitiveEquality
      ComparableType
      ComplexBooleanConstant
      CollectionToArraySafeParameter
      ConditionalExpressionNumericPromotion
      DangerousLiteralNull
      DoubleBraceInitialization
      DurationFrom
      DurationTemporalUnit
      EmptyTopLevelDeclaration
      EqualsNull
      EqualsReference
      FormatString
      FromTemporalAccessor
      GetClassOnAnnotation
      GetClassOnClass
      HashtableContains
      IdentityBinaryExpression
      IdentityHashMapBoxing
      InstantTemporalUnit
      InvalidTimeZoneID
      InvalidZoneId
      IsInstanceIncompatibleType
      JUnitParameterMethodNotFound
      LockOnBoxedPrimitive
      MathRoundIntLong
      MislabeledAndroidString
      MisusedDayOfYear
      MissingSuperCall
      MisusedWeekYear
      ModifyingCollectionWithItself
      NoCanIgnoreReturnValueOnClasses
      NonRuntimeAnnotation
      NullableOnContainingClass
      NullTernary
      OverridesJavaxInjectableMethod
      ParcelableCreator
      PeriodFrom
      PreconditionsInvalidPlaceholder
      ProtoBuilderReturnValueIgnored
      ProtoFieldNullComparison
      RandomModInteger
      RectIntersectReturnValueIgnored
      ReturnValueIgnored
      SelfAssignment
      SelfComparison
      SelfEquals
      SizeGreaterThanOrEqualsZero
      StringBuilderInitWithChar
      TreeToString
      TryFailThrowable
      UnnecessaryCheckNotNull
      UnusedCollectionModifiedInPlace
      XorPower
      
      See https://errorprone.info/bugpatterns for more
      information on the checks.
      
      Bug: 253827323
      Test: m RUN_ERROR_PRONE=true javac-check
      Change-Id: I454a105ae82484a2d19aff1808e8d9dd55ba64f4
      91cb9a6a
  3. Feb 17, 2021
    • Bob Badour's avatar
      [LSC] Add LOCAL_LICENSE_KINDS to packages/inputmethods/LatinIME · f3d9532a
      Bob Badour authored
      Added SPDX-license-identifier-Apache-2.0 to:
        Android.bp
        common/Android.bp
        java/Android.bp
        native/dicttoolkit/Android.bp
        native/jni/Android.bp
        tests/Android.bp
        tools/EditTextVariations/Android.bp
        tools/dicttool/Android.bp
        tools/make-keyboard-text/Android.bp
      
      Bug: 68860345
      Bug: 151177513
      Bug: 151953481
      
      Test: m all
      
      Exempt-From-Owner-Approval: janitorial work
      Change-Id: I440008bffac5c97a2497970af377a9d03262b6d8
      f3d9532a
  4. Jul 31, 2020
  5. Nov 01, 2018
    • Dan Willemsen's avatar
      Convert to Android.bp · a23407bf
      Dan Willemsen authored
      See build/soong/README.md for more information.
      
      Test: cd packages/inputmethods/LatinIME; mma
      Change-Id: Ib8867d3b74f09fc1d9f95adc9a49a81ac0f7f054
      Merged-In: Ib8867d3b74f09fc1d9f95adc9a49a81ac0f7f054
      a23407bf
    • Dan Willemsen's avatar
      Convert to Android.bp · 22ebec6e
      Dan Willemsen authored
      See build/soong/README.md for more information.
      
      Test: cd packages/inputmethods/LatinIME; mma
      Change-Id: Ib8867d3b74f09fc1d9f95adc9a49a81ac0f7f054
      22ebec6e
  6. Oct 29, 2018
    • Tadashi G. Takaoka's avatar
      Fix dicttool build · 6a1b3735
      Tadashi G. Takaoka authored
      This CL partially reverts
        - Id88b02b74bdfe4ca05b08181ceb6b34d5652fc0c
        - I05c7d8429e8d9a26139456763c77997340fea8c2
      And followup (remove shortcut support)
        - I73b7dc008a5acaf75a31a36a2d332b5afabd82d0
      
      Bug: 28255684
      Test: make -j10 dicttool_aosp
      Change-Id: I2e01ed86b9517a1141aee35ea6d8ef39258981d1
      6a1b3735
  7. Jul 26, 2017
    • Dan Willemsen's avatar
      Clean up Makefiles, remove HOST_JDK_IS_64BIT_VERSION · 6e29475b
      Dan Willemsen authored
      This builds on Darwin fine, so remove the non-standard darwin checks.
      
      Remove HOST_JDK_IS_64BIT_VERSION, it's always true now, and this is the
      only user.
      
      Test: mmm packages/inputmethods/LatinIME/tools/dicttool:liblatinime-aosp-dicttool-host
      Change-Id: I750c6baa29cf1d27a885ff064f0daf9d986db0b9
      6e29475b
  8. Nov 30, 2016
    • Paul Duffin's avatar
      Use junit-host instead of junit · 982f0fa2
      Paul Duffin authored
      Use framework/junit-host.jar instead of framework/junit.jar
      
      Ran the script before and after making the change and it failed
      in the same way with a build error but it was not due to a
      problem with JUnit.
      
      Bug: 30188076
      Test: make checkbuild and ran the test-dicttool.sh script
      Change-Id: I4cdd518f38184ff3ade5a06d968d6902770ece6b
      982f0fa2
  9. Oct 07, 2016
  10. Nov 28, 2014
  11. Nov 12, 2014
  12. Nov 08, 2014
  13. Nov 07, 2014
  14. Nov 06, 2014
    • Jean Chalard's avatar
      Fix the build : move offdevice tests in an off device file · e1652d75
      Jean Chalard authored
      Also fix a failing test
      
      Change-Id: I280aa6b5836c7332da08a88f1258546edeb25a37
      e1652d75
    • Jean Chalard's avatar
      Remove dicttool dependency to NativeSuggestOptions · 03eb9de9
      Jean Chalard authored
      Bug: 18108776
      Change-Id: I0f57594617f8d5080aea9002b2356d18bfe97043
      03eb9de9
    • Jean Chalard's avatar
      Add a header command to dicttool. · 5b33d197
      Jean Chalard authored
      This will allow to greatly improve the performance of the
      metadata-generating files, as they won't have to wait for
      the info command to read the entire dictionary when the
      header is all we need.
      
      Also add tests, and while we're at it, use the seed as
      intended to enable reproducible tests.
      
      Change-Id: I0ba79ef62f0292b23e63aed57ff565bb102281a2
      5b33d197
    • Jean Chalard's avatar
      Add a *FAST* dictionary header reader. · f6b0e32d
      Jean Chalard authored
      It's still unused as of this change but the next change will use it
      
      As a reference point, generating the metadata for Bayo takes
      3'02" on my machine with the info command; it's down to 16" if
      made to use this instead. The gains increases with the number
      of dictionaries obviously.
      
      Change-Id: I0eeea2d8f81bb74b0d1570af658e91b56f7c2b79
      f6b0e32d
    • Jean Chalard's avatar
      Genericize getting a raw dictionary · 5564317f
      Jean Chalard authored
      This will allow for not copying the whole dictionary when only
      the header is needed.
      
      Change-Id: Ie4a649b507ccd4a430201824ed87b8b8bbf55e9f
      5564317f
  15. Nov 05, 2014
    • Jean Chalard's avatar
      Large simplification in obtaining a raw dictionary · ae55db95
      Jean Chalard authored
      That is where the last refactorings were leading. This code is
      simpler, but it's far more flexible. Importantly, it only makes
      a single copy instead of making a full disk copy for every
      intermediate step.
      Next we're going to make the "copy" part modular for processes
      that don't need to copy the whole file.
      
      Change-Id: Ief32ac665d804b9b20c44f443a9c87452ceb367a
      ae55db95
  16. Oct 31, 2014
  17. Oct 29, 2014
  18. Oct 28, 2014
  19. Oct 24, 2014
  20. Oct 23, 2014
  21. Oct 22, 2014
  22. Oct 21, 2014
    • Tadashi G. Takaoka's avatar
      Fix some compiler warnings · 5f00fe09
      Tadashi G. Takaoka authored
      This CL fixes the following compiler warnings.
      
      - Indirect access to static member
      - Access to a non-accessible member of an enclosing type
      - Parameter assignment
      - Method can be static
      - Local variable declaration hides another field or variable
      - Value of local variable is not used
      - Unused import
      - Unused private member
      - Unnecessary 'else' statement
      - Unnecessary declaration of throw exception
      - Redundant type arguments
      - Missing '@Override' annotation
      - Unused '@SuppressWarning' annotations
      
      Bug: 18003991
      Change-Id: Icfebe753e53a2cc621848f769d6a3d7ce501ebc7
      5f00fe09
    • Adrian Velicu's avatar
      Renaming "blacklist" flag to "possibly offensive" · 05172bf1
      Adrian Velicu authored
      No behaviour changes.
      Unified the overloaded FusionDictionary::add method to always take an
      isPossiblyOffensive argument.
      
      Bug: 11031090
      Change-Id: I5741a023ca1ce842d2cf10d4f6c926b0efabaa78
      05172bf1
  23. Oct 06, 2014
    • Jean Chalard's avatar
      Fix a possible NPE in Dicttool · b498d2cf
      Jean Chalard authored
      I've never seen the NPE happen and only happened to notice
      this by chance. Let's fix the code.
      
      Change-Id: If458646229f9cadcd6c15779348133f382fde783
      b498d2cf
  24. Oct 03, 2014
Loading