Skip to content
Snippets Groups Projects
  1. Sep 18, 2014
    • Yohei Yukawa's avatar
      Use Add-To-Dictionary indicator only · 5896153f
      Yohei Yukawa authored
      With this CL, the previously used commit indicator was reverted.
      Instead we use the add-to-dictionary indicator only at the moment.
      
      This CL also fixes the indicator position in bidi context.
      
      BUG: 17335734
      Change-Id: I5f7cf173ddc30876e2b01320acaff8ba4265edf6
      5896153f
  2. Sep 08, 2014
  3. Sep 03, 2014
    • Yohei Yukawa's avatar
      Follow up API signature change · 5d6ac777
      Yohei Yukawa authored
      This is a follow up CL for API signature change in
      I772c48ff18918e48a81e807b48ff907614485c09
      
      BUG: 17320996
      Change-Id: Ic8b6162bda12bf74fae79af212c5d81c400eb9e8
      5d6ac777
  4. Aug 27, 2014
    • Yohei Yukawa's avatar
      Set highlight color along with the commit indicator · 97681ebd
      Yohei Yukawa authored
      With this CL, the text highlight color is applied
      when the commit indicator is displayed.
      
      Note that the underline is not rendered when the
      background color is enabled. This is a known issue.
      
      Change-Id: Ia19355e1303e3a10e8a7d69bc47c779feb70248a
      97681ebd
    • Yohei Yukawa's avatar
      Set the text bgcolor only when CursorAnchorInfo is available · 29200b0a
      Yohei Yukawa authored
      When CursorAnchorInfo is unavailable, we shouldn't try to show
      the commit indicator and set the text highlight color.
      
      With this CL, RichInputConnection can be used to track if the
      application responded that it does support CursorAnchorInfo or
      not.  This result will be taken into consideration when
      InputLogic needs to determine whether the commit indicator
      should be displayed or not.
      
      Change-Id: I945d70eeb02a7a5f3d9b22459b23d7028508910f
      29200b0a
    • Yohei Yukawa's avatar
      Introduce a mechanism to hide the indicator speculatively · a475c854
      Yohei Yukawa authored
      This is an optional optimization to reduce the UI latency.
      
      Imagine that the commit indicator is now displayed and the
      composing text is being updated, it is highly likely that
      the commit indicator will disappear unless the application
      rejects the setComposingText request.
      
      If we assume that the application will accept the new
      composing text without any modifications, we can hide the
      indicator without waiting for the arrival of new
      CursorAnchorInfo event.
      
      This optimization isn't dangerous because we can show the
      indicator again when we receive new CursorAnchorInfo event
      and the assumption is turned out to be invalid.
      
      Change-Id: Id59c6607a1029782410611e768791af9984f14ac
      a475c854
    • Yohei Yukawa's avatar
      Introduce commit/add-to-dictionary indicators · bea17c49
      Yohei Yukawa authored
      This CL introduces commit/add-to-dictionary indicators.
      
      Note that the text is not yet highlighted when the commit
      indicator is displayed. It will be addressed in subsequent
      CLs.
      
      Change-Id: I7e9b0fcfdc0776a50a1d8cfb41ee0add813317dd
      bea17c49
  5. Aug 26, 2014
    • Jean Chalard's avatar
      Fix a bug where the top prediction would disappear. · 8380f921
      Jean Chalard authored
      This is because prediction can't be easily distinguished in
      style. This fixes the bug by simulating the right members,
      but some refactoring should be done to remove useless
      booleans.
      
      Bug: 17271923
      Change-Id: Ib88f3fb95678021624e59535492926dd315d26fb
      8380f921
  6. Aug 25, 2014
    • Yohei Yukawa's avatar
      Fix build due to an illegal character · 8681287c
      Yohei Yukawa authored
      Change-Id: I597ab26db70387b80ddcd7d51de6ae751380030d
      8681287c
    • Yohei Yukawa's avatar
      Introduce #shouldShowAddToDictionaryHint · ebc15090
      Yohei Yukawa authored
      This is a groundwork for subsequent CLs where we need to
      call this method from multiple places. This CL does not
      change any existing behaviors.
      
      Change-Id: Id8fa0360305d7383571edffab6752b2240367cf9
      ebc15090
    • Yohei Yukawa's avatar
      Dismiss "Add to dictionary" hint with non-special char event · 034c3260
      Yohei Yukawa authored
      This CL slightly extends the condition when "Add to dictionary"
      hint is dismissed.
      
      With this CL, "Add to dictionary hint" will be dismissed by any
      non-special char event. This is more comfortable especially if
      we start using more intrusive UIs such as indicator and/or
      background color with the text hint in the suggestion strip.
      
      Change-Id: I2ea0fa40d9c6663ebf5d5439be3eca2a2cbd5166
      034c3260
    • Yohei Yukawa's avatar
      Allow to add/remove background color to/from the committed text · 4a71d2c4
      Yohei Yukawa authored
      This is a groundwork for subsequent CLs where we need to
      add/remove background color to/from the commited text.
      
      In this CL, we use Spanned#SPAN_COMPOSING so that we can easily
      remove such a background color by calling
      InputConnection#finishComposingText. To make this operation easy
      and realiable, we need to track whether we have specified the
      background color to the commited text or not at one place. Here
      we use RichInputConnection for this purpose.
      
      Change-Id: I5f9bc4425c5d1b80a719a20e5baf336729ec08d2
      4a71d2c4
  7. Aug 14, 2014
  8. Aug 06, 2014
  9. Aug 05, 2014
  10. Aug 04, 2014
  11. Jul 31, 2014
  12. Jul 30, 2014
  13. Jul 29, 2014
  14. Jul 27, 2014
    • Tadashi G. Takaoka's avatar
      Make "Show correction suggestions" as a binary option · ab661e3e
      Tadashi G. Takaoka authored
      Formerly "Show correction suggestions" had three options, "always
      show", "show in portrait mode", and "always hide". The reason behind
      "show in portrait mode" was that there may not be enough screen estate
      in landscape mode to show suggestions. Because recent phone devices
      have relatively large screen, we decide to remove "show in portrait
      mode" option.
      
      Bug: 15780939
      Change-Id: I896d737452c3893d43ce20bd88127f10c1eb3d83
      ab661e3e
  15. Jul 30, 2014
  16. Jul 29, 2014
  17. Jul 30, 2014
  18. Jul 29, 2014
  19. Jul 30, 2014
  20. Jul 29, 2014
  21. Jul 17, 2014
  22. Jul 08, 2014
  23. Jul 01, 2014
Loading