- Dec 27, 2013
-
-
Jean Chalard authored
...at last Bug: 8636060 Change-Id: If5e27a9d28ff64d318dd76792f55edfc8a78d2d7
-
Jean Chalard authored
Bug: 8636060 Change-Id: Ie5027512f066d9c530a686ac559e4649a39bf439
-
Jean Chalard authored
How/when did this happen? How was it not noticed? Change-Id: I352a8dad65f8c27bf5120d567e96d9a12cfa8496
-
Jean Chalard authored
-
Jean Chalard authored
-
Jean Chalard authored
-
Jean Chalard authored
-
Jean Chalard authored
Bug: 8636060 Change-Id: Idfabf7231a80e21786ce1910b5140bb3dddcac7d
-
Jean Chalard authored
This method is confusing with the *Locked convention, and the two-step call creates a useless callback object. This is better inlined both for readability and for performance. Bug: 8636060 Change-Id: I7c427c3ca4e831388a6d54de6728b32206a45d80
-
Jean Chalard authored
The only point of this message is to send the processing on another thread. However, this will be accomplished later. Here is the exact call graph: 0. onUpdateBatchInput 1. -> MSG_UPDATE_GESTURE_PREVIEW_AND_SUGGESTION_STRIP 2. -> updateBatchInputSync 3. -> getSuggestedWordsGestureLocked 4. -> MSG_GET_SUGGESTED_WORDS 5. -> LatinIME#getSuggestedWords The point of both step 1. and step 4. is to make sure the processing is happening on the InputUpdater thread. Thus, it's useless to do it twice. Bug: 11326092 Bug: 8636060 Change-Id: Iceebb9e8879a8f15b73c987f5fd3489f27699be4
-
Jean Chalard authored
-
Jean Chalard authored
Bug: 8636060 And possibly bug: 12085864 Change-Id: I867036bc3d8bd255dc8ceebdd30e28b4b3dc4b2d
-
Jean Chalard authored
This sheds some light on what's happening here. Some comments were at least misleading, maybe indicating something is not sequenced as intended. Bug: 8636060 Change-Id: Ia74feb457a39fe4a672c27fe4203264fda940f04
-
Keisuke Kuroyanagi authored
-
Keisuke Kuroyanagi authored
Change-Id: I503f91e266c71e2370a5807d171e2254c334f7cb
-
Keisuke Kuroyanagi authored
Bug: 8187060 Change-Id: I17be7b77ff89972d3ca6823b087b7bf35105af56
-
- Dec 26, 2013
-
-
Jean Chalard authored
Bug: 12295276 Change-Id: Id359c92acde44758b12929e7bac719d5c9c7577b
-
Jean Chalard authored
-
Jean Chalard authored
Bug: 12295276 Change-Id: I187016b59213d351c943c6e0b9a2ad3708499646
-
Jean Chalard authored
All calls are already passing this Bug: 8636060 Change-Id: I13accefd7c17039dc5ec12dc9e8133ebc86451ad
-
Jean Chalard authored
Bug: 8636060 Change-Id: I5c47370a3ea5962caff4d40db2faa62accfc7147
-
Jean Chalard authored
No point in calling maybeRetrieveOlderSuggestions now that the same work is done right here. The callback is also useless now. Bug: 8636060 Change-Id: Ic14849cb6f6e6293a42cfe068f5c6b18b7677bc0
-
Keisuke Kuroyanagi authored
Bug: 8187060 Change-Id: Ide087f1e39b24695b610bd2b3c464b7e3cb9cd29
-
Keisuke Kuroyanagi authored
Bug: 8187060 Change-Id: I77775aa50763158d99753c2312fa11fe14267aef
-
Jean Chalard authored
I don't see why we would want to remove other suggestions just because the only suggestion happens to be a dictionary word. That's just inconsistent. Bug: 8636060 Change-Id: Ie2d990e5785273d625e6e5518026364165a8f2df
-
Jean Chalard authored
This only gives bad results if a gesture results in only one suggestion. Change-Id: I5a2f27f83f6901a5a9ecf22f02bdfc9cca6d9f1d
-
Keisuke Kuroyanagi authored
Change-Id: I0dfc23232ed77e1ff1aedecfa6ac022020cb1c19
-
Keisuke Kuroyanagi authored
-
Keisuke Kuroyanagi authored
Bug: 8187060 Change-Id: I2f91da12ba2a9e7ce28abd06f314e0e6125d08dc
-
Tadashi G. Takaoka authored
-
Tadashi G. Takaoka authored
Move the logic that determines how to handle gesture typing from PointerTracker to BatchInputArbiter class. This change must be checked in together with Ia7db8f4fb7. Change-Id: I5e9f786de58d8a3cb0407ae562af707710ec37fb
-
Jean Chalard authored
Bug: 8636060 Change-Id: I08a6c04986a0bd86ce4c232893e804766ebeebb9
-
Jean Chalard authored
There are far too many one-use methods. Bug: 8636060 Change-Id: I84e0669b8d2cc5a2817c42b089e874dc60e84769
-
- Dec 25, 2013
-
-
Jean Chalard authored
Bug: 8636060 Change-Id: Id6791085816891c78289b0223bf0807db2da6300
-
Jean Chalard authored
-
Keisuke Kuroyanagi authored
Change-Id: Iab05e42e947610f358472cd95d0319d0ab3f0b31
-
Keisuke Kuroyanagi authored
Bug: 8187060 Change-Id: Idba1e708d67c036072b728949d17f8bd98ae0115
-
Tadashi G. Takaoka authored
-
Keisuke Kuroyanagi authored
Bug: 8187060 Change-Id: Iabe13abcd43b381360f7080b3f4ee0533f246160
-
Tadashi G. Takaoka authored
This change must be checked in together with Ibed5330614. Change-Id: I20ba79fd20e8ea0aa3ac596c011ec5bfea528ace
-