Skip to content
Snippets Groups Projects
Select Git revision
  • master default protected
  • trie-js-dumping protected
  • hitbox-boosting protected
  • model-metadata protected
  • lm-2-finetuning-whisperggml protected
  • lm-2-finetuning protected
  • lm-2 protected
  • language_model_experiments protected
  • 0.1.24.2 protected
  • 0.1.24.2-rc1 protected
  • 0.1.24.1 protected
  • 0.1.24.1-rc1 protected
  • 0.1.24 protected
  • 0.1.24-rc1 protected
  • 0.1.23.2 protected
  • 0.1.23.1 protected
  • 0.1.23 protected
  • 0.1.22 protected
  • 0.1.21 protected
  • 0.1.20 protected
  • 0.1.19 protected
  • 0.1.18 protected
  • 0.1.17 protected
  • 0.1.16 protected
  • 0.1.15 protected
  • 0.1.14.1 protected
  • 0.1.14 protected
  • 0.1.13 protected
28 results
Search by author
  • Any Author
  • Aleksandras Kostarevas Aleksandras Kostarevas alex
  • Dean Dean dean
  • Tom Folbrecht Tom Folbrecht tom
  • sameer sameer sameer
4 authors
  1. Dec 17, 2013
  3. Dec 13, 2013
    • Jean Chalard's avatar
      Remove flags from Java side. · 7b55cd3e
      Jean Chalard authored 
      This simplifies the code quite a bit.
- GERMAN_UMLAUTS are now handled through a key-value attribute.
  The dictionary generator does not need to know about it any more.
- FRENCH_LIGATURES are deprecated as we handle them with shortcuts now.
- CONTAINS_BIGRAMS is deprecated. Bigram processing is always applied
  regardless of this flag.

Bug: 11281748
Change-Id: If567e52e245a9342adc7f3104a0f7d8d782df8c1
      7b55cd3e
    • Ken Wakasa's avatar
      Reset to 9bd6dac4 · 2fa3693c
      Ken Wakasa authored 
      The bulk merge from -bayo to klp-dev should not have been merged to master.

Change-Id: I527a03a76f5247e4939a672f27c314dc11cbb854
      2fa3693c
  5. Dec 12, 2013
    • Jean Chalard's avatar
      Remove flags from Java side. · 75de9fb7
      Jean Chalard authored 
      This simplifies the code quite a bit.
- GERMAN_UMLAUTS are now handled through a key-value attribute.
  The dictionary generator does not need to know about it any more.
- FRENCH_LIGATURES are deprecated as we handle them with shortcuts now.
- CONTAINS_BIGRAMS is deprecated. Bigram processing is always applied
  regardless of this flag.

Bug: 11281748
Change-Id: I55a11ba61d3589c1584a3fa6c941374b349b7b5c
      75de9fb7
  7. Nov 05, 2013
  9. Oct 18, 2013
  11. Oct 04, 2013
  13. Oct 02, 2013
  15. Sep 30, 2013
  17. Sep 26, 2013
  19. Sep 25, 2013
  21. Sep 19, 2013
  23. Sep 18, 2013
  25. Sep 13, 2013
  27. Sep 11, 2013
  29. Sep 09, 2013
  31. Sep 06, 2013
  33. Sep 05, 2013
  35. Aug 26, 2013
  37. Aug 22, 2013
  39. Aug 21, 2013
  41. Aug 19, 2013
  43. Aug 16, 2013
  45. Aug 15, 2013
  47. Aug 14, 2013
  49. Aug 13, 2013
  51. Aug 09, 2013
  53. Jul 24, 2013
  55. Jul 23, 2013
  57. Jul 17, 2013
  59. Apr 15, 2013
    • Jean Chalard's avatar
      Fix Binary dict tests · c2e9c511
      Jean Chalard authored 
      There are two problems here. The first one is the tests would send
an invalid unicode character. Although we could want dicttool to
handle this more gracefully, it's fine for now.

The second problem is much more serious. If a node has more than
128 children, then the java code will crash trying to read the
dictionary back because of a bug that this change fixes. In
theory, it's possible that happens when we try to load the user
history dictionary back from the disk - native code is not affected
so there is no other point that may cause a problem.
In the practice, that means you'd need to have 129 words with a
common prefix (including empty string) but all different after
this. It's almost impossible with Google Keyboard since there are
only so many keys on the keyboard that you can make a word out
of, and then again you'd have to do it repeatedly until it
actually enters the user history dictionary, wait for it to get
saved on the disk.
The bad news is, if you manage to get this far, the keyboard will
crash every time and won't be able to get up until you clear
data for the package.
The good news is, the dictionary itself is not corrupted and only
the reading code is wrong. So updating to a newer version would
actually even recover from this situation.

All in all, considering how almost-impossible this is to trigger,
I don't think even a single user actually did hit this bug.

Bug: 8583091
Change-Id: Iabb2a7f47cbd9ed3193d2a3487318d280753e071
      c2e9c511