Skip to content
Snippets Groups Projects
  1. Oct 16, 2013
    • Jean Chalard's avatar
      Remove unneeded code. · 497976e0
      Jean Chalard authored
      We don't support LOG_FULL_TEXTVIEW_CONTENTS any more, nor do
      we have any plans to support it again in the future.
      
      This also is a prelude to removing mIsExpectingUpdateSelection.
      
      Bug: 11226045
      Change-Id: Ib68c6daf52993b87225a7ea9e71a414caaecfdb7
      497976e0
  2. Aug 26, 2013
  3. Aug 07, 2013
  4. Aug 05, 2013
    • Tadashi G. Takaoka's avatar
      Remove CODE_RESEARCH · c0a732f0
      Tadashi G. Takaoka authored
      Instead of CODE_RESEARCH, special outputText ".research." is used to
      invoke a research feedback dialog.
      
      Change-Id: Ic95c956ab4f2b5f0c3f2205c9bbcdcfb67db5d6e
      c0a732f0
  5. Aug 01, 2013
  6. Jul 31, 2013
  7. Jul 05, 2013
  8. Jul 03, 2013
  9. Jul 01, 2013
  10. Jun 24, 2013
  11. Jun 22, 2013
  12. Jun 13, 2013
  13. Jun 12, 2013
    • Kurt Partridge's avatar
      Adjust settings for development-only versions · 2a1a463e
      Kurt Partridge authored
      Change-Id: I4f08632d97f182d312edc82bda3c3897a71099ad
      2a1a463e
    • Kurt Partridge's avatar
      Fix ResearchLogger feedback bug · 19ba5e67
      Kurt Partridge authored
      If the logger feedback screen is up and the user hits the home button or the
      keyboard otherwise closes, the system won't let the user enter feedback again,
      because it is waiting for the user to finish the first one.
      
      With this change, the state associated with the feedback screen is
      cleared when the user closes the keyboard.
      
      b/9398772
      
      Change-Id: I832a82793ad42e31b6b3fdb04fabcea75facde7d
      19ba5e67
  14. Jun 04, 2013
  15. Jun 03, 2013
    • Kurt Partridge's avatar
      Fix revert of committed words · 94ef5432
      Kurt Partridge authored
      Now that separators are put into their own LogUnits, they must be handled
      when going through a revert.
      
      Bug: 9088919
      
      Change-Id: Ibebd0752bb2fa38d74ac96001d63070dd419cee3
      94ef5432
    • Kurt Partridge's avatar
      Compare scrubbed strings when uncommitting LogUnits · f07024e0
      Kurt Partridge authored
      A LogUnit is only uncommitted if the LogUnit's word matches what is
      expected.  But a LogUnit never stores numbers, only scrubbed words that
      replace numbers with a special character.  So when uncommitting, the
      text from the TextView must also be scrubbed for the comparison to pass
      correctly.
      
      Bug: 9088919
      
      Change-Id: I9b56f10afce6d0cc84eb9ead3b9a9b1e061ae39c
      f07024e0
    • Kurt Partridge's avatar
      Uncommit separator LogUnits · bdff287a
      Kurt Partridge authored
      Now that separators have their own LogUnits, they must be uncommitted
      from the LogBuffer when backspacing over them.
      
      Bug: 9088919
      
      Change-Id: Ib36cc94939b93abe18850a06bced17caf8aaa5b9
      bdff287a
  16. Jun 02, 2013
  17. May 28, 2013
  18. May 23, 2013
  19. May 21, 2013
    • Kurt Partridge's avatar
      Always record word boundaries · 450d78b0
      Kurt Partridge authored
      Word boundaries are currently logged, but only if all the
      details of a word pass the privacy filter and are logged.
      
      This change records when a word is committed in all cases,
      but does not disclose the word contents or any data used in
      its construction.
      
      Addresses b/9070768
      
      Change-Id: I573679d0685c088aca65af99e46337a2f429f816
      450d78b0
    • Kurt Partridge's avatar
      Modify isAllowedToLog · 74a6196c
      Kurt Partridge authored
      Currently isAllowedToLog only checks the state of the
      ResearchLogger, and does not consider which log the data is
      going to.  This causes problems with the logs for Feedback.
      The Feedback log should inhibit normal logging procedures,
      but the system needs to be able to write specific data
      directly to it.
      
      This change renames to isAllowedToLogTo and adds the
      destination ResearchLog as a parameter.  A FeedbackLog is also
      added as a new class so it can be distinguished from other
      ResearchLogs.
      
      Change-Id: I5a1eea05bb040c26bf816b89179f44b3024fa2ad
      74a6196c
  20. May 17, 2013
    • Kurt Partridge's avatar
      Fix punctuation logging · 500dea6a
      Kurt Partridge authored
      Punctuation is currently put into the same LogUnit as the
      following word.  This is counter-intuitive and makes
      post-processing more complicated.
      
      This change causes punctuation to be put into its own
      LogUnit.
      
      A tricky case is the phantom space.  A phantom space is
      inserted right before other text, whose MotionEvents have
      already been collected and inserted into mCurrentLogBuffer.
      Phantom spaces are handled by creating their own LogUnit and
      inserting it into the LogBuffer right before
      mCurrentLogBuffer is shifted in.
      
      Change-Id: I102d7cd93982ad37ba0abb6c1ac0f66b85b5f95d
      500dea6a
  21. May 14, 2013
    • Kurt Partridge's avatar
      Remove unnecessary commit/uncommit · 993acbaa
      Kurt Partridge authored
      When the user reverts a commit, this causes the committed
      word to be changed. The user usually then goes back to edit
      that word.  Going back to edit causes an uncommit, so that
      the editing actions are added onto the LogUnit containing
      the operations used to construct the word.
      
      But currently, reverting also involves its own
      commit/uncommit pair, with the caller performing the
      uncommit, and the commit happening inside the revert
      command.  This may have been necessary in the past, when
      revert was called in different situations, but is
      unnecessary now.  Furthermore, the guarding conditions are
      currently such that the uncommit doesn't always undo the
      effects of the commit, corrupting the log output.
      
      Change-Id: I74af41f4f1db2fcabfa496dcc4a2d7bd0af19b3a
      993acbaa
    • Kurt Partridge's avatar
      Remove FeedbackLog instance variables. · 6fefc142
      Kurt Partridge authored
      For a while, the ResearchLogger supported comprehensive recording of the
      last few words in case the user wished to upload this data to give
      developers feedback.  However, this mechanism was not implemented well
      (keeping a separate copy of the data), did not make the collected data
      clear to the user, and was not working properly in the latest build (NPEs).
      The mechanism in fact was deprecated in favor of the "userRecording"
      mechanism in which the user explicitly turned on comprehensive recording,
      demonstrated the issue they were experiencing, and then turned it off.
      
      This change removes the vestiges of the FeedbackLogging mechanism.
      A feedback log is still used to hold the user's message, but it is created
      in a local variable as-needed, and not persisted in ResearchLogger.
      
      Change-Id: I6a09d0ed36e1eddb6e57895e7428d22107f75f49
      6fefc142
  22. May 11, 2013
    • Kurt Partridge's avatar
      Avoid JsonWriter multi-write error · 7d72ca0b
      Kurt Partridge authored
      JsonWriter requires that its clients pass it only a single top-level object.
      The existing implementation tries to make code cleaner by having mJsonWriter
      never be null, and instead use a global static "NULL_JSON_WRITER" that just
      discards data.  But because JsonWriter complains if more than one top-level
      object is passed, making this a global object does not work.  This change
      instead copes with mJsonWriter being null.
      
      Change-Id: Ia37ccfc8646e91f11a64713dd92d2846eb86ac54
      7d72ca0b
  23. May 10, 2013
    • Kurt Partridge's avatar
      Avoid NPE by fixing ResearchLogger initialization · a68cace7
      Kurt Partridge authored
      Previously, mMainResearchLog and mMainLogBuffer were set up
      when the user moved to a new TextView, and set to null when
      the user left the TextView.  This change causes
      mMainResearchLog, mMainLogBuffer, mFeedbackLog, and
      mFeedbackLogBuffer to be non-null forever after init() is
      called.  start() no longer sets up these fields; instead
      they are cleared and reset every time stop() is called.
      Checks for null values are now removed.
      
      The earlier code just didn't initialize these variables if
      the user disabled logging, but since the new version
      invariantly keeps these variables valid, we add a check for
      whether the user has enabled logging in publishLogUnits().
      
      Change-Id: Ifde3517f1cf924cfa33cda95fec24529b52b3c08
      a68cace7
  24. May 09, 2013
    • Kurt Partridge's avatar
      Remove unused code · 01163416
      Kurt Partridge authored
      Change-Id: I192c67e9e8de44f073abc70ec85ebcdb36356c2e
      01163416
    • Kurt Partridge's avatar
      Remove ref to LatinImeLogger preference. · ef5d760c
      Kurt Partridge authored
      This is a bug; the ResearchLogger uses ResearchSettings.readResearchLoggerEnabledFlag() instead,
      which the user cannot change.  (We assume they will just switch to a different keyboard.)
      
      Change-Id: Ib5731c9eeb2bc29d9cf8608033326674f5eb6f7b
      ef5d760c
  25. Apr 19, 2013
    • Kurt Partridge's avatar
      Allow LogUnits to hold >1 word · e92b5e14
      Kurt Partridge authored
      LogUnits have been annotated with the autocorrected words, but
      until now this was assumed to be a single word without spaces.
      But spaceless typing can result in spaces in the LogUnit label.  With this
      change, the LogUnit inspects the autocorrected text to determine how many
      words were inserted, and counts them accurately.
      
      This change corrects a privacy problem, which was that if the word sampling
      algorithm chose a LogUnit that actually contained multiple words, then more
      than two successive words would be included in the log.
      
      Change-Id: I7c01c3dd3ac33d7e96c00836256bae9c14b124ed
      e92b5e14
  26. Apr 17, 2013
    • Kurt Partridge's avatar
      Label logUnits after LatinImeOnEndBatchInput · fe052971
      Kurt Partridge authored
      Previously only a commitText would cause a LogUnit to be
      labeled with the word that the data generates.  In the case
      of gestured text, this information is available when
      LatinIME#onEndBatchInput is called. Labeling the LogUnit
      at this time means that the Log will have labeled words even
      if stop() is called before commit.
      
      Change-Id: Idb2f99a9c159a1b1aa00448a2ecddeca6c351c3e
      fe052971
    • Kurt Partridge's avatar
      Fix NPE · 4ac28ded
      Kurt Partridge authored
      Change-Id: I8a091fb63dab12a0d2ba69e2fe393249bc68d103
      4ac28ded
    • Kurt Partridge's avatar
      Fix logic error · cd39368c
      Kurt Partridge authored
      Change-Id: Ia36660c66504ba2fbb7f125704926a08726df87a
      cd39368c
    • Kurt Partridge's avatar
      Small dot in corner was not visible · 2d9d4390
      Kurt Partridge authored
      Framework change perhaps?  Even if not, this makes it more visible
      
      Change-Id: Ib6d36b5a30136c4516adac666bdff36d1cd9b337
      2d9d4390
    • Kurt Partridge's avatar
      Include nanoTime in filename · 125f22dc
      Kurt Partridge authored
      System is fast enough that sometimes SystemClock.currentTimeMillis() is duplicated
      when used to make a unique filename.
      
      Change-Id: I9454fbb5e10265d36b8e17cba183a1591d52cc7b
      125f22dc
  27. Apr 12, 2013
    • Jean Chalard's avatar
      Restart suggestions when the cursor moves. · 6a114fa7
      Jean Chalard authored
      This uses the old suggestions. It does not try to recompute
      new suggestions if there are no old suggestions yet: this is
      coming in a later change.
      If there are no suggestions, this shows the word itself
      as a suggestion.
      
      Bug: 8084810
      Change-Id: I4c2e25df0ff3673be1825f57a0c19a9d23d47a48
      6a114fa7
  28. Apr 10, 2013
    • Kurt Partridge's avatar
      Better isolate ResearchLogging data · 6108624a
      Kurt Partridge authored
      Calls to LatinIME#onStartInputViewInternal log important information
      about the context in which an IME is used.  This is reported as a
      single LogStatement.  Previously, this was not placed into a separate
      LogUnit, and was mixed in with general word data.  This change wraps
      this LogStatement in its own LogUnit.
      
      Change-Id: I0fecd41c8a1de622a764cc4b5d6902336697046c
      6108624a
Loading