This is an overdue refactoring that I have been wanted to
do forever, and that we can at last do now that suggestions
come only from instances of BinaryDictionary instances.

With this, all unit tests and regression tests are
passing again.

Bug: 13667648
Bug: 13665487
Bug: 8636060
Change-Id: Ie23a19f9b7e692edf2ee0b107ddaff2d7db564b6

Bug: 13622107
Bug: 13406701
Change-Id: I0023b398c4451253f9f717e2bd990b8a054004bc

Make mSuggest final and give DictionaryFacilitator the
responsibility to manage dictionary loading state.
This can simplify the logic to decide how to deal with
additional dictionaries when loading settings or language
switching.

Bug: 13273534
Change-Id: I9f3d328272f25addfa186fbeedaaf8417455ba99

Bug: 8187060
Change-Id: Ice2984e332b7bd3bb17174aefc80b5635b72fc50

This happens when there are tailing single quotes.

Bug: 13237314
Change-Id: I7fd2a20b25ac2217f9621d7f2510345bbd633c14

Change-Id: I2edab4e3ba4ea0b9b13f9bb224aac86cac9b9f31

Bug: 13215163
Change-Id: I00099cb4927c96de46e57e14ab906d41c9c2151a

This is more correct. When predictions, the typed word should
always be null unless explicitly passed. The text color should be
that of a valid typed word only if it's actually the typed word.

Bug: 13170509
Change-Id: I769ae100e112c37c6f02064fe9ef2f81372ca9e5

Bug: 13170509
Change-Id: Ib9f10b8a137fc773ab0e5dc903e577038e29a9e2

This change must be checked in together with I366c477516.

Bug: 12640318
Change-Id: I8d3864b9d9649c9e3306e82b01a6327b11281b1f

This change must be checked in together with Iac93eb79fc.

Bug: 12913520
Bug: 12179576
Change-Id: Ic9a40fb0529202893be8ccb6f5abfbbe6d78508c

Bug: 12913520
Change-Id: Ie15f97d90c142c51089280252b35b5ad1d226e19

No need to say this twice.

Change-Id: Ief7ac425037aa2767ee8f21c9552138a9c46afc8

Bug: 12800726
Bug: 12798403
Change-Id: I6d60f9ad39761757f8a64533f40d6441f3a36410

This constant is better located in SuggestedWords.
Or it could be in Constants, that would be fine too.

Bug: 8636060
Change-Id: I3e721bb1e2559f028dce8929eceadfe0478c5924

How/when did this happen? How was it not noticed?

Change-Id: I352a8dad65f8c27bf5120d567e96d9a12cfa8496

Bug: 8187060
Change-Id: I17be7b77ff89972d3ca6823b087b7bf35105af56

Bug: 8187060
Change-Id: I77775aa50763158d99753c2312fa11fe14267aef

Bug: 8187060
Change-Id: Idba1e708d67c036072b728949d17f8bd98ae0115

Bug: 8187060

Change-Id: Iabe13abcd43b381360f7080b3f4ee0533f246160

Bug: 11757851
Change-Id: I83e484195f036e35cbae21fe63148bc9c22bfad7

The bulk merge from -bayo to klp-dev should not have been merged to master.

Change-Id: I527a03a76f5247e4939a672f27c314dc11cbb854

Change-Id: If7497310485a895dd22b8df29dc13508acaa0ab6

Now, PersonalizationPredictionDictionary can be used not only
for prediction but also for suggestions.
We should rename PersonalizationPredictionDictionary to
PersonalizationDictionary.

Change-Id: Ifcf4459072f3523e3f3dc783f12e15b89cdbb12d

Bug: 11772864
Change-Id: I393352494b1ef81d24622a22fe7556d09945d6ff

Bug: 11311002
Change-Id: I62955e364c9ffc75322cf05fa3ad7985f1d09259

This allows testing for suggestion freshness in an asynchronous
suggestions world.

In-advance cherrypick of Ic76cd17568598d8534aec81e037f9e37f52eb6b4
because there's a merge conflict.

Bug: 11301597
Change-Id: I4aec765a975298fcac30a48dede73d2622224fe5

This allows testing for suggestion freshness in an asynchronous
suggestions world.
Cherry-pick of Ic76cd175

Bug: 11301597
Change-Id: I45a84de0632062475eebe30234b3147f1c680359

Cherry-pick of I62955e36

Bug: 11311002
Change-Id: I5b11cb48e6dd0563fc29566fe0d27864be2beb0a

This allows testing for suggestion freshness in an asynchronous
suggestions world.

Bug: 11301597
Change-Id: Ic76cd17568598d8534aec81e037f9e37f52eb6b4

Bug: 11311002
Change-Id: I62955e364c9ffc75322cf05fa3ad7985f1d09259

Bug: 11076722
Change-Id: I0de10ab24d33ec31f45664fe92d80d5a7bec9c20

Bug: 6669677

Change-Id: I2462777eaa07600f1c774226adfc4f351882f523

Bug: 6669677
Change-Id: Id4344f2a30e9827f210055d6c65ee7776d3a63e3

Bug: 10445496
Change-Id: Ib7bd05aea59ae6c9b8ce31299ef2235521b0e350

Bug: 9059617
Change-Id: I7a47b0675446fc4f39628c60d16de9aea90d1b4d

Bug: 10699291
Change-Id: I7c8a3a57e8d189b72a17e4b9c6831becee6ec146

This reverts commit 78f707a1.
Change-Id: I5dd4f2d40314002736226886477563f29a25079c

This reverts commit 820c290a.

Change-Id: I5c50731ff9f330c05c5841b8c65f16e28e67422c

Change-Id: Ib527d31f9c2dd6dc385cb2f767cd90d9d28a1b1b