- Apr 26, 2012
-
-
Jean Chalard authored
This is a cherry-pick of Icb602762 onto jb-dev. Bug: 6355745 Change-Id: Icb602762bb0d81472f024fa491571062ec1fc4e9
-
Jean Chalard authored
-
Jean Chalard authored
-
Tadashi G. Takaoka authored
-
Tadashi G. Takaoka authored
This change also refactors the language name selection to use text x-scale. Bug: 6396854 Change-Id: I31249a85bd042a93d627f40413161aef13617c87
-
Tadashi G. Takaoka authored
-
Tadashi G. Takaoka authored
Bug: 6374565 Bug: 6381144 Change-Id: I2fff2323e8f0f79df2b71ed030a1a0953b2854c8
-
Jean Chalard authored
This is a cherry-pick of change I2d81742f Bug: 6313806 Change-Id: Ic1190b7980d032bc11b57841bca040d980889b6b
-
Tadashi G. Takaoka authored
-
Jean Chalard authored
This is a cherry pick of I14b67e51 on jb-dev Bug: 6340915 Change-Id: Iaa512abe1b19ca640ea201f9761fd7f1416270ed
-
Tadashi G. Takaoka authored
Bug: 6400718 Change-Id: Id5dce156ad397b911bfeaedeeddd4aeb21a10b3a
-
Tadashi G. Takaoka authored
* Move SubtypeLocale.get{Full,Middle,Short}DisplayName() to LatinLeyboardView and add unit tests (SpacebarTextTests). * Add SubtypeLocale.getSubtypeDisplayName() This is a cherry-pick of I57420c6a from Master. Bug: 6393865 Change-Id: I68748189c17c73984ac4ae05a5a40fb54bf46453
-
- Apr 25, 2012
-
-
Tadashi G. Takaoka authored
Bug: 4460018 Change-Id: I9a29f6a322af66f6a152fa1883b3686c5f7a3328
-
Tadashi G. Takaoka authored
Bug: 6384416 Bug: 6387408 Change-Id: Ia7b0653a09410b42a55915815c887bf0ad56c856
-
Tadashi G. Takaoka authored
Bug: 6384416 Change-Id: Id5fa4742ad900fafb82cc37a0bbb9f380b99254d
-
Tadashi G. Takaoka authored
-
Tadashi G. Takaoka authored
Bug: 6393755 Change-Id: I3a74b23f934cd52925026ad04647cc76de92ee07
-
Tadashi G. Takaoka authored
Bug: 6029665 Change-Id: I4bf0f5703d0c11d76bab478da2729b0e20fc64ea
-
- Apr 24, 2012
-
-
Eric Fischer authored
-
Eric Fischer authored
Change-Id: I17745dd7dbabcc6409361e1b2fa0141ff3f13e09
-
Tom Ouyang authored
-
Tom Ouyang authored
Bug: 6380724 Change-Id: Ic1d0d902dc45ecb41a1792f33a60ab85e606fcef
-
Tadashi G. Takaoka authored
Change-Id: If8b605778196a5c0a0205ebd49378759027ee265
-
Jean Chalard authored
-
Tadashi G. Takaoka authored
-
Tadashi G. Takaoka authored
-
Jean Chalard authored
The position itself is still a const int = 0 until we have the previous word passed to the function. This basically does the plumbing. Bug: 6313806 Change-Id: Ib58995f334fe93e3ff5704d7c79f332017f101ac
-
Tadashi G. Takaoka authored
-
Tadashi G. Takaoka authored
Partially reverts the Ia3680d84. Bug: 6356125 Change-Id: I8faa810b833cb98ce6f0f760aa1722e63475cd45
-
Tadashi G. Takaoka authored
Bug: 6371604 Change-Id: I1054685b9985b6923e3176679b3d95424d8114e0
-
Jean Chalard authored
-
Tadashi G. Takaoka authored
-
Jean Chalard authored
This is not the Right fix ; the Right fix would be to read the file in a buffered way. However this delivers tolerable performance for a minimal amount of code changes. We may want to skip submitting this patch, but keep it around in case we need to use the functionality until we have a good patch. Change-Id: I1ba938f82acfd9436c3701d1078ff981afdbea60
-
Tadashi G. Takaoka authored
Change-Id: Iee5e7e93e5f319551a8ad28c58813c00fc713308
-
Jean Chalard authored
-
Jean Chalard authored
The core reason for this is quite shrewd. When a word is a bigram of itself, the corresponding chargroup will have a bigram referring to itself. When computing bigram offsets, we use cached addresses of chargroups, but we compute the size of the node as we go. Hence, a discrepancy may happen between the base offset as seen by the bigram (which uses the recomputed value) and the target offset (which uses the cached value). When this happens, the cached node address is too large. The relative offset is negative, which is expected, since it points to this very charnode whose start is a few bytes earlier. But since the cached address is too large, the offset is computed as smaller than it should be. On the next pass, the cache has been refreshed with the newly computed size and the seen offset is now correct (or at least, much closer to correct). The correct value is larger than the previously computed offset, which was too small. If it happens that it crosses the -255 or -65335 boundary, the address will be seen as needing 1 more byte than previously computed. If this is the only change in size of this node, the node will be seen as having a larger size than previously, which is unexpected. Debug code was catching this and crashing the program. So this case is very rare, but in an even rarer occurence, it may happen that in the same node, another chargroup happens to decrease it size by the same amount. In this case, the node may be seen as having not been modified. This is probably extremely rare. If on top of this, it happens that no other node has been modified, then the file may be seen as complete, and the discrepancy left as is in the file, leading to a broken file. The probability that this happens is abyssally low, but the bug exists, and the current debug code would not have caught this. To further catch similar bugs, this change also modifies the test that decides if the node has changed. On grounds that all components of a node may only decrease in size with each successive pass, it's theoritically safe to assume that the same size means the node contents have not changed, but in case of a bug like the bug above where a component wrongly grows while another shrinks and both cancel each other out, the new code will catch this. Also, this change adds a check against the number of passses, to avoid infinite loops in case of a bug in the computation code. This change fixes this bug by updating the cached address of each chargroup as we go. This eliminates the discrepancy and fixes the bug. Bug: 6383103 Change-Id: Ia3f450e22c87c4c193cea8ddb157aebd5f224f01
-
Tadashi G. Takaoka authored
Bug: 6355346 Change-Id: I96933719cc94f25e6c7ecb1d6345c11b6acc4134
-
Tadashi G. Takaoka authored
-
Tadashi G. Takaoka authored
Bug: 6384416 Change-Id: I878071b8b78acce51649f9637b59830ab681c696
-
Jean Chalard authored
-