- Feb 20, 2014
-
-
Jean Chalard authored
-
Jean Chalard authored
Also fix a small cosmetic bug where the suggestion strip would flash. Bug: 12951777 Change-Id: I68b7bb9175571de9c718f737eebd9f67ea04a931
-
Jean Chalard authored
-
Jean Chalard authored
When the cursor is moved by the user, the RichInputConnection is told about it. However, to work around a framework bug, it also looks at how many characters are in the buffer before the cursor, and if that's more than the value it's been passed, it deduces that's a framework bug and there are at least as many characters as seen before the cursor, so it puts the expected cursor position there. When you move the cursor, TextView calls onUpdateSelection, and when you move it fast, you'll get rapid-fire calls to onUpdateSelection. This is fine, the RIC is equipped to deal with that. However, these calls take some time to make it to the IME. In this instance, when the first call gets through and the IME calls TextView (synchronously) for text before the cursor, the cursor has already moved in the app, and TextView returns more characters than the cursor position was declared to be in this instance, so the RIC sets that as the expected cursor position. Sure enough, a split second later, the second call to onUpdateSelection arrives, with the new cursor position set where the RIC had found it too early. The RIC takes that as an "expected" cursor move, and the input does not get reset. Luckily, we have a way out. As far as we know, the framework bug only manifests itself upon rotation, which means we should only have to adjust for it in onStartInputView. Doing it in onUpdateSelection is too zealous (and probably too distrustful of the app to send the correct cursor positions). So we should just take care of the rotation case (by calling tryFixLyingCursorPosition in onStartInputView) and remove the compensating code in resetCachesUponCursorMoves. Bug: 12982502 Change-Id: Ic3c1408a1ec45deaea63b01d98376a79ae567d77
-
Keisuke Kuroyanagi authored
-
Keisuke Kuroyanagi authored
Bug: 11122480 Change-Id: I79a4a73ff09a2d34d4ca094d705e901fb4bc855c
-
Keisuke Kuroyanagi authored
Bug: 13106697 Change-Id: If81f77c3cefdefae94cb9145aa9f700494f8237a
-
Keisuke Kuroyanagi authored
-
Keisuke Kuroyanagi authored
-
Keisuke Kuroyanagi authored
Bug: 12916055 Change-Id: I439f21aa87cfa1f71e0354370a1514af03d68f6c
-
Keisuke Kuroyanagi authored
-
Keisuke Kuroyanagi authored
Bug: 13107471 Change-Id: I47df79bc6f015c212d1b6d2f63b2efc5da24294e
-
Keisuke Kuroyanagi authored
Bug: 10667710 Change-Id: Ib2be57d8c4cbbb34f64555d84ea6fd571cfdd247
-
Keisuke Kuroyanagi authored
-
Keisuke Kuroyanagi authored
-
Keisuke Kuroyanagi authored
Bug: 13106638 Change-Id: Ib48ef0a191a436552c49b6e817dfa13fe1567ae8
-
Jean Chalard authored
-
Tadashi G. Takaoka authored
This CL also reset the notice version to 1. This CL must be checked in together with Iea8d9ff038. Change-Id: I838f7b5b295388d64d6aba90f50b06654eba16e5
-
Tadashi G. Takaoka authored
Change-Id: I27aad91d3f821b5c0d6a3c6405b4a9d03c5bd814
-
Jean Chalard authored
-
Tadashi G. Takaoka authored
-
Tadashi G. Takaoka authored
This reverts commit 0a4ac795. Bug: 10587358 Change-Id: Ib4c472756fb9a6ebba4a66d34a9652f1b5afc714
-
Keisuke Kuroyanagi authored
Bug: 13067743 Change-Id: I6fc68b5151430a5ab51777f4c381e20f5a657924
-
Jean Chalard authored
...that would cause a crash Bug: 13082186 Change-Id: Ie12575c27dfdd2029bc9d5f0647e444f69770afc
-
Tadashi G. Takaoka authored
Key popup show up start scale 98% Key popup dismiss end scale 94% Key popup show up duration 17ms Key popup dismiss duration 53ms Bug: 11518021 Change-Id: Icfde99969163f05cfaed1050ea074545d44db13b
-
Jean Chalard authored
Typo fixes and clarifications Change-Id: I0f7e0b6e665232bb995172fff10521c7f17599eb
-
- Feb 19, 2014
-
-
Baligh Uddin authored
-
Keisuke Kuroyanagi authored
Wrongly removed in I1f50cb137b6054dc9. Bug: 13067743 Change-Id: I27cd221cb7f6e403c3fc128d65d14dbf628b6f55
-
Keisuke Kuroyanagi authored
-
Keisuke Kuroyanagi authored
Bug: 13085169 Change-Id: Icfb6184dfefc6a336432203c071d9e30ae8bf990
-
Keisuke Kuroyanagi authored
Bug: 13067743 Change-Id: I1f50cb137b6054dc9442237586b70fc0aa2bf427
-
Tadashi G. Takaoka authored
AlertDialog.Builder.setOnDismissListener is supported from API 17. Bug: 10587358 Change-Id: Ie8ce8e283b803f7f6bb58ced446e676339f980eb
-
Tadashi G. Takaoka authored
-
Tadashi G. Takaoka authored
This change must be checked in together with Ifde70b1d3b. Bug: 10587358 Change-Id: I9dc48f9d521e0e6f6269e4f184389ba805f3053f
-
Tadashi G. Takaoka authored
-
Tadashi G. Takaoka authored
Bug: 13082467 Change-Id: I9290974821d22067e7ddd60dce441b11ca533a0f
-
Keisuke Kuroyanagi authored
-
Tadashi G. Takaoka authored
-
Keisuke Kuroyanagi authored
Bug: 13066902 Change-Id: I8fd0f361a4ca55aaab8a2bd2e11f48f92b87fc93
-
Keisuke Kuroyanagi authored
Change-Id: Icb2821f61c4203254b7d573cad5ce71fbf0ed841
-